agavra commented on code in PR #9782:
URL: https://github.com/apache/pinot/pull/9782#discussion_r1023383006


##########
pinot-query-runtime/src/test/resources/queries/JoinQuery.json:
##########
@@ -0,0 +1,200 @@
+{
+  "basic_join_queries": {

Review Comment:
   hmm, I thought I left this somewhere but I asked for:
   - tests involving joins on different types
   - tests with joins that have functions in the join condition
   - joins without join conditions (`SELECT * FROM a,b`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to