61yao commented on code in PR #9806:
URL: https://github.com/apache/pinot/pull/9806#discussion_r1023389693
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) {
return createSqlType(SqlTypeName.VARCHAR);
case BYTES:
return createSqlType(SqlTypeName.VARBINARY);
+ case BIG_DECIMAL:
Review Comment:
If I remember the code correctly, this BIG_DECIMAL is not passed down
correctly from broker to server in the thrift protocol. This is also one of the
reason I feel we should do integration test at broker level.
Can you help verify this?
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) {
return createSqlType(SqlTypeName.VARCHAR);
case BYTES:
return createSqlType(SqlTypeName.VARBINARY);
+ case BIG_DECIMAL:
Review Comment:
Actually, I think the code I read before is for literal type. maybe it is
working for the sql type. Let me double check and get back to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
