61yao commented on code in PR #9792:
URL: https://github.com/apache/pinot/pull/9792#discussion_r1023126923
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -204,6 +204,7 @@ public FieldSpec.DataType getDataType() {
class FunctionCall implements RexExpression {
@ProtoProperties
private SqlKind _sqlKind;
+ // TODO: Make sure _sqlKind matches _functionName.
Review Comment:
Does this mean the _functionName only matches when it is standard SQL
function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
