walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023086131
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ########## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator; + +import com.google.common.base.Suppliers; +import java.util.List; +import java.util.function.Supplier; +import org.apache.pinot.common.request.context.ThreadTimer; +import org.apache.pinot.core.common.Operator; +import org.apache.pinot.query.mailbox.MailboxIdentifier; +import org.apache.pinot.query.runtime.blocks.TransferableBlock; + + +/** + * An {@code OpChain} represents a chain of operators that are separated + * by send/receive stages. + */ +public class OpChain { + + private final Operator<TransferableBlock> _root; + private final List<MailboxIdentifier> _inputMailboxes; + // TODO: build timers that are partial-execution aware + private final Supplier<ThreadTimer> _timer; + + public OpChain(Operator<TransferableBlock> root, List<MailboxIdentifier> inputMailboxes) { + _root = root; + _inputMailboxes = inputMailboxes; + + // use memoized supplier so that the timing doesn't start until the first time we get + // the timer + _timer = Suppliers.memoize(ThreadTimer::new)::get; + } + + public Operator<TransferableBlock> getRoot() { + return _root; + } + + public List<MailboxIdentifier> getInputMailboxes() { + return _inputMailboxes; + } Review Comment: doesn't seem like this is being used. from what I understand on the triggering mechanism: - register - onDataAvailable - next().getRoot().nextBlock() completes all should be able to identify which opChain to call based on jobID alone. do we need the input mailbox id list? ########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PhysicalPlanVisitor.java: ########## @@ -56,18 +59,24 @@ * @see org.apache.pinot.query.runtime.QueryRunner#processQuery(DistributedStagePlan, ExecutorService, Map) */ public class PhysicalPlanVisitor implements StageNodeVisitor<Operator<TransferableBlock>, PlanRequestContext> { - private static final PhysicalPlanVisitor INSTANCE = new PhysicalPlanVisitor(); - public static Operator<TransferableBlock> build(StageNode node, PlanRequestContext context) { - return node.visit(INSTANCE, context); + private List<MailboxIdentifier> _inputMailboxIds = new ArrayList<>(); Review Comment: can we move this into the PlanRequestContext? otherwise, we need to adjust the comment for the static usage of this visitor class ########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java: ########## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.executor; + +import com.google.common.util.concurrent.AbstractExecutionThreadService; +import com.google.common.util.concurrent.Monitor; +import java.util.concurrent.ExecutorService; +import org.apache.pinot.common.request.context.ThreadTimer; +import org.apache.pinot.core.util.trace.TraceRunnable; +import org.apache.pinot.query.mailbox.MailboxIdentifier; +import org.apache.pinot.query.runtime.blocks.TransferableBlock; +import org.apache.pinot.query.runtime.operator.OpChain; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * This class provides the implementation for scheduling multistage queries on a single node based + * on the {@link OpChainScheduler} logic that is passed in. Multistage queries support partial execution + * and will return a NOOP metadata block as a "yield" signal, indicating that the next operator + * chain ({@link OpChainScheduler#next()} will be requested. + * + * <p>Note that a yielded operator chain will be re-registered with the underlying scheduler. + */ +@SuppressWarnings("UnstableApiUsage") +public class OpChainSchedulerService extends AbstractExecutionThreadService { + + private static final Logger LOGGER = LoggerFactory.getLogger(OpChainSchedulerService.class); + + private final OpChainScheduler _scheduler; + private final ExecutorService _workerPool; + + // anything that is guarded by this monitor should be non-blocking + private final Monitor _monitor = new Monitor(); + protected final Monitor.Guard _hasNextOrClosing = new Monitor.Guard(_monitor) { Review Comment: this is more of a question --> why one of these is private and the other is protected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
