walterddr commented on code in PR #9782:
URL: https://github.com/apache/pinot/pull/9782#discussion_r1023369993
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FilterOperand.java:
##########
@@ -230,6 +230,7 @@ public Predicate(List<RexExpression> functionOperands,
DataSchema dataSchema) {
"Expected 2 function ops for Predicate but got:" +
functionOperands.size());
_lhs = TransformOperand.toTransformOperand(functionOperands.get(0),
dataSchema);
_rhs = TransformOperand.toTransformOperand(functionOperands.get(1),
dataSchema);
+ // TODO: correctly handle type hoisting. here we favor left type first.
which is not correct for say 2 < 2.3
Review Comment:
will fix in follow up PR. basically `WHERE 2 < 2.3` is false and `WHERE 2.3
> 2` is true nowadays
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -22,7 +22,7 @@
* Configuration for setting up query runtime.
*/
public class QueryConfig {
- public static final long DEFAULT_TIMEOUT_NANO = 10_000_000_000L;
+ public static final long DEFAULT_TIMEOUT_NANO = 1000_000_000_000L;
Review Comment:
```suggestion
public static final long DEFAULT_TIMEOUT_NANO = 10_000_000_000L;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
