61yao commented on code in PR #9791:
URL: https://github.com/apache/pinot/pull/9791#discussion_r1023137348
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -206,6 +206,7 @@ class FunctionCall implements RexExpression {
private SqlKind _sqlKind;
@ProtoProperties
private FieldSpec.DataType _dataType;
+ // TODO: Make sure _functionName and _sqlKind are matching.
Review Comment:
Removed this one
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FunctionOperand.java:
##########
@@ -29,7 +29,9 @@
import org.apache.pinot.query.planner.logical.RexExpression;
import org.apache.pinot.query.runtime.operator.OperatorUtils;
-
+/*
+ Functions that apply to TransformOperator.
+ */
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
