[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] mqliang closed pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
mqliang closed pull request #7724: URL: https://github.com/apache/pinot/pull/7724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated: correct way to send headers via url conn (#7728)

2021-11-08 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2075cbe correct way to send headers via url con

[GitHub] [pinot] apucher merged pull request #7728: correct way to send headers via url conn

2021-11-08 Thread GitBox
apucher merged pull request #7728: URL: https://github.com/apache/pinot/pull/7728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7728: correct way to send headers via url conn

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7728: URL: https://github.com/apache/pinot/pull/7728#issuecomment-963846406 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7728?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7728: correct way to send headers via url conn

2021-11-08 Thread GitBox
codecov-commenter commented on pull request #7728: URL: https://github.com/apache/pinot/pull/7728#issuecomment-963846406 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7728?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] klsince opened a new pull request #7728: correct way to send headers via url conn

2021-11-08 Thread GitBox
klsince opened a new pull request #7728: URL: https://github.com/apache/pinot/pull/7728 ## Description with this fix, the custom headers are sent out properly like below ``` $ nc -l 8000 // starting a dummy server POST /query/sql HTTP/1.1 Authorization: . // a custom h

[GitHub] [pinot] walterddr closed pull request #7726: [Draft] Grpc broker test

2021-11-08 Thread GitBox
walterddr closed pull request #7726: URL: https://github.com/apache/pinot/pull/7726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pinot] walterddr commented on pull request #7726: [Draft] Grpc broker test

2021-11-08 Thread GitBox
walterddr commented on pull request #7726: URL: https://github.com/apache/pinot/pull/7726#issuecomment-963800392 doesnt' work. closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7725: [Cleanup] Remove the old deprecated SegmentConverter

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7725: URL: https://github.com/apache/pinot/pull/7725#issuecomment-963679063 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] mqliang closed pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
mqliang closed pull request #7724: URL: https://github.com/apache/pinot/pull/7724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7678: Fixing DISTINCT with AS function

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7678: URL: https://github.com/apache/pinot/pull/7678#issuecomment-962252170 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7678?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7678: Fixing DISTINCT with AS function

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7678: URL: https://github.com/apache/pinot/pull/7678#issuecomment-962252170 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7678?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7678: Fixing DISTINCT with AS function

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7678: URL: https://github.com/apache/pinot/pull/7678#issuecomment-962252170 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7678?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] mqliang closed pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
mqliang closed pull request #7724: URL: https://github.com/apache/pinot/pull/7724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7725: [Cleanup] Remove the old deprecated SegmentConverter

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7725: URL: https://github.com/apache/pinot/pull/7725#issuecomment-963679063 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] jasperjiaguo edited a comment on pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
jasperjiaguo edited a comment on pull request #7653: URL: https://github.com/apache/pinot/pull/7653#issuecomment-963705986 > Thank you for the updates. > > Would you mind still adding the unit test for a different keystore type? It doesn't just serve robustness but similarly as docum

[GitHub] [pinot] apucher commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
apucher commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745209268 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public interfac

[GitHub] [pinot] apucher commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
apucher commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745209268 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public interfac

[GitHub] [pinot] amrishlal commented on pull request #7568: EXPLAIN PLAN

2021-11-08 Thread GitBox
amrishlal commented on pull request #7568: URL: https://github.com/apache/pinot/pull/7568#issuecomment-963714474 @mayankshriv @Jackie-Jiang @kishoreg Please review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[pinot] branch master updated (94a17f3 -> 39daba6)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 94a17f3 memoize literals in query context in order to deduplicate them (#7720) add 39daba6 format query parser

[GitHub] [pinot] Jackie-Jiang merged pull request #7727: format query parser tests

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7727: URL: https://github.com/apache/pinot/pull/7727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] xiangfu0 opened a new pull request #7727: format query parser tests

2021-11-08 Thread GitBox
xiangfu0 opened a new pull request #7727: URL: https://github.com/apache/pinot/pull/7727 ## Description Format 3 tests ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **back

[GitHub] [pinot] jasperjiaguo commented on pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
jasperjiaguo commented on pull request #7653: URL: https://github.com/apache/pinot/pull/7653#issuecomment-963705986 > Thank you for the updates. > > Would you mind still adding the unit test for a different keystore type? It doesn't just serve robustness but similarly as documentatio

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7702: add SPI for complex columns

2021-11-08 Thread GitBox
siddharthteotia commented on a change in pull request #7702: URL: https://github.com/apache/pinot/pull/7702#discussion_r745199786 ## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/SubStructureSelector.java ## @@ -0,0 +1,25 @@ +/** + * Lice

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls c

2021-11-08 Thread GitBox
siddharthteotia commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745198982 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls c

2021-11-08 Thread GitBox
siddharthteotia commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745198982 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public

[GitHub] [pinot] xiangfu0 closed issue #7673: Upgrade args4j to picocli

2021-11-08 Thread GitBox
xiangfu0 closed issue #7673: URL: https://github.com/apache/pinot/issues/7673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [pinot] walterddr commented on issue #7673: Upgrade args4j to picocli

2021-11-08 Thread GitBox
walterddr commented on issue #7673: URL: https://github.com/apache/pinot/issues/7673#issuecomment-963701902 I think we can close this one @xiangfu0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pinot] branch master updated (ada94c2 -> 94a17f3)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from ada94c2 follow up with picocli migration (#7705) add 94a17f3 memoize literals in query context in order to dedu

[GitHub] [pinot] Jackie-Jiang merged pull request #7720: memoize literals in query context in order to deduplicate them

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7720: URL: https://github.com/apache/pinot/pull/7720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] jasperjiaguo commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls chan

2021-11-08 Thread GitBox
jasperjiaguo commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745193796 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java ## @@ -110,7 +119,9 @@ private void attachSSLHandler(SocketCha

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7725: [Cleanup] Remove the old deprecated SegmentConverter

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7725: URL: https://github.com/apache/pinot/pull/7725#issuecomment-963679063 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[pinot] branch master updated (67b5b67 -> ada94c2)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 67b5b67 Fix the flaky SimpleMinionClusterIntegrationTest (#7723) add ada94c2 follow up with picocli migration (

[GitHub] [pinot] Jackie-Jiang merged pull request #7705: follow up with picocli migration

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7705: URL: https://github.com/apache/pinot/pull/7705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang closed issue #7673: Upgrade args4j to picocli

2021-11-08 Thread GitBox
Jackie-Jiang closed issue #7673: URL: https://github.com/apache/pinot/issues/7673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7661: implement size balanced V4 raw chunk format

2021-11-08 Thread GitBox
Jackie-Jiang commented on a change in pull request #7661: URL: https://github.com/apache/pinot/pull/7661#discussion_r745184469 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkSVForwardIndexReaderV4.java #

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7725: [Cleanup] Remove the old deprecated SegmentConverter

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7725: URL: https://github.com/apache/pinot/pull/7725#issuecomment-963679063 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7725: [Cleanup] Remove the old deprecated SegmentConverter

2021-11-08 Thread GitBox
codecov-commenter commented on pull request #7725: URL: https://github.com/apache/pinot/pull/7725#issuecomment-963679063 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7692: refactor DataSchema to pinot-spi

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7692: URL: https://github.com/apache/pinot/pull/7692#issuecomment-961259336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
codecov-commenter commented on pull request #7724: URL: https://github.com/apache/pinot/pull/7724#issuecomment-963674976 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7705: follow up with picocli migration

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7705: URL: https://github.com/apache/pinot/pull/7705#issuecomment-961526091 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7705: follow up with picocli migration

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7705: URL: https://github.com/apache/pinot/pull/7705#issuecomment-961526091 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7692: refactor DataSchema to pinot-spi

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7692: URL: https://github.com/apache/pinot/pull/7692#issuecomment-961259336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] apucher commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
apucher commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745172852 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public interfac

[GitHub] [pinot] Jackie-Jiang opened a new pull request #7725: [Cleanup] Remove the old deprecated SegmentConverter

2021-11-08 Thread GitBox
Jackie-Jiang opened a new pull request #7725: URL: https://github.com/apache/pinot/pull/7725 ## Description All the functionality of `SegmentConverter` is replaced by `SegmentProcessorFramework`. ## Release Notes `MergeSegments` is no longer available in `pinot-admin`, use `Se

[GitHub] [pinot] mqliang opened a new pull request #7724: Split thread cpu time into three metrics

2021-11-08 Thread GitBox
mqliang opened a new pull request #7724: URL: https://github.com/apache/pinot/pull/7724 ## Description This PR split the ThreadCpuTimeNs metric into 3 parts: * threadCpuTimeNs * systemActivitiesCpuTimeNs * responseSerializationCpuTimeNs Splitting will help us under

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls c

2021-11-08 Thread GitBox
siddharthteotia commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745156486 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls c

2021-11-08 Thread GitBox
siddharthteotia commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745156486 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public

[pinot] branch master updated (52ec46e -> 67b5b67)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 52ec46e Remove the AutomatonBasedRegexpPredicateEvaluator and use regular RegexpLikePredicateEvaluator (#7715)

[GitHub] [pinot] Jackie-Jiang merged pull request #7723: Fix the flaky SimpleMinionClusterIntegrationTest

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7723: URL: https://github.com/apache/pinot/pull/7723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang merged pull request #7715: Remove the AutomatonBasedRegexpPredicateEvaluator and use regular RegexpLikePredicateEvaluator

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7715: URL: https://github.com/apache/pinot/pull/7715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch master updated (2605122 -> 52ec46e)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 2605122 Allow adding JSON data type for dimension column types (#7718) add 52ec46e Remove the AutomatonBasedReg

[GitHub] [pinot] apucher commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
apucher commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745150036 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public interfac

[GitHub] [pinot] jasperjiaguo commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls chan

2021-11-08 Thread GitBox
jasperjiaguo commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745140386 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public int

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7723: Fix the flaky SimpleMinionClusterIntegrationTest

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7723: URL: https://github.com/apache/pinot/pull/7723#issuecomment-963623525 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7723: Fix the flaky SimpleMinionClusterIntegrationTest

2021-11-08 Thread GitBox
codecov-commenter commented on pull request #7723: URL: https://github.com/apache/pinot/pull/7723#issuecomment-963623525 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[pinot] branch master updated: Allow adding JSON data type for dimension column types (#7718)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2605122 Allow adding JSON data type for dimensio

[GitHub] [pinot] Jackie-Jiang merged pull request #7718: Allow adding JSON data type for dimension column types

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7718: URL: https://github.com/apache/pinot/pull/7718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang closed issue #7717: Allow adding JSON data type for dimension column types

2021-11-08 Thread GitBox
Jackie-Jiang closed issue #7717: URL: https://github.com/apache/pinot/issues/7717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated (7a24845 -> a17bdd7)

2021-11-08 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 7a24845 inline binary comparison ops to prevent function call overhead (#7709) add a17bdd7 Skip pinot.admin.s

[GitHub] [pinot] xiangfu0 merged pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
xiangfu0 merged pull request #7722: URL: https://github.com/apache/pinot/pull/7722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] Jackie-Jiang opened a new pull request #7723: Fix the flaky SimpleMinionClusterIntegrationTest

2021-11-08 Thread GitBox
Jackie-Jiang opened a new pull request #7723: URL: https://github.com/apache/pinot/pull/7723 When submitting a minion task, the actual task scheduling is generated async, and might not be reflected immediately. Added a 10s wait for verifying the task count. Sample failure: https://

[GitHub] [pinot] jackjlli commented on a change in pull request #7721: Fix SDF pattern in DataPreprocessingHelper

2021-11-08 Thread GitBox
jackjlli commented on a change in pull request #7721: URL: https://github.com/apache/pinot/pull/7721#discussion_r745105710 ## File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/preprocess/DataPreprocessingHelper.java ###

[pinot] branch fix-data-preprocess-sdf-pattern updated (4c265fc -> 751e8f6)

2021-11-08 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-data-preprocess-sdf-pattern in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 4c265fc Fix SDF pattern in DataPreprocessingHelper add 751e8f6 Fix SDF pattern in DataPr

[pinot] branch fix-data-preprocess-sdf-pattern updated (2e3b0a0 -> 4c265fc)

2021-11-08 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-data-preprocess-sdf-pattern in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 2e3b0a0 Fix SDF pattern in DataPreprocessingHelper add 4c265fc Fix SDF pattern in DataPr

[pinot] branch fix-data-preprocess-sdf-pattern updated (33ff293 -> 2e3b0a0)

2021-11-08 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-data-preprocess-sdf-pattern in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 33ff293 Fix SDF pattern in DataPreprocessingHelper add 2e3b0a0 Fix SDF pattern in DataPr

[GitHub] [pinot] xiangfu0 commented on pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
xiangfu0 commented on pull request #7722: URL: https://github.com/apache/pinot/pull/7722#issuecomment-963576472 cc @kkrugler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7692: refactor DataSchema to pinot-spi

2021-11-08 Thread GitBox
Jackie-Jiang commented on a change in pull request #7692: URL: https://github.com/apache/pinot/pull/7692#discussion_r745091691 ## File path: pinot-connectors/pinot-spark-connector/src/test/scala/org/apache/pinot/connector/spark/connector/PinotUtilsTest.scala ## @@ -19,12 +19,1

[GitHub] [pinot] walterddr commented on a change in pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
walterddr commented on a change in pull request #7722: URL: https://github.com/apache/pinot/pull/7722#discussion_r745088200 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java ## @@ -192,7 +192,11 @@ public static void main(String[] arg

[GitHub] [pinot] walterddr commented on a change in pull request #7705: follow up with picocli migration

2021-11-08 Thread GitBox
walterddr commented on a change in pull request #7705: URL: https://github.com/apache/pinot/pull/7705#discussion_r745087356 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java ## @@ -262,20 +268,28 @@ private void

[GitHub] [pinot] walterddr commented on a change in pull request #7705: follow up with picocli migration

2021-11-08 Thread GitBox
walterddr commented on a change in pull request #7705: URL: https://github.com/apache/pinot/pull/7705#discussion_r745086708 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java ## @@ -262,20 +268,28 @@ private void

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
xiangfu0 commented on a change in pull request #7722: URL: https://github.com/apache/pinot/pull/7722#discussion_r745086080 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java ## @@ -192,7 +192,11 @@ public static void main(String[] args

[GitHub] [pinot] kkrugler commented on issue #7716: [Refactor] Avoid Scala in pinot-kafka-xxx project

2021-11-08 Thread GitBox
kkrugler commented on issue #7716: URL: https://github.com/apache/pinot/issues/7716#issuecomment-963556599 I think the `StreamDataServerStartable` implementations are only needed for tests and quickstart (aka demo), so part of this cleanup could be to move that interface out of `pinot-spi`

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7721: Fix SDF pattern in DataPreprocessingHelper

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7721: URL: https://github.com/apache/pinot/pull/7721#issuecomment-963511124 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] apucher commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
apucher commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745060458 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public interfac

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
Jackie-Jiang commented on a change in pull request #7722: URL: https://github.com/apache/pinot/pull/7722#discussion_r745057862 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java ## @@ -192,7 +192,11 @@ public static void main(String[]

[GitHub] [pinot] jasperjiaguo commented on a change in pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls chan

2021-11-08 Thread GitBox
jasperjiaguo commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745054917 ## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public int

[GitHub] [pinot] walterddr commented on a change in pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
walterddr commented on a change in pull request #7722: URL: https://github.com/apache/pinot/pull/7722#discussion_r745054684 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java ## @@ -192,7 +192,11 @@ public static void main(String[] arg

[GitHub] [pinot] jasperjiaguo edited a comment on pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
jasperjiaguo edited a comment on pull request #7653: URL: https://github.com/apache/pinot/pull/7653#issuecomment-963519248 > Its not clear why we are changing the package name for AllowAllAccessFactory Hello @kishoreg, we moved the access control classes from pinot-server to pinot-c

[GitHub] [pinot] walterddr commented on a change in pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
walterddr commented on a change in pull request #7722: URL: https://github.com/apache/pinot/pull/7722#discussion_r745053508 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java ## @@ -192,7 +192,11 @@ public static void main(String[] arg

[GitHub] [pinot] xiangfu0 opened a new pull request #7722: Skip pinot.admin.system.exit check for quickstart

2021-11-08 Thread GitBox
xiangfu0 opened a new pull request #7722: URL: https://github.com/apache/pinot/pull/7722 ## Description QuickStart commands starting using `bin/pinot-admin.sh QuickStart -type XXX` will exit once the table is bootstrapped. This is extremely annoying when running pinot from docker.

[GitHub] [pinot] jasperjiaguo commented on pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls channel

2021-11-08 Thread GitBox
jasperjiaguo commented on pull request #7653: URL: https://github.com/apache/pinot/pull/7653#issuecomment-963519248 > Its not clear why we are changing the package name for AllowAllAccessFactory Hello Kishore, we moved the access control classes from pinot-server to pinot-core since

[pinot] branch master updated (827c1ce -> 7a24845)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 827c1ce lighter weight LiteralTransformFunction, avoid excessive array fills (#7707) add 7a24845 inline binary

[GitHub] [pinot] Jackie-Jiang merged pull request #7709: inline binary comparison ops to prevent function call overhead

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7709: URL: https://github.com/apache/pinot/pull/7709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter commented on pull request #7721: Fix SDF pattern in DataPreprocessingHelper

2021-11-08 Thread GitBox
codecov-commenter commented on pull request #7721: URL: https://github.com/apache/pinot/pull/7721#issuecomment-963511124 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls chan

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7653: URL: https://github.com/apache/pinot/pull/7653#issuecomment-953400988 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7653?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7653: Adding config for keystore types, switching tls to native implementation, and adding authorization for server-broker tls chan

2021-11-08 Thread GitBox
codecov-commenter edited a comment on pull request #7653: URL: https://github.com/apache/pinot/pull/7653#issuecomment-953400988 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7653?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[pinot] branch master updated (f6d7a51 -> 827c1ce)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from f6d7a51 optimise getUnpaddedString with SWAR padding search (#7708) add 827c1ce lighter weight LiteralTransform

[GitHub] [pinot] Jackie-Jiang merged pull request #7707: lighter weight LiteralTransformFunction, avoid excessive array fills

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7707: URL: https://github.com/apache/pinot/pull/7707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] xiangfu0 commented on a change in pull request #7705: follow up with picocli migration

2021-11-08 Thread GitBox
xiangfu0 commented on a change in pull request #7705: URL: https://github.com/apache/pinot/pull/7705#discussion_r745026799 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java ## @@ -262,20 +268,28 @@ private void

[GitHub] [pinot] Jackie-Jiang merged pull request #7708: optimise getUnpaddedString with SWAR padding search

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7708: URL: https://github.com/apache/pinot/pull/7708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch master updated (3b0cce4 -> f6d7a51)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 3b0cce4 allow to carry headers with query requests (#7712) add f6d7a51 optimise getUnpaddedString with SWAR pad

[GitHub] [pinot] richardstartin commented on a change in pull request #7721: Fix SDF pattern in DataPreprocessingHelper

2021-11-08 Thread GitBox
richardstartin commented on a change in pull request #7721: URL: https://github.com/apache/pinot/pull/7721#discussion_r745020242 ## File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/preprocess/DataPreprocessingHelper.ja

[pinot] branch master updated (91d2a95 -> 3b0cce4)

2021-11-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 91d2a95 Clean up controller-table related metrics in ControllerPeriodicTask (#7557) add 3b0cce4 allow to carry

[GitHub] [pinot] Jackie-Jiang merged pull request #7712: allow to carry headers with query requests

2021-11-08 Thread GitBox
Jackie-Jiang merged pull request #7712: URL: https://github.com/apache/pinot/pull/7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] jackjlli opened a new pull request #7721: Fix SDF pattern in DataPreprocessingHelper

2021-11-08 Thread GitBox
jackjlli opened a new pull request #7721: URL: https://github.com/apache/pinot/pull/7721 ## Description The SDF pattern can be null if the time column isn't simple date format (e.g. it can be timestamp), and this will make the set() method with the following exception: ``` Caused

  1   2   >