apucher commented on a change in pull request #7653: URL: https://github.com/apache/pinot/pull/7653#discussion_r745060458
########## File path: pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java ########## @@ -27,6 +28,13 @@ @InterfaceStability.Stable public interface AccessControl { + /** + * + * @param channelHandlerContext netty tls context + * @return Whether the client has access to query server + */ + boolean hasQueryServerAccess(ChannelHandlerContext channelHandlerContext); + Review comment: optimally, this would happen on establishing the channel. even per request the impact of a token check should be minimal. if it's too slow despite optimization, it could still be disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org