jasperjiaguo commented on pull request #7653: URL: https://github.com/apache/pinot/pull/7653#issuecomment-963705986
> Thank you for the updates. > > Would you mind still adding the unit test for a different keystore type? It doesn't just serve robustness but similarly as documentation for future developers. The test for the keystore type is done. I renamed the original tlstest.jks to tlstes.p12 as it is internally a P12 keystore. I think now JAVA uses PKCS12 instead of JKS for default keystore type. Generated a new JKS keystore for robustness test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
