siddharthteotia commented on a change in pull request #7653:
URL: https://github.com/apache/pinot/pull/7653#discussion_r745198982



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/server/access/AccessControl.java
##########
@@ -27,6 +28,13 @@
 @InterfaceStability.Stable
 public interface AccessControl {
 
+  /**
+   *
+   * @param channelHandlerContext netty tls context
+   * @return Whether the client has access to query server
+   */
+  boolean hasQueryServerAccess(ChannelHandlerContext channelHandlerContext);
+

Review comment:
       I meant can "token based authZ" be done as a follow-up. We need broker 
-> server authZ. Is the ask here one of the following ?
   
   - Do token based authZ instead of cert based. 
   - Continue with "cert based authZ" like done in this PR but also do it for 
presto -> server communication.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to