walterddr commented on a change in pull request #7705:
URL: https://github.com/apache/pinot/pull/7705#discussion_r745087356
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java
##########
@@ -262,20 +268,28 @@ private void updateMetadata(File segmentDir, String[]
columns, String tableName)
properties.save();
}
+ @Override
Review comment:
but this actually is a good catch. we no longer need to first parse
argument call converter.convert(). I can simply do this in execute(). let me
make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
