walterddr commented on a change in pull request #7705:
URL: https://github.com/apache/pinot/pull/7705#discussion_r745086708
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java
##########
@@ -262,20 +268,28 @@ private void updateMetadata(File segmentDir, String[]
columns, String tableName)
properties.save();
}
+ @Override
Review comment:
b/c picocli requires Command to implement callable (that is defined in
`org.apache.pinot.tools.Command` interface.
Technically speaking we no longer need the `org.apache.pinot.tools.Command`
interface because picocli provide the exact same thing. I will add a TODO to
the follow up task to clean this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
