[GitHub] [pinot] walterddr commented on a change in pull request #7722: Skip pinot.admin.system.exit check for quickstart

[GitBox]

walterddr commented on a change in pull request #7722:
URL: https://github.com/apache/pinot/pull/7722#discussion_r745054684



##########
File path: 
pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java
##########
@@ -192,7 +192,11 @@ public static void main(String[] args) {
     PluginManager.get().init();
     PinotAdministrator pinotAdministrator = new PinotAdministrator();
     pinotAdministrator.execute(args);
-    if (System.getProperties().getProperty("pinot.admin.system.exit", 
"false").equalsIgnoreCase("true")) {
+    // Ignore `pinot.admin.system.exit` property for Pinot quickstarts.
+    if ((args.length > 0) && ("quickstart".equalsIgnoreCase(args[0]))) {
+      System.clearProperty("pinot.admin.system.exit");
+    }
+    if 
(Boolean.parseBoolean(System.getProperties().getProperty("pinot.admin.system.exit")))
 {
       // If status is true, cmd was successfully, so return 0 from process.
       System.exit(pinotAdministrator._status);

Review comment:
       or we can add a _status setter in 
https://github.com/apache/pinot/pull/7722/files#diff-d9ba9e4c3102ed68cca30a3c3d7ab7c34e13a342ae9fc59685006b22f3c6322eL163
   ```
         } else {
           int status = commandLine.execute(args);
           if (!parseResult.getSubcommand.equalsIgnoreCase("quickstart")) {
             _status = status;
           }
         }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org