kishoreg commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472656203
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##
@@ -96,6 +96,18 @@ public ResultSetGroup
Jackie-Jiang opened a new pull request #5898:
URL: https://github.com/apache/incubator-pinot/pull/5898
## Description
Currently we cannot replace `BrokerRequest` with `PinotQuery` completely
because of the filter optimizer only works on `BrokerRequest`. One of the
optimizations is to me
Jackie-Jiang commented on pull request #5872:
URL: https://github.com/apache/incubator-pinot/pull/5872#issuecomment-675798956
@mayankshriv Currently the `DistinctCount` is not having the expected
behavior of returning the exact distinct count because it is storing the
`hashCode()` of the v
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch hotfix-minmax
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/hotfix-minmax by this push:
new adf50fe Retire travis from
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch release-0.5.0-rc
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/release-0.5.0-rc by this push:
new cf48649 Clarific
mayankshriv commented on pull request #5872:
URL: https://github.com/apache/incubator-pinot/pull/5872#issuecomment-675781224
> @mayankshriv Can you please check the existing use cases on
`distinctCount`? If the column is not STRING type, then the overhead should be
minimal.
> For the ex
buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472558991
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##
@@ -96,6 +96,18 @@ public ResultSetGrou
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_ingestion_job_with_output_uri
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 4874e7a Fixing segment push uri ingestion jobs
add 83316a5 Fixing segm
fx19880617 commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-pinot/pull/5897#discussion_r472558051
##
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
##
@@ -287,7 +287,7
fx19880617 commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-pinot/pull/5897#discussion_r472557849
##
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
##
@@ -411,6 +412,7 @@
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a change to branch release-0.5.0-rc
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at d1b4586 New endpoint to get routing table for sql query (#5791)
No new revisions were added by
Jackie-Jiang commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-pinot/pull/5897#discussion_r472553793
##
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/test/java/org/apache/pinot/plugin/ingestion/batch/common/TestSegm
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_ingestion_job_with_output_uri
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard adeec12 Fixing segment push uri ingestion jobs
add 4874e7a Fixing segm
fx19880617 opened a new pull request #5897:
URL: https://github.com/apache/incubator-pinot/pull/5897
## Description
Fixing SegmentUriPush job by providing full segment uri for downloadUrl.
This is an automated message from
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_ingestion_job_with_output_uri
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at adeec12 Fixing segment push uri ingestion jobs
This branch includes the fol
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch fixing_ingestion_job_with_output_uri
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit adeec12892809e4db59b2457d563b282abaefd0a
Author: Xiang Fu
AuthorDate: Tue Aug 18
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a change to branch exact-distinct-count
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e5fd3a0 Removing code from another PR
add 8f2dff4 addressing review comments
No new
Jackie-Jiang commented on a change in pull request #5889:
URL: https://github.com/apache/incubator-pinot/pull/5889#discussion_r472512962
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##
@@ -208,50 +232,42 @@ private Data
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 89cd958 Support post-aggregation in SE
Jackie-Jiang merged pull request #5867:
URL: https://github.com/apache/incubator-pinot/pull/5867
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e9ad1e0 Update swagger ui path (#5896)
Jackie-Jiang merged pull request #5896:
URL: https://github.com/apache/incubator-pinot/pull/5896
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
kishoreg commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472508463
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##
@@ -96,6 +96,18 @@ public ResultSetGroup
vincentchenjl commented on a change in pull request #5866:
URL: https://github.com/apache/incubator-pinot/pull/5866#discussion_r472489939
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java
##
@@ -345,18 +32
buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472505626
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##
@@ -24,11 +24,12 @@
/**
* Reimpl
buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472498903
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##
@@ -38,6 +39,126 @@ private BrokerR
jackjlli closed pull request #5895:
URL: https://github.com/apache/incubator-pinot/pull/5895
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jackjlli commented on pull request #5895:
URL: https://github.com/apache/incubator-pinot/pull/5895#issuecomment-675711593
Closing this PR since we have a fix PR for that:
https://github.com/apache/incubator-pinot/pull/5896
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch hotfix-minmax
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/hotfix-minmax by this push:
new 0a65ba9 Fix race condition
jackjlli opened a new pull request #5896:
URL: https://github.com/apache/incubator-pinot/pull/5896
## Description
This PR updates swagger ui version and its related paths.
vulnerability: Swagger-ui before 3.18.0 is vulnerable to Reverse Tabnabbing.
Setting target="_blank" on ancho
KKcorps commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472475194
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##
@@ -24,11 +24,12 @@
/**
* Reimpleme
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch bump-up-swagger-ui-version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit fab418715d3f5b411aea2619d346f0f4a51d03fc
Author: Jack Li(Analytics Engineering)
AuthorDate: T
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch bump-up-swagger-ui-version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 1842c7e Update swagger ui path
omit dc62e69 Bump up swagger ui version to 3.18.2
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch bump-up-swagger-ui-version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 1842c7e Update swagger ui path
This branch includes the following new commits:
new
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch bump-up-swagger-ui-version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 1842c7e5a50b595dd522b0e466beb733b4a8a8fa
Author: Jack Li(Analytics Engineering)
AuthorDate: T
KKcorps commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472470875
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##
@@ -96,6 +96,18 @@ public ResultSetGroup e
jihaozh merged pull request #5869:
URL: https://github.com/apache/incubator-pinot/pull/5869
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from a7f7f46 Fix gcsFS copyToLocal to precreate local destination
directory (#5890)
add 7a30a80 Roundup de
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 41dc432 Bump up swagger ui version to 3.18.2 (#5888)
add a7f7f46 Fix gcsFS copyToLocal to precreate
fx19880617 merged pull request #5890:
URL: https://github.com/apache/incubator-pinot/pull/5890
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
fx19880617 commented on pull request #5890:
URL: https://github.com/apache/incubator-pinot/pull/5890#issuecomment-675684093
Thanks for fixing this!
This is an automated message from the Apache Git Service.
To respond to the m
buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472445375
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PreparedStatement.java
##
@@ -72,6 +72,15 @@ public Result
buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472445325
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##
@@ -96,6 +96,18 @@ public ResultSetGrou
buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472445075
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##
@@ -24,11 +24,12 @@
/**
* Reimpl
jackjlli commented on pull request #5888:
URL: https://github.com/apache/incubator-pinot/pull/5888#issuecomment-675674744
Let me roll back this PR and will take a look at this
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch revert-5888-bump-up-swagger-ui-version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 3570cf0 Revert "Bump up swagger ui version to 3.18.2 (#5888)"
No new revisio
jackjlli opened a new pull request #5895:
URL: https://github.com/apache/incubator-pinot/pull/5895
Reverts apache/incubator-pinot#5888
This is an automated message from the Apache Git Service.
To respond to the message, pleas
KKcorps commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472427252
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PreparedStatement.java
##
@@ -72,6 +72,15 @@ public ResultSet
KKcorps commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472423197
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##
@@ -38,6 +39,126 @@ private BrokerResp
KKcorps commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472423197
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##
@@ -38,6 +39,126 @@ private BrokerResp
Jackie-Jiang commented on pull request #5888:
URL: https://github.com/apache/incubator-pinot/pull/5888#issuecomment-675664230
Here is the stacktrace of the exception
```
Failed to start a [ CONTROLLER ] Service
java.lang.NullPointerException: null
at java.util.ArrayDeque.add
Jackie-Jiang commented on pull request #5888:
URL: https://github.com/apache/incubator-pinot/pull/5888#issuecomment-675663209
@jackjlli @mcvsubbu This change breaks quick-start tests on JDK 11-14. Can
you please revert it and fix it accordingly? Let's make sure all the tests
passed before
jasonyanwenl opened a new pull request #5894:
URL: https://github.com/apache/incubator-pinot/pull/5894
Phase 2 is separated into two parts. This PR is for the 2nd part. **Please
note that this PR has a dependency. PR #5866 should be merged before this PR
get merged.** The PR for `Phase 2
Jackie-Jiang commented on a change in pull request #5867:
URL: https://github.com/apache/incubator-pinot/pull/5867#discussion_r472409505
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##
@@ -160,103 +160,49 @@ public void
Jackie-Jiang commented on a change in pull request #5867:
URL: https://github.com/apache/incubator-pinot/pull/5867#discussion_r472403183
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##
@@ -231,6 +231,
Jackie-Jiang commented on issue #5893:
URL:
https://github.com/apache/incubator-pinot/issues/5893#issuecomment-675644651
@mr-agrwal It might not be efficient to support star-tree on
`SegmentPartitionedDistinctCount` because:
- In order to generate star-tree, we need to generate the inte
laxmanchekka commented on a change in pull request #5890:
URL: https://github.com/apache/incubator-pinot/pull/5890#discussion_r472395046
##
File path:
pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java
##
@@ -325,6 +326,7
KKcorps closed pull request #5891:
URL: https://github.com/apache/incubator-pinot/pull/5891
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
npawar commented on a change in pull request #5867:
URL: https://github.com/apache/incubator-pinot/pull/5867#discussion_r472381824
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##
@@ -160,103 +160,49 @@ public void reduc
kishoreg commented on pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#issuecomment-675620062
@npawar @KKcorps can you please review this PR and make sure if handles both
pql and sql path and jdbc
---
lgo commented on issue #5877:
URL:
https://github.com/apache/incubator-pinot/issues/5877#issuecomment-675619506
Saw your earlier comment re `segmentUriPrefix`. I just got it to work with
the configuration:
```
segmentUriPrefix: 's3://mybucket'
```
But your PR for removing t
kishoreg commented on a change in pull request #5890:
URL: https://github.com/apache/incubator-pinot/pull/5890#discussion_r472362632
##
File path:
pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java
##
@@ -325,6 +326,7 @@
mr-agrwal opened a new issue #5893:
URL: https://github.com/apache/incubator-pinot/issues/5893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472352313
##
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PreparedStatement.java
##
@@ -72,6 +72,15 @@ public Result
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 87b5b77 Fix race condition in MetricsHelper (#5887)
add 41dc432 Bump up swagger ui version to 3.18.2 (#
jackjlli merged pull request #5888:
URL: https://github.com/apache/incubator-pinot/pull/5888
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
buchireddy opened a new pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892
## Description
This would let the client application to observe and print response stats
selectively
for queries and avoid reproducing slow queries.
Changes for the feature in
http
KKcorps opened a new pull request #5891:
URL: https://github.com/apache/incubator-pinot/pull/5891
This PR fixes the issue #5877
S3 filesystem returns full paths along with `s3://` in listFiles which
causes problems while uploading segments
The PR also includes another single
cyrilou242 edited a comment on pull request #5868:
URL: https://github.com/apache/incubator-pinot/pull/5868#issuecomment-675540235
Sadly BigQuery does not have a mock server.
It's possible to test on some public, free (up to 1Tb) databases.
### Requirements:
Having a GCP project
cyrilou242 commented on pull request #5868:
URL: https://github.com/apache/incubator-pinot/pull/5868#issuecomment-675540235
Sadly BigQuery does not have a mock server.
It's possible to test on some public, free (up to 1Tb) databases.
### Requirements:
Having a GCP project (named
KKcorps removed a comment on issue #5877:
URL:
https://github.com/apache/incubator-pinot/issues/5877#issuecomment-675436400
Hi @lgo, Can you set `segmentUriPrefix` to `s3:/` and try. That seems to
work on my end.
This is an
KKcorps commented on issue #5877:
URL:
https://github.com/apache/incubator-pinot/issues/5877#issuecomment-675436400
Hi @lgo, Can you set `segmentUriPrefix` to `s3:/` and try. That seems to
work on my end.
This is an automat
mr-agrwal closed issue #5829:
URL: https://github.com/apache/incubator-pinot/issues/5829
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
mr-agrwal commented on issue #5829:
URL:
https://github.com/apache/incubator-pinot/issues/5829#issuecomment-675407962
@kishoreg Closing this, as this is an issue with javascript parsing long
values. This is further discussed in detail in
https://www.techempower.com/blog/2016/07/05/manglin
laxmanchekka opened a new pull request #5890:
URL: https://github.com/apache/incubator-pinot/pull/5890
## Description
Fix the error while downloading segment from GCS via controller.
https://github.com/apache/incubator-pinot/issues/5884
## Upgrade Notes
Does this PR prevent a
cyrilou242 commented on a change in pull request #5868:
URL: https://github.com/apache/incubator-pinot/pull/5868#discussion_r472005476
##
File path: thirdeye/pom.xml
##
@@ -545,6 +545,54 @@
+
+
+ bigquery
+
+1.9.0
+
0.13.0
+1
76 matches
Mail list logo
