KKcorps commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472475194



##########
File path: 
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##########
@@ -24,11 +24,12 @@
 /**
  * Reimplementation of BrokerResponse from pinot-common, so that pinot-api 
does not depend on pinot-common.
  */
-class BrokerResponse {
+public class BrokerResponse {

Review comment:
       I think thee intention was to expose a standard ResultSet Interface from 
which the user can easily read the data.
   Broker Response can have different fields depending upon whether SQL or PQL 
endpoint was queried. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to