fx19880617 commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-pinot/pull/5897#discussion_r472558051
##########
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
##########
@@ -287,7 +287,7 @@ public void testCopyFromAndToLocal()
Assert.assertEquals(headObjectResponse.contentLength(), (Long)
fileToCopy.length());
- File fileToDownload = new File("copyFile_download.txt");
+ File fileToDownload = new File("copyFile_download.txt").getAbsoluteFile();
Review comment:
because relative File.getParent will return null, which is not goingg to
happen in the prod environment
##########
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
##########
@@ -287,7 +287,7 @@ public void testCopyFromAndToLocal()
Assert.assertEquals(headObjectResponse.contentLength(), (Long)
fileToCopy.length());
- File fileToDownload = new File("copyFile_download.txt");
+ File fileToDownload = new File("copyFile_download.txt").getAbsoluteFile();
Review comment:
because relative File.getParent will return null, which is not going to
happen in the prod environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
