buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472445075
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##########
@@ -24,11 +24,12 @@
/**
* Reimplementation of BrokerResponse from pinot-common, so that pinot-api
does not depend on pinot-common.
*/
-class BrokerResponse {
+public class BrokerResponse {
Review comment:
@KKcorps @npawar I would call this as a major change in the public API
for java client. BrokerResponse was package protected but now this PR makes the
class public. Do you know why the BrokerResponse was not public?
My understanding is the client was exposing the results, much like the
relational databases so that the client application doesn't need to understand
the internals of Pinot response but this requirement kind of beats that. The
intention here is "I understand response stats and let me access them".
Thoughts, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
