This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch release-0.5.0-rc
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/release-0.5.0-rc by this push:
new cf48649 Clarifications in realtime provisioning helper (#5838)
cf48649 is described below
commit cf48649f358732fe2e183da66938cfe88cce93a2
Author: Subbu Subramaniam <mcvsu...@users.noreply.github.com>
AuthorDate: Mon Aug 10 14:43:37 2020 -0700
Clarifications in realtime provisioning helper (#5838)
Updated the output based on recent feedback from Pinot SREs at LinkedIn
---
.../tools/admin/command/RealtimeProvisioningHelperCommand.java | 7 ++++---
.../apache/pinot/tools/realtime/provisioning/MemoryEstimator.java | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
index 7c145b1..b7c5deb 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
@@ -130,7 +130,7 @@ public class RealtimeProvisioningHelperCommand extends
AbstractBaseAdminCommand
@Override
public String toString() {
- return ("RealtimeProvisioningHelperCommand -tableConfigFile " +
_tableConfigFile + " -numPartitions "
+ return ("RealtimeProvisioningHelper -tableConfigFile " + _tableConfigFile
+ " -numPartitions "
+ _numPartitions + " -pushFrequency " + _pushFrequency + " -numHosts "
+ _numHosts + " -numHours " + _numHours
+ " -sampleCompletedSegmentDir " + _sampleCompletedSegmentDir + "
-ingestionRate "
+ _ingestionRate + " -maxUsableHostMemory " + _maxUsableHostMemory + "
-retentionHours " + _retentionHours);
@@ -163,6 +163,7 @@ public class RealtimeProvisioningHelperCommand extends
AbstractBaseAdminCommand
.append("\nHowever, if most of your queries are going to be for (say)
the last 96 hours, then you can specify that in -retentionHours")
.append("\nDoing so will let this program assume that you are willing
to take a page hit when querying older data")
.append("\nand optimize memory and number of hosts accordingly.")
+ .append("\n See
https://docs.pinot.apache.org/operators/operating-pinot/tuning/realtime for
details");
;
System.out.println(builder.toString());
}
@@ -235,11 +236,11 @@ public class RealtimeProvisioningHelperCommand extends
AbstractBaseAdminCommand
displayResults(memoryEstimator.getOptimalSegmentSize(), numHosts,
numHours);
LOGGER.info("\nConsuming memory");
displayResults(memoryEstimator.getConsumingMemoryPerHost(), numHosts,
numHours);
- LOGGER.info("\nNumber of segments queried per host");
+ LOGGER.info("\nTotal number of segments queried per host (for all
partitions)");
displayResults(memoryEstimator.getNumSegmentsQueriedPerHost(), numHosts,
numHours);
return true;
}
-
+
private void displayOutputHeader(StringBuilder note) {
System.out.println("\n============================================================\n"
+ toString());
System.out.println(note.toString());
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/realtime/provisioning/MemoryEstimator.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/realtime/provisioning/MemoryEstimator.java
index 1117b36..874d4c2 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/realtime/provisioning/MemoryEstimator.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/realtime/provisioning/MemoryEstimator.java
@@ -247,7 +247,7 @@ public class MemoryEstimator {
+ "/" + DataSizeUtils.fromBytes(mappedMemoryPerHost);
_consumingMemoryPerHost[i][j] =
DataSizeUtils.fromBytes(totalMemoryForConsumingSegmentsPerHost);
_optimalSegmentSize[i][j] =
DataSizeUtils.fromBytes(completedSegmentSizeBytes);
- _numSegmentsQueriedPerHost[i][j] =
String.valueOf(numActiveSegmentsPerPartition);
+ _numSegmentsQueriedPerHost[i][j] =
String.valueOf(numActiveSegmentsPerPartition * totalConsumingPartitionsPerHost);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
