buchireddy commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472505626
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##########
@@ -24,11 +24,12 @@
/**
* Reimplementation of BrokerResponse from pinot-common, so that pinot-api
does not depend on pinot-common.
*/
-class BrokerResponse {
+public class BrokerResponse {
Review comment:
IMO, ResultSet makes sense for JDBC client but for the Java client, the
entire BrokerResponse makes more sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
