KKcorps commented on a change in pull request #5892:
URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472427252
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PreparedStatement.java
##########
@@ -72,6 +72,15 @@ public ResultSetGroup execute() {
return _connection.execute(new Request(_queryFormat,
fillStatementWithParameters()));
}
+ /**
+ * Executes this prepared statement and returns the BrokerResponse.
+ *
+ * @return The BrokerResponse received.
+ */
+ public BrokerResponse executeRequest() {
Review comment:
Don't rename any methods. Since it won't be backward compatible then.
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
##########
@@ -96,6 +96,18 @@ public ResultSetGroup execute(Request request)
return execute(null, request);
}
+ /**
+ * Executes a Pinot Request and returns the Response.
+ *
+ * @param request The request to execute
+ * @return The BrokerResponse for the request.
+ * @throws PinotClientException If an exception occurs while processing the
query
+ */
+ public BrokerResponse executeRequest(Request request)
Review comment:
Don't rename the methods as it would not be backward compatible and will
break other connectors such as JDBC.
##########
File path:
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
##########
@@ -38,6 +39,126 @@ private BrokerResponse(JsonNode brokerResponse) {
_exceptions = brokerResponse.get("exceptions");
_selectionResults = brokerResponse.get("selectionResults");
_resultTable = brokerResponse.get("resultTable");
+ _responseStats = ResponseStats.fromJson(brokerResponse);
+ }
+
+ public static class ResponseStats {
Review comment:
This class should be moved to a separate file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
