[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

Endill added a comment. @yronglin We are sorry it takes so much time to get feedback. Richard and Hubert have little bandwidth for reviews. Others, including me, don't feel qualified to provide good feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121723 Files: clan

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill updated this revision to Diff 415524. Endill added a comment. Fix warning about clang-format being missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723/new/ https://reviews.llvm.org/D121723 Files: clang/include/clang/Basic/Diagnos

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill updated this revision to Diff 415529. Endill added a comment. Add a quote from CWG 2354 after a quote from C++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723/new/ https://reviews.llvm.org/D121723 Files: clang/include/clang/Basic/D

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4291 // declared with the register storage class specifier. An // alignment-specifier may also be applied to the declaration of a class // or enumeration type. erichkea

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added a comment. Can somebody commit this? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723/new/ https://reviews.llvm.org/D121723 ___ cfe-commits mailing list cfe-c

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added a comment. In D121723#3384982 , @ChuanqiXu wrote: > In D121723#3384962 , @Endill wrote: > >> Can somebody commit this? I don't have commit access. > > Hi, what's your prefered name and email addressed

[PATCH] D142381: [clang] Add test for CWG1960

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG839eae38a4e4: [clang] Add test for CWG1960 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D142315: [clang] Add test for CWG1111

Endill updated this revision to Diff 492395. Endill added a comment. Change status from "6" to "yes" since "ambiguous-member-template" warning is a false-positive now. - Disable "ambiguous-member-template" diagnostic in 98 and 03 modes - Add an example (`struct A`) - Apply clang-format Reposit

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:1 -// RUN: %clang_cc1 -std=c++98 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors +// RUN: %clang_cc1 -std=c++98 %s -verify=expected,cxx98 -fexceptions -fcxx-exceptions -pedantic-errors // RUN: %c

[PATCH] D142315: [clang] Add test for CWG1111

Endill updated this revision to Diff 492430. Endill edited the summary of this revision. Endill added a comment. Move CWG2385 ("na") from D142316 into this patch. It makes more sense to put it here, because it fixes inconsistent wording introduced by CWG re

[PATCH] D142316: [clang] Add test for CWG2396

Endill updated this revision to Diff 492433. Endill edited the summary of this revision. Endill added a comment. Move CWG2385 out to D142315 , because it's been resolved prior to P1787 , and it's easier to explain it there. Repo

[PATCH] D142316: [clang] Add test for CWG2396

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } shafik wrote: >

[PATCH] D142717: [clang] Mark CWG2165 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG2165 is resolved by removing the conflicting

[PATCH] D142315: [clang] Add test for CWG1111

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142315 Files:

[PATCH] D142316: [clang] Add test for CWG2396

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also mark CWG1291 and CWG2385 as "na". P1787 : CW

[PATCH] D139326: [clang] Add test for CWG952

Endill added inline comments. Comment at: clang/test/CXX/drs/dr9xx.cpp:76 +namespace dr952 { // dr952: yes +struct A { + typedef int I; // #dr952-typedef-decl aaron.ballman wrote: > I wouldn't mind another test case: > ``` > struct A { > protected: > static in

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 shafik wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Were you able to track down which pat

[PATCH] D142315: [clang] Add test for CWG1111

Endill added a comment. In D142315#4073782 , @erichkeane wrote: > I didn't internalize that it was 'just a warning' (it was a -error in the > test above), we should have a task for someone to remove that warning as it > is no longer ambiguous. But I d

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:31 + } +} + erichkeane wrote: > Can you also add the last example (with struct A) from the issue, and find a > way to confirm that it is calling the right version? Nice catch, thank you. Lo

[PATCH] D142381: [clang] Add test for CWG1960

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG1960 (currently closed as NAD) is res

[PATCH] D142377: Dead links on https://clang.llvm.org/extra/clang-tidy/ #60023

Endill added a comment. LGTM I checked clang-tidy docs for this kind of broken references, but found nothing else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142377/new/ https://reviews.llvm.org/D142377

[PATCH] D142316: [clang] Add test for CWG2396

Endill added a comment. In D142316#4073771 , @shafik wrote: > You mention CWG2385 as na but you don't explain > how it was resolved, was it superceded by p1787 >

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

Endill added inline comments. Comment at: clang/docs/ReleaseNotes.rst:94-98 +- Implemented `P0847R7: Deducing this `. Some related core issues were also + implemented (`CWG2553 `, `CWG2554 `, + `

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. Thank you for working on this! Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:3 // RUN:-Wunsequenced -Wno-c++17-extensions -Wno-c++14-extensions %s -// RUN: %clang_cc1 -fsyntax-only -verify=cxx17 -std=c++17 -Wno-unused -Wno-uninitializ

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. I'm sorry for hand-waving, but I also remember @aaron.ballman saying that code related to `-Wunsequenced` or around it was missing checks for C++17. I can't say whether you addressed that or not, so just leaving it here for you and reviewers. CHANGES SINCE LAST ACTION

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. In D156057#4527787 , @rZhBoYao wrote: > BTW, I am not sure if CWG2571 is implemented by > @cor3ntin? If so, can we mark it as done on > https://clang.llvm.org/cxx_dr_status.html#2571? This patch handles

[PATCH] D156565: Diagnose use of VLAs in C++ by default

Endill added a comment. In D156565#4547909 , @aaron.ballman wrote: > In D156565#4543503 , @aaron.ballman > wrote: > >> In D156565#4543414 , @jrtc27 wrote: >> >>> Given G

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

Endill added inline comments. Comment at: clang/test/SemaCXX/offsetof.cpp:106 +int x3[__builtin_offsetof(struct X2, X2::static_a) == 0 ? 1 : -1]; // expected-error{{no member named 'static_a'}} +int x4[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Endill added a comment. In D156247#4541756 , @ilya-biryukov wrote: > @aaron.ballman the internal -cc1 flag > > - internal `clang -cc1 -fno-coroutines`. I'm sorry, but I find this wording misleading. `-cc1 -fno-coroutines` is not internal in the same se

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

Endill added a comment. @tahonermann Do you mind rebasing this on top of trunk if it's necessary? Might be a good idea to resubmit this as PR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64087/new/ https://reviews.llvm.org/D64087 __

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill accepted this revision as: Endill. Endill added a comment. DR testing side looks good, but you should wait for more approvals. Thank you for addressing all the issues there! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632 __

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

Endill added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:491 + float operator ""_E(const char *); + // expected-warning@+1 {{user-defined literal suffixes not starting with '_' are reserved; no literal will invoke this operator}} + float operator ""E(const char

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bbaabb90dd7: [clang] Add test for CWG1710 and related issues (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151697/new/ https://review

[PATCH] D138822: [clang] Add test for CWG36

Endill created this revision. Endill added a project: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138822 Files: c

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Sure, I'll update core issue list in a separate diff. I don't have commit rights, but I have a commit merged (just one). Does it make me eligible for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://r

[PATCH] D138835: [clang] Update DR status to Revision 110

Endill added a comment. Here it is: Vlad Serebrennikov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138835/new/ https://reviews.llvm.org/D138835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138835: [clang] Update DR status to Revision 110

Endill added a comment. Thank you for prompt review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138835/new/ https://reviews.llvm.org/D138835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478300. Endill added a comment. Incorporate D138835 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/www/cxx_dr_status.html clang/www/make_cxx_dr_status I

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Sorry, I messed up diff update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478303. Endill added a comment. Incorporate D138835 (correctly this time around) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/test/CXX/drs/dr0xx.cpp c

[PATCH] D138895: [clang] Update CWG2635 status

Endill created this revision. Endill added reviewers: clang-language-wg, erichkeane. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to D138852 . Apparently

[PATCH] D138895: [clang] Update CWG2635 status

Endill added a comment. Sorry, some other WIP got in there. I'll remove it in a moment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138895/new/ https://reviews.llvm.org/D138895 ___ cfe-commits mailing l

[PATCH] D138895: [clang] Update CWG2635 status

Endill updated this revision to Diff 478457. Endill added a comment. Remove WIP for another patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138895/new/ https://reviews.llvm.org/D138895 Files: clang/test/CXX/drs/dr26xx.cpp Index: clang/test/CXX/drs/dr26xx.cpp ===

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

Endill created this revision. Endill added reviewers: erichkeane, ychen, clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow-up to D136133 . It wa

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

Endill added a comment. Can I kindly ask you to commit this? I guess I can ask for commit access after this patch, and not bother you any further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/new/ https://reviews.llvm.org/D138901

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. @aaron.ballman Following example of other DR test, I was reluctant to add relevant comments, e.g. wording. But I can provide it going forward or even update this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Among the worst parts of this paper are references to mailing list and EDG wiki, which I don't have access to. But I still managed to dig everything up, and ready to explain if requested. No tests were copied blindly from issues. CHANGES SINCE LAST ACTION https://revi

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Thank you! > FWIW, if you need help getting references from the mailing list or the wiki, > feel free to mention what you're after and one of us on the committee can see > about tracking down the details. Do you mean creating an incomplete diff and asking here in the co

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Discord feels perfect to me for this kind of questions. What's left is to get past a broken bot for agreeing with code of conduct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 ___

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} erichkeane wrote: > As a nit, I prefer

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478875. Endill added a comment. Add examples with dependent types, and rearrange using declarations to group errors and notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478878. Endill added a comment. Get rid of unwanted changes supposedly cause by `arc diff` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/test/CXX/drs/dr0xx.cpp clang/www/cxx_dr_status.htm

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} erichkeane wrote: > Endill wrote: > >

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} aaron.ballman wrote: > Endill wrote: >

[PATCH] D139090: [clang] Add test for CWG360

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG360 is resolved by applying access co

[PATCH] D139090: [clang] Add test for CWG360

Endill updated this revision to Diff 479225. Endill added a comment. run make_cxx_dr_status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139090/new/ https://reviews.llvm.org/D139090 Files: clang/test/CXX/drs/dr3xx.cpp clang/www/cxx_dr_status.html Index: clang/www/cxx_dr_status.h

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139095 Files:

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

Endill added a comment. Is it fine that we're marking CWG405 as a duplicate even though it's not mentioned as such in official publication? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139095/new/ https://reviews.llvm.org/D139095 ___

[PATCH] D139090: [clang] Add test for CWG360

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f950ad58919: [clang] Add test for CWG360 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D139090: [clang] Add test for CWG360

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; erichkeane wrote: > This bookmark isn't necessary, so no reason to have it. But thank you for > using these! Nice catch, thank you!

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

Endill added a comment. > I don't think we should mark it as a dup -- we want the status in our tests > to match the status on the official document, otherwise things get confusing. We can do it the following way then: `// dr405: yes \n // NB: also dup 218`. Do I understand correctly that supers

[PATCH] D138822: [clang] Add test for CWG36

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5993fc7757e: [clang] Add test for CWG36 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D139172: [clang] Mark CWG554 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : //CWG554 is resolved by using the word “s

[PATCH] D139173: [clang] Add test for CWG600

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : //CWG600 is resolved by explaining that a

[PATCH] D139172: [clang] Mark CWG554 as N/A

Endill added a comment. > There are many editorial issues that ended up as defect reports, you could > probably batch many of them in subsequent PR Thank you for suggestion. I'm being on a safer side at the moment, because CWG405 raised more questions than I anticipated. I'll also wait until to

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

Endill added a comment. > I think this is perfectly fine to have a duplicated test case, I agree with > Aaron, we should not invent duplicated status ourselves. > Adding a comment in the test like "Note: this test is identical to the one > for CWG405" would be a good idea Does it mean that dupl

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

Endill added a comment. >> We can do it the following way then: // dr405: yes \n // NB: also dup 218. > > That would be fine by me! Which way should we handle this? I'd prefer to do it without test duplication, but making it clear for readers is a serious concern indeed. (Read on, I elaborate o

[PATCH] D139173: [clang] Add test for CWG600

Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} shafik wrote: > Maybe add a comment above this saying something like: > > ``` > // access control is applied after

[PATCH] D139172: [clang] Mark CWG554 as N/A

Endill added a comment. > @aaron.ballman do you think it is worth it to provide a link to p1787 as > well? I know you can just goto the issue and see that but it feels helpful. I > actually missed this at first b/c I usually goto end of the issue to look for > the resolution and was confused.

[PATCH] D139173: [clang] Add test for CWG600

Endill added a subscriber: aaron.ballman. Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} Endill wrote: > shafik wrote: > > Maybe add a comment above this saying so

[PATCH] D139173: [clang] Add test for CWG600

Endill added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:18 + sp->f(2); + sp->f(2.2); // expected-error {{is a private member}} +} aaron.ballman wrote: > Endill wrote: > > Endill wrote: > > > shafik wrote: > > > > Maybe add a comment above this sa

[PATCH] D139173: [clang] Add test for CWG600

Endill updated this revision to Diff 479818. Endill added a comment. Add a comment per @shafik request CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173 Files: clang/test/CXX/drs/dr6xx.cpp clang/www/cxx_dr_status.html Index: clang/www/cxx_

[PATCH] D139172: [clang] Mark CWG554 as N/A

Endill added a comment. @shafik Would it be fine by you to proceed without changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139172/new/ https://reviews.llvm.org/D139172 ___ cfe-commits mailing list

[PATCH] D139095: [clang] Add test for CWG405

Endill updated this revision to Diff 479858. Endill retitled this revision from "[clang] Mark CWG405 as a duplicate of CWG218" to "[clang] Add test for CWG405". Endill edited the summary of this revision. Endill added a comment. Reuse a part of CWG218 test, adding cross-references. CHANGES SINC

[PATCH] D139095: [clang] Add test for CWG405

Endill added inline comments. Comment at: clang/test/CXX/drs/dr4xx.cpp:99 +void test3(A::S as) { using A::f; f(as); } // ok +void test4(A::S as) { using B::f; f(as); } // ok +void test5(A::S as) { int f; f(as); } // expected-error {{called object type 'int'}} ---

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. Thank you for review! Comment at: clang/lib/Parse/ParsePragma.cpp:15-17 #include "clang/Basic/TargetInfo.h" +#include "clang/Lex/LexDiagnostic.h" #include "clang/Lex/Preprocessor.h" aaron.ballman wrote: > I'm using `warn_pragma_debug_

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:731-736 +} else if (E.get()->isTypeDependent()) { + PP.Diag(StartLoc, diag::warn_pragma_debug_type_dependent_argument) +<< SourceRange(StartLoc, Tok.getLocation()); +} else if (E.get()-

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 507843. Endill added a comment. - Handle expressions as unevaluated operands - Numerous fixes to documentation wording - Add release notes entry - Prevent generic "unknown argument" diagnostic from being issued when other more specific diagnostics have been em

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 508086. Endill added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang

[PATCH] D144115: [clang] Extend pragma dump to support expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG467ed2798772: [clang] Extend pragma dump to support expressions (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

Endill accepted this revision. Endill added a comment. This revision is now accepted and ready to land. LGTM I got confused at first why this fix is done in a function named `getSubobjectSizeInBits`, and why do we calculate size to produce a boolean value in the end. Then I realized that this fu

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 504673. Endill added a comment. - Diagnose dependent expressions - Move AST dumping from parser to sema - Add documentation - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.l

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Endill added a comment. In D140996#4189452 , @bolshakov-a wrote: > Sorry! It's my first time using Phabricator. Maybe, the problem occurs > because I've solved the issue with Arcanist just by means of copy-pasting > patches into "Update Diff" Web GUI f

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151697/new/ https://reviews.llvm.org/D151697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D151634: [clang] Add test for CWG253

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > Endill wrote: > > shafi

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill added a comment. Thank you for taking a look! I found a bunch of issues pointing at the same diagnostics, but I'm not sure if they track exactly what I test here: https://github.com/llvm/llvm-project/issues/17775 https://github.com/llvm/llvm-project/issues/36539 https://github.com/llvm/llv

[PATCH] D147530: [clang] Add test for CWG191

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG191 and CWG1200 are resolved by defining unqu

[PATCH] D147530: [clang] Add test for CWG191

Endill updated this revision to Diff 510793. Endill edited the summary of this revision. Endill added a comment. Mark CWG1200 as "na" and enable newer standard versions in RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147530/new/ https://

[PATCH] D147549: [clang] Add test for CWG255

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG255 (partially resolved by N3778 is resolved

[PATCH] D147554: [clang] Mark CWG562 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG562 is resolved by defining lookup as occurri

[PATCH] D147564: [clang] Mark CWG536 as N/A

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG536 (long partially resolved) is resolved by

[PATCH] D147590: [clang] Add test for CWG607

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG607 is resolved by looking up unqualified nam

[PATCH] D147530: [clang] Add test for CWG191

This revision was automatically updated to reflect the committed changes. Closed by commit rG653a82e95257: [clang] Add test for CWG191 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147530/new/ https://reviews.llvm.org/D147530

[PATCH] D147549: [clang] Add test for CWG255

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e84315e7d6: [clang] Add test for CWG255 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147549/new/ https://reviews.llvm.org/D147549

[PATCH] D147554: [clang] Mark CWG562 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG154825bdf6fb: [clang] Mark CWG562 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147554/new/ https://reviews.llvm.org/D147554 F

[PATCH] D147590: [clang] Add test for CWG607

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b0386940255: [clang] Add test for CWG607 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D147836: [clang] Add test for CWG1822

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1822 is resolved by specifying that the body

[PATCH] D147839: [clang] Add test for CWG2007

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2007 is resolved by skipping unqualified look

  1   2   3   >