Endill added inline comments.

================
Comment at: clang/test/CXX/drs/dr0xx.cpp:489
+
+    using B::i; // expected-error {{redeclaration of using declaration}}
+    using C::i; // expected-error {{redeclaration of using declaration}}
----------------
erichkeane wrote:
> As a nit, I prefer the 'notes' to live next to the error, and use a bookmark 
> line-marker here.  My issue is basically how we have no way of knowing 
> (particularly in template code...) what this diagnoses.
> 
> I would also think a dependent example of this diagnostic would be useful.
>I would also think a dependent example of this diagnostic would be useful.
Do you mean something of this sort: `using D<int>::i`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138822/new/

https://reviews.llvm.org/D138822

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to