Endill added inline comments.

================
Comment at: clang/test/CXX/drs/dr11xx.cpp:1
-// RUN: %clang_cc1 -std=c++98 %s -verify -fexceptions -fcxx-exceptions 
-pedantic-errors
+// RUN: %clang_cc1 -std=c++98 %s -verify=expected,cxx98 -fexceptions 
-fcxx-exceptions -pedantic-errors
 // RUN: %clang_cc1 -std=c++11 %s -verify -fexceptions -fcxx-exceptions 
-pedantic-errors
----------------
erichkeane wrote:
> I see what happened now: Add `-Wno-error=ambiguous-member-template` to this 
> line.
Thank you for suggestion, but I'd like to avoid making changes that could 
affect other tests (now and in the future), so I went pragma way.


================
Comment at: clang/test/CXX/drs/dr11xx.cpp:31
+  }
+}
+
----------------
Endill wrote:
> erichkeane wrote:
> > Can you also add the last example (with struct A) from the issue, and find 
> > a way to confirm that it is calling the right version?
> Nice catch, thank you. Long exposure to P1787 makes one pay less attention to 
> resolutions in CWG issues, it seems :)
Done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142315/new/

https://reviews.llvm.org/D142315

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to