Endill added a comment.

In D156247#4541756 <https://reviews.llvm.org/D156247#4541756>, @ilya-biryukov 
wrote:

> @aaron.ballman the internal -cc1 flag
>
> - internal `clang -cc1 -fno-coroutines`.

I'm sorry, but I find this wording misleading. `-cc1 -fno-coroutines` is not 
internal in the same sense as e.g. `-verify` is. Both are hidden from 
user-facing drivers, but unlike `-verify`, potential `-cc1 -fno-coroutines` is 
not just intended, but focused on users outside of monorepo. So I'd say it's 
going to be hidden but user-facing feature, rather than internal one. And the 
one that we should document and test if not for users, then for ourselves to 
make sure we maintain its semantics and don't break users. At this point I'd 
say if we go for it, we should go for proper driver option, rather than 
frontend one.

I also wonder how much complexity this language dialect would introduce while 
interacting with other language dialect flags. Is it really worth it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156247/new/

https://reviews.llvm.org/D156247

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to