Endill accepted this revision. Endill added a comment. This revision is now accepted and ready to land.
LGTM I got confused at first why this fix is done in a function named `getSubobjectSizeInBits`, and why do we calculate size to produce a boolean value in the end. Then I realized that this function returns number of bits of value representation, or `std::nullopt` if there are any padding bits, and we take advantage of the latter to implement `hasUniqueObjectRepresentations`. I guess I'm either missing some context or that function could be named better (not in this patch, of course). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
