[PATCH] D58195: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug.

hctim created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provided rule of thumb percentage chances of miss for 4 and 8 bit tag sizes. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58195 Files: clang/docs/HardwareAssistedAddressSani

[PATCH] D58195: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353990: [HWASAN] Updated HWASAN design document to better portray the chance of missing… (authored by hctim, committed by ). Changed prior to commit: https://reviews.llvm.org/D58195?vs=186695&id=186754#

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202237. hctim marked 7 inline comments as done. hctim added a comment. - Updated from Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runt

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > hctim wrote: > > morehouse wrote: > > > Can we just link with gtest_main instead of having this? > > Unfortunately not easily. `

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202275. hctim added a comment. Merged with tip-of-tree in preparation for submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runtime/CMakeLists.txt

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

This revision was automatically updated to reflect the committed changes. Closed by commit rL362138: [GWP-ASan] Mutex implementation [2]. (authored by hctim, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D61923?vs=202275&id=202276#toc R

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this broke an autoconf bot . Have submitted rL362149 , which should hopefully fix the issue. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this also broke an armv8 bot, due to a maximum number of threads issue. Have filed rL362163 to attempt to fix. If that doesn't work, I'll just disable the test for armv8. Repository: rL LLVM CHANGES SINCE LAST ACTION ht

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim abandoned this revision. hctim added a comment. Abandoned as this was merged in small chunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60593/new/ https://reviews.llvm.org/D60593 ___ cfe-comm

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim updated this revision to Diff 199083. hctim marked an inline comment as done. hctim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Updated tests to use unittests rather than expose a public interface and exercise that. Minor perf improvements to sh

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim added a comment. In D60593#1495428 , @gribozavr wrote: > What does GWP stand for? Google Wide Profiling . We use the name GWP-ASan, even though it's "technically neit

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 199541. hctim marked 10 inline comments as done. hctim added a comment. Herald added subscribers: cfe-commits, srhines. Herald added a reviewer: jfb. Herald added a project: clang. - Working copy of mutex. - >>! In D61923#1502245

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. In D61923#1502245 , @jfb wrote: > Seems a shame to duplicate mutex again... Why can't use use the STL's version > again? It doesn't allocate. We can't use `std::mutex` as we must be C-compatible (and can't make the strong guarant

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim added a comment. In D60593#1502266 , @jfb wrote: > Hello I'm here to bikeshed, and this is a terrible name for an LLVM project. > Or super appropriate because LLVM itself is a terrible name? In any case, > backronym it to something else, or rename

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 199632. hctim marked 2 inline comments as done. hctim added a comment. In D61923#1502988 , @cryptoad wrote: > Is the question why do Scudo has its own as opposed to rely on platform > specific ones? Yes, I have assump

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. In D61923#1503272 , @jfb wrote: > Have you asked on libcxx-dev whether a stand-alone base is something of > interest to them? No, but I will follow up on that. > Kinda... but your answer really sounds like this is a Google-only p

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200094. hctim added a comment. Merged in master after fixing up some buildbots with the previous patches. Also have pinged libcxx-dev :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.l

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200600. hctim added a comment. Changed GWP-ASan to use platform specific mutexes. For now, we only target Android and Linux, and subsequently only need the pthread_mutex variant for POSIX. Kept around the mutex unittests as it's an easy assertion that the abstr

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200604. hctim marked an inline comment as done. hctim added a comment. - Updated to use pointer-to-impl to abstract implementation behaviour away from header files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/platform_specific/mutex_posix.cpp:43 + +Mutex::Mutex() : PImpl(new Impl) {} +Mutex::~Mutex() { delete PImpl; } eugenis wrote: > This is a dependency on libc++ / libstdc++. > > I'm not sure about u

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200760. hctim marked 2 inline comments as done. hctim added a comment. - Ifdef-d headers into mutex.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runti

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > Can we just link with gtest_main instead of having this? Unfortunately not easily. `generate_compiler_rt_tests` builds each test

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202078. hctim marked 21 inline comments as done. hctim added a comment. - Apologies about the delay on this. Updated with Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM w/ nit Comment at: clang/lib/Driver/SanitizerArgs.cpp:1091 + if (Sanitizers.has(SanitizerKind::FuzzerNoLink)) { +CmdArgs.push_back("-fno-builtin-memcmp"); -

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1092 + // libFuzzer wants to intercept calls to certain library functions, so the + // following -fno-builtin-* flags disable implicit builtin knowledge about + // those functions. Other sanitizers eff

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim added a comment. So - the `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` flag is a property of the build system and not that of the compiler. There are some places (android) where enabling `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` globally changes the behaviour of large amounts of libraries

[PATCH] D83369: hwasan: Don't pass the tagged-globals target-feature to non-aarch64 backends.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83369/new/ https://reviews.llvm.org/D83369 __

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added a comment. In D83494#2147608 , @dokyungs wrote: > Builtin libfunc optimizations may transform memcmp and strcmp-like functions. > To disable such optimizations, -fno-builtin= flag was additionally added in > compiling new test cases. FWIW, th

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added a comment. In D83494#2148180 , @morehouse wrote: > In D83494#2148164 , @dokyungs wrote: > > > Right. Apparently with `-O2` many calls to `memcmp`-like functions are > > removed. I just wondered, though,

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:242 +bool SanitizerArgs::needsFuzzerInterceptors() const { + return needsFuzzer() && !needsAsanRt() && !needsHwasanRt() && + !needsTsanRt() && !needsMsanRt(); HWASan doesn't have

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

hctim accepted this revision. hctim marked an inline comment as done. hctim added a comment. LGTM Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:52 +// NOLINTNEXTLINE +void __sanitizer_weak_hook_memcmp(void *, const void *, const void *, size_t, +

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim created this revision. hctim added reviewers: pcc, ostannard. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kristof.beyls, rovka. Herald added projects: clang, Sanitizers, LLVM. HWASan globals instruction selection lowering hasn't been implemented in GlobalISel or FastISe

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2105036 , @arsenm wrote: > Is the fallback not working correctly in this case for some reason? I'm fairly sure that G_GLOBAL_VALUE used to fallback onto SelectionDAGISel, and that was changed in D78465

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2109920 , @eugenis wrote: > I'm OK with this as a workaround, but it would be more natural to detect the > unsupported IR pattern in globalisel and fall back instead of disabling it > entirely. Is it difficult to do for s

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2110010 , @arsenm wrote: > I don't follow. It no longer falls back, so what is the problem? HWASan-globals end up with an address that's outside of the code model (due to the tag), so the normal instruction sequence of `

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim abandoned this revision. hctim added a comment. Abandoning - fixing the underlying issue at D82615 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82249/new/ https://reviews.llvm.org/D82249 ___

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim created this revision. hctim added reviewers: morehouse, Dor1s. Herald added a project: clang. Herald added a subscriber: cfe-commits. Probably a useful feature for checking whether a file was built with -fsanitize=fuzzer or -fsanitize=fuzzer-no-link. N.B. __has_feature(fuzzing_coverage) do

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim updated this revision to Diff 274656. hctim added a comment. Changed the filename and fixed up the inverted test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82926/new/ https://reviews.llvm.org/D82926 Files: clang/include/clang/Basic/Fea

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

hctim added a comment. Hi folks, looks like this patch broke `check-clang` under ASan/MSan, would you mind taking a look? Thanks. FAIL: Clang :: Driver/darwin-dsymutil.c (6208 of 24675) TEST 'Clang :: Driver/darwin-dsymutil.c' FAILED Script: --

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 457431. hctim added a comment. Herald added subscribers: cfe-commits, ormris, steven_wu. Herald added a project: clang. Move some existing stack tests to use -fsanitize=memtag-stack now that we have a non-android warning on -fsanitize=memtag-globals (which is i

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim created this revision. hctim added reviewers: fmayer, eugenis. Herald added subscribers: hiraditya, kristof.beyls, mgorny. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adds the I

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458472. hctim marked 3 inline comments as done. hctim added a comment. Update from Florian's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files: clang/te

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:60 + // gadgets. + if (G.getName().startswith("llvm.") || G.isThreadLocal() || G.isConstant()) { +Meta.Memtag = false; fmayer wrote: > not necessarily in this CL: do

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458487. hctim marked an inline comment as done. hctim added a comment. Update inlined constants to use named constant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 F

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:25 + +using namespace llvm; + fmayer wrote: > why don't we put this into the llvm namespace rather than using? common for code in this folder, `INITIALIZE_PASS_BEGIN` (belo

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458536. hctim marked 2 inline comments as done. hctim added a comment. Some namespace moving and shaking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files: clang

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 459534. hctim added a comment. Remove unnecessary hasSanitizerMetadata() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 Files: clang/test/Driver/memtag-stack.c cla

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address a follow-up TODO for Sanitizer Metadata. Repository: rG LLVM Github Monorepo ht

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 3 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rGdacfa24f75c3: Delete 'llvm.asan.globals' for global metadata. (authored by hctim). Changed prior to commit:

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3614242 , @thakis wrote: > Looks like this breaks check-clang on windows: > http://45.33.8.238/win/61067/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks. Added a2095d1aff84

[PATCH] D128950: Add 'sanitize_memtag' Global IR attribute

hctim updated this revision to Diff 443390. hctim added a comment. Herald added subscribers: cfe-commits, ormris, steven_wu. Herald added a project: clang. After talking with Evgenii offline, and testing, clearly we don't need an exclude mask. Update the patch to remove the exclude mask, and repl

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked 7 inline comments as done. hctim added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/test/Lexer/has_feature_memtag_stack.cpp:2 +// RUN: %clang_cc1 -E -fsanitize=memtag-stack %s -o - | FileCheck --check-prefix=CHECK-MEMTAG %s +// RUN: %cla

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 419874. hctim marked an inline comment as done. hctim added a comment. (comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/Dia

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 420274. hctim marked 2 inline comments as done. hctim added a comment. (comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/Dia

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/test/Driver/memtag-ld.c:36 + +// CHECK-ASYNC: ld{{.*}} "-memtag-mode=async" +// CHECK-DEFAULT-MODE-NOT: ld{{.*}} "--android-memtag-mode= MaskRay wrote: > This will be easier to

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked an inline comment as done. hctim added a comment. In D118948#3427344 , @tschuett wrote: > Is `-fsanitize=memtag-heap` Android specific or target independent? It passes > Android flags to the linker?!? The frontend flag should be target-inde

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 420590. hctim added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. In D118948#3428157 , @MaskRay wrote: > Since this driver option has no-op for glibc/musl/other ELF OS, by convention > it should report an `err_drv_unsupported_opt_for_target` error. > This allows configure-time detection. Done.

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 421581. hctim added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clan

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. Over to @eugenis for any final touches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 421593. hctim marked an inline comment as done. hctim added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDr

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack' requires hardware support (+memta

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa1490513f1: [MTE] Add -fsanitize=memtag* and friends. (authored by hctim). Changed prior to commit: https://reviews.llvm.org/D118948?vs=421593&i

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. Thanks, I'll take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim created this revision. hctim added reviewers: echristo, cmtice. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An upcoming patch will extend llvm-symbolizer to provide the source line information fo

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3454354 , @dblaikie wrote: > This seems like it would significantly introduce debug info size for at least > some kinds of code - have you done any size measurements of this change? With `-DCMAKE_BUILD_TYPE=RelWithDebIn

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. section : increase in bytes for clang built with full debuginfo : %% of total binary size .debug_loclists 317782 0.0250% .debug_abbrev 88590 0.0070% .debug_info 100708340.7929% .debug_rnglists

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3462551 , @dblaikie wrote: > What's the DW_AT_type referring to? (why is there a type called ".str"?) > > For your particular purposes, it seems like the name/type/linkage name could > all be omitted & that might be OK,

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 424055. hctim added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Patch update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D12

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Confirmed again with `-DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS=On`: 1510883864 (new) - 1510881800 (old) = 2064 bytes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Yeah, as I drove away from my desk I realized my mistake. Will get new accurate numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. 1263559896 (new) - 1248280328 (old) = 15279568 B (1.22% increase). Seems more reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. I just did an experiment with the following patch that punts everything to `const char*` types to try and get better folding onto a single type: The change didn't make a significant difference, with the clang binary size of 1263433512 (126384B reduction, or 1.224% -> 1.21

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, dang, arichardson, emaste. Herald added a reviewer: MaskRay. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Current

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked 9 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1536 +enum { + NT_TYPE_IDENT = 1, + NT_TYPE_KUSER = 3, MaskRay wrote: > If Android wants to define notes, can it use a namespace `NT_ANDROID_*`

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405839. hctim marked an inline comment as done. hctim added a comment. Address Ray's comments, and made it so that stack MTE doesn't imply heap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://r

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. In D118948#3295321 , @MaskRay wrote: > I haven't investigated the use case yet, just commented a few things. Please > split the patch into 3: > > - BinaryFormat/ELF.h (see an inline comment) > - lld/ELF > - clang Can you clarify w

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 405842. hctim added a comment. (forgot to add REQUIRES: aarch64 to the lld test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/Diag

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, hiraditya. Herald added a reviewer: aaron.ballman. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-com

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim planned changes to this revision. hctim marked 8 inline comments as done. hctim added a comment. Pushed the [1/3] ELF note parsing over to D119381 . Will leave this review for the clang-side changes, and send a new patch for the LLD changes. All of your co

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. > summary of DWARF: > & how many of these descriptions get added to the debug info? afaict, there is now: 1x .debug_addr entry for each string 1x. debug_info DW_TAG_variable for each string 1x. DW_TAG_array_type + DW_TAG_subrange_type for each unique sizeof(string) i tr

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim marked an inline comment as done. hctim added inline comments. Comment at: clang/test/CodeGen/debug-info-variables.c:1 +// RUN: %clang_cc1 %s -debug-info-kind=standalone -S -emit-llvm -o - | FileCheck %s + dblaikie wrote: > Presumably named variables are a

[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added a comment. Sorry for the large patch. Honestly, looks bigger than it is due to 1-line changes in many files + many-line changes in stuff that was pretty much moved around. I didn't see a great way to split this up except for sharding out the GlobalValue changes + IR + bitcode read/w

[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 425379. hctim added a comment. Wrong base, updating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGDe

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 426172. hctim marked an inline comment as done. hctim added a comment. Herald added subscribers: rupprecht, MaskRay, emaste. Herald added a reviewer: jhenderson. Update test, rebase off of string debuginfo. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 426175. hctim added a comment. (restoring after uploading the diff for D123538 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 426176. hctim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. (restoring after uploading the diff for D123534 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 426177. hctim added a comment. (restoring after uploading the diff for D123534 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

hctim created this revision. hctim added a reviewer: eugenis. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang misses attaching sanitizer metadata for external globals. Repository: rG LLVM Github

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim updated this revision to Diff 443702. hctim marked an inline comment as done. hctim added a comment. Integrate Vitaly's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llvm.org/D128672 Files: clang/lib

[PATCH] D128672: Update DynInit generation for ASan globals.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18de7619e5d: Update DynInit generation for ASan globals. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llv

[PATCH] D128950: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

hctim updated this revision to Diff 444111. hctim marked an inline comment as done. hctim added a comment. Final comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128950/new/ https://reviews.llvm.org/D128950 Files: clang/lib/CodeGen/Saniti

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

hctim updated this revision to Diff 444115. hctim added a comment. Update ASan and HWASan tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129492/new/ https://reviews.llvm.org/D129492 Files: clang/lib/CodeGen/CodeGenModule.cpp clan

[PATCH] D128950: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90e5a8ac475f: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7045519359de: Add missing sanitizer metadata plumbing from CFE. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129492/new/ https://revie

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. Looks like unfortunately this breaks all lots of libcxx tests - which were picked up by our sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/85/builds/9157 Should be reproducible with just `cmake -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" && make check-cxx`.

[PATCH] D129048: Rewording the "static_assert" to static assertion

hctim added a comment. In D129048#3652689 , @aaron.ballman wrote: > In D129048#3652679 , @hctim wrote: > >> Looks like unfortunately this breaks all lots of libcxx tests - which were >> picked up by our sanitize

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3489262 , @dblaikie wrote: > @rnk @aprantl @probinson: this looks plausible to me to take as a general > change to the emitted DWARF, but I'm open to ideas/suggestions if folks find > this to be too much growth for not

  1   2   3   >