hctim added a comment.

In D82249#2110010 <https://reviews.llvm.org/D82249#2110010>, @arsenm wrote:

> I don't follow. It no longer falls back, so what is the problem?


HWASan-globals end up with an address that's outside of the code model (due to 
the tag), so the normal instruction sequence of `adrp + mov` or `adrp + ldr/str 
(with folded imm)` isn't adequate. In SelectionDAGISel, we emit a `movk` as 
well after the `adrp` to capture the top 16 bits. We need to do the same for 
GlobalISel. This is a temporary workaround to fix HWASan at `-O0` while I go 
and add support for adding the tagged-address lowering in GlobalISel.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82249/new/

https://reviews.llvm.org/D82249



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to