hctim added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:60
+ // gadgets.
+ if (G.getName().startswith("llvm.") || G.isThreadLocal() || G.isConstant()) {
+ Meta.Memtag = false;
----------------
fmayer wrote:
> not necessarily in this CL: do we want some attribute to turn off
> instrumentation?
memtag sanitization is not-implicit (i.e. it's opt-in rather than opt-out):
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/GlobalValue.h#L327,
so a turn-off attribute should be unnecessary
================
Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:108
+
+ Value *Indices2[2];
+ IRBuilder<> IRB(M.getContext());
----------------
fmayer wrote:
> what does this do?
dead code, thanks, removed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133392/new/
https://reviews.llvm.org/D133392
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
