hctim added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:25
+
+using namespace llvm;
+
----------------
fmayer wrote:
> why don't we put this into the llvm namespace rather than using?
common for code in this folder, `INITIALIZE_PASS_BEGIN` (below) errors out not
being in the `llvm` namespace, but also warns about redundantly using `llvm::`
in the macro expansion if you explicitly use the namespace...
================
Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:29
+
+namespace {
+
----------------
tschuett wrote:
> I believe you are going too far with the anonymous namespace. There is no
> need for static functions in anonymous namespaces.
>
> https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
moved everything but the class out of the namespace
================
Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:93
+
+ uint64_t NewSize = alignTo(SizeInBytes, 16);
+ if (SizeInBytes != NewSize) {
----------------
tschuett wrote:
> If the `16` is the size of the granule, then it deserves to be named
> constant.
thanks, done
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133392/new/
https://reviews.llvm.org/D133392
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
