hctim marked 9 inline comments as done.
hctim added inline comments.
================
Comment at: llvm/include/llvm/BinaryFormat/ELF.h:1536
+enum {
+ NT_TYPE_IDENT = 1,
+ NT_TYPE_KUSER = 3,
----------------
MaskRay wrote:
> If Android wants to define notes, can it use a namespace `NT_ANDROID_*` like
> GNU?
>
> Please see `https://reviews.llvm.org/D107949` how I add ELF attributes and
> related tests when new additions are added to BinaryFormat/ELF.h
Android currently defines their internal note types in this naming scheme
(https://cs.android.com/android/platform/superproject/+/master:bionic/libc/private/bionic_asm_note.h).
However, it seems like these are not used outside of Android internally, so let
me slap some prefixes on them. Maybe I'll even get around to updating them in
the Android tree as well, who knows.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118948/new/
https://reviews.llvm.org/D118948
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
