hctim marked 7 inline comments as done. hctim added inline comments. Herald added a subscriber: StephenFan.
================ Comment at: clang/test/Lexer/has_feature_memtag_stack.cpp:2 +// RUN: %clang_cc1 -E -fsanitize=memtag-stack %s -o - | FileCheck --check-prefix=CHECK-MEMTAG %s +// RUN: %clang -E -fsanitize=memtag --target=aarch64-unknown-linux -march=armv8a+memtag %s -o - \ +// RUN: | FileCheck --check-prefix=CHECK-MEMTAG %s ---------------- MaskRay wrote: > `%clang` is generally only used in test/Driver tests. (There are violations > but the patch should not add more). It looks like the SanitizerGroups aren't parsed in in the cc1 invocation, given that using `-cc1` provides an error of: `error: invalid value 'memtag' in '-fsanitize='` non-cc1 invocations are thus standard (see `clang/test/Lexer/has_feature_undefined_behavior_sanitizer.cpp` for an example) for testing sanitizers. (fwiw - I couldn't find out *why* there's a discrepancy between sanitizers and sanitizer groups, otherwise we could potentially fix it, but it would only be for the sake of "making tests all use _cc1") Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
