[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. Is there anything left here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

jamieschmeiser added a comment. I'm a little confused as to what is being proposed here. Is this building on D131469 or is it an alternative? It seems that there are portions of the code from D131469 included in these chang

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5459 + if (AtTopLevel && !isa(JA) && !isa(JA) && + !(IsDXCMode() && C.getArgs().hasArg(options::OPT__SLASH_P))) { if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) Why is

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 459833. python3kgae added a comment. Use O0 instead of DxcOptDisable since Od is same as O0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files: clang/includ

[PATCH] D132589: [HLSL] Add acos library function

beanz added a comment. @bob80905, if you rebase this you should be able to add half support too now. Otherwise this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132589/new/ https://reviews.llvm.org/D132589 ___

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

dblaikie added a comment. In D133092#3787247 , @azat wrote: > Is there anything left here? Generally not. the usual flow would be once you have approval to go ahead and submit the patch yourself - I take it you don't have commit access? In which case I

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman created this revision. aaron.ballman added reviewers: mgorny, thieta, tstellar. Herald added a subscriber: jdoerfert. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The changes in Clang 15.0.0 which enabled these diagnosti

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpt

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. @thieta and @tstellar -- because these changes are expected to go into the 15.0.1 branch, not the current main branch, it wasn't clear to me what the best way to go about the review (whether I should submit a Phab request or make a fork of Clang and submit a GitH

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Two nits, please fix them before merging otherwise looks good. Comment at: clang/include/clang/Driver/Options.td:6941 Group, Flags<[DXCOption, NoXarchOption]>, Alias; + def

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

alexgatea added a comment. In D132913#3786734 , @python3kgae wrote: > In D132913#3786679 , @alexgatea > wrote: > >>> Thanks for reporting the issue. >>> But I cannot repro the fail. >>> Do you mind sharing your

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

thieta added a comment. I think the easiest way to handle this is that when you have it approved here - push it to fork on GitHub based on the release branch and create a GitHub issue and write /branch aballman/llvm-project/my_branch in a comment and it will queue up the cherry pick. Reposito

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. > the usual flow would be once you have approval to go ahead and submit the > patch yourself - I take it you don't have commit access? Yeah, I don't I though that only trusted/experienced/... llvm devs can commit. > In which case I can commit this on your behalf. Yes, ple

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added reviewers: rjmccall, jyknight, MaskRay. aaron.ballman added a comment. Herald added a subscriber: StephenFan. In D133800#3787378 , @thieta wrote: > I think the easiest way to handle this is that when you have it approved here > - push

[PATCH] D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check

barcisz created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This diff extracts the matcher for an unused expression result from b

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:720-722 + if (DriverArgs.hasArg(options::OPT_march_EQ)) +return getProcessorFromTargetID( +getTriple(), DriverArgs.getLastArgValue(options::OPT_march_EQ)); It seems the

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:720-722 + if (DriverArgs.hasArg(options::OPT_march_EQ)) +return getProcessorFromTargetID( +getTriple(), DriverArgs.getLastArgValue(options::OPT_march_EQ)); yaxunl wrote

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 updated this revision to Diff 459848. jhuber6 added a comment. Removing old function update for 'mcpu' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726 Files: clang/include/clang/Driver/ToolChain

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

josemonsalve2 added a comment. This is a good idea. Thanks Joseph. Other than the two comments I made, I think this should be accepted. Jose Comment at: clang/include/clang/Driver/Options.td:2565-2566 Flags<[NoArgumentUnused, HelpHidden]>; -def fopenmp_cuda_force_full_runt

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2565-2566 Flags<[NoArgumentUnused, HelpHidden]>; -def fopenmp_cuda_force_full_runtime : Flag<["-"], "fopenmp-cuda-force-full-runtime">, Group, - Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

jdoerfert added a comment. Remove the option and let's also remove the device flag too while we are at it. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:76 CGOpenMPRuntimeGPU::ExecutionMode &ExecMode; bool SavedRuntimeMode = false; Remove =

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz created this revision. Herald added subscribers: mattd, carlosgalvezp, yaxunl, mgorny. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

josemonsalve2 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2565-2566 Flags<[NoArgumentUnused, HelpHidden]>; -def fopenmp_cuda_force_full_runtime : Flag<["-"], "fopenmp-cuda-force-full-runtime">, Group, - Flags<[CC1Option, NoArgumentUnused, HelpHid

[PATCH] D133518: [HLSL] Call global destructors from entries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8a49923ddf7: [HLSL] Call global destructors from entries (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133518/new/ https://reviews.llv

[clang] a8a4992 - [HLSL] Call global destructors from entries

Author: Chris Bieneman Date: 2022-09-13T15:05:47-05:00 New Revision: a8a49923ddf75be9b6166be2f6a1f50a99817841 URL: https://github.com/llvm/llvm-project/commit/a8a49923ddf75be9b6166be2f6a1f50a99817841 DIFF: https://github.com/llvm/llvm-project/commit/a8a49923ddf75be9b6166be2f6a1f50a99817841.diff

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. @njames93 I fixed the review comments, can this be merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 ___ cfe-commits mailing list

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

Maetveis added a comment. In D133662#3787250 , @jamieschmeiser wrote: > I'm a little confused as to what is being proposed here. Is this building on > D131469 or is it an alternative? It seems > that there are porti

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:150-151 clang::tooling::ArgumentsAdjuster( - clang::clangd::CommandMangler::detect())); + [Mangler = std::shared_ptr( + clang::clangd::CommandMangler:

[clang] 67f08bf - [Clang] [Sema] Ignore invalid multiversion function redeclarations

Author: Evgeny Shulgin Date: 2022-09-13T20:12:09Z New Revision: 67f08bf1bfa85fcdc1d91a3e6cce703e94611244 URL: https://github.com/llvm/llvm-project/commit/67f08bf1bfa85fcdc1d91a3e6cce703e94611244 DIFF: https://github.com/llvm/llvm-project/commit/67f08bf1bfa85fcdc1d91a3e6cce703e94611244.diff LOG

[PATCH] D133641: [Clang] [Sema] Ignore invalid multiversion function redeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG67f08bf1bfa8: [Clang] [Sema] Ignore invalid multiversion function redeclarations (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133641/n

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

ahatanak added a comment. It looks like gcc started rejecting the code relatively recently (11.1). Also, I found out that MSVC doesn't reject the following code: struct T0 { char c; }; struct T2 : virtual T0 { }; T2 array[2]; The size of `T2` is 5 and its alignment is 4. The size of `arra

[PATCH] D133807: Update Unicode to 15.0

cor3ntin created this revision. Herald added subscribers: hiraditya, dschuff. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Unicode 15.0 adds 4,489 characters, for a total of 149,186

[clang] fb5baff - [HLSL] Mark buffer subscript operators as AlwaysInline

Author: Chris Bieneman Date: 2022-09-13T20:31:29-05:00 New Revision: fb5baffc28c8beaf790a2fb1c8a863d29020bfbe URL: https://github.com/llvm/llvm-project/commit/fb5baffc28c8beaf790a2fb1c8a863d29020bfbe DIFF: https://github.com/llvm/llvm-project/commit/fb5baffc28c8beaf790a2fb1c8a863d29020bfbe.diff

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048 CGBuilderTy &Bld = CGF.Builder; - OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime()); + OMPBuilder.createTargetDeinit(Bld, IsSPMD, true); } So, follow

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048 CGBuilderTy &Bld = CGF.Builder; - OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime()); + OMPBuilder.createTargetDeinit(Bld, IsSPMD, true); } jdoerfert wro

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

tom-anders updated this revision to Diff 459864. tom-anders added a comment. Move logic to pickDeclToUse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133664/new/ https://reviews.llvm.org/D133664 Files: clang-tools-extra/clangd/Hover.cpp clang

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

ahatanak added a comment. Unlike gcc or clang. MSVC doesn't round up the size to its alignment. I don't mean it should reject the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711 ___

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

yaxunl added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:719 virtual llvm::SmallVector - getHIPDeviceLibs(const llvm::opt::ArgList &Args) const; + getROCmDeviceLibs(const llvm::opt::ArgList &Args) const; HIPSPV toolchain is not impl

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, two comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048 CGBuilderTy &Bld = CGF.Builder; - OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFul

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

efriedma added a comment. > It looks like gcc started rejecting the code relatively recently (11.1). On what example? The code in the commit message gives an error on gcc 5. > Also, I found out that MSVC doesn't reject the following code: This looks like a backwards-compatibility quirk in the

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

ahatanak added a comment. I was looking at another example. The following code is accepted by 10.3, but is rejected by 11.1 because the size isn't a multiple of the alignment. struct __attribute__((packed)) S { char c; int i; }; typedef S AlignedS __attribute__((aligned(4)));

[PATCH] D133802: [OpenMP] Remove simplified device runtime handling

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1048 CGBuilderTy &Bld = CGF.Builder; - OMPBuilder.createTargetDeinit(Bld, IsSPMD, requiresFullRuntime()); + OMPBuilder.createTargetDeinit(Bld, IsSPMD

[clang] 0c9b242 - [HLSL] Adding a test change I forgot to add

Author: Chris Bieneman Date: 2022-09-13T20:53:39-05:00 New Revision: 0c9b242cf0af15fa154d006cb25f20c7bf05d60a URL: https://github.com/llvm/llvm-project/commit/0c9b242cf0af15fa154d006cb25f20c7bf05d60a DIFF: https://github.com/llvm/llvm-project/commit/0c9b242cf0af15fa154d006cb25f20c7bf05d60a.diff

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25370 + "#if 0\n" + " if (a) {\n" + "#else\n" Can you confirm that there is supposed to be only one space here while there are two in the ne

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 459870. barcisz added a comment. Added some explanation comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

ahatanak added a comment. In D133711#3787604 , @ahatanak wrote: > Unlike gcc or clang. MSVC doesn't round up the size to its alignment. I don't > mean it should reject the code. Sorry, my comment was misleading. clang has the same behavior as MSVC when

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz added a comment. @tschuett does it look alright now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

jcranmer-intel added inline comments. Comment at: clang/docs/UsersManual.rst:1430 + + * ``-ffp-contract=on`` + You can add `-fdenormal-fp-math=ieee` here. Comment at: clang/docs/UsersManual.rst:1453-1455 + Note: ``DenormalFPMath`` and ``Den

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 updated this revision to Diff 459874. jhuber6 added a comment. Changing interface to `getAMDGPUDeviceLibs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726 Files: clang/include/clang/Driver/Tool

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 459877. cor3ntin added a comment. Changelog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/UnicodeCharSets.h

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

thesamesam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:52 + into an error-only diagnostic in the next Clang release. Fixes + `Issue 50055: `_. +- ``-Wincompatible-function-pointer-types`` now defaults to an e

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

thesamesam added a comment. In D133375#3774293 , @aaron.ballman wrote: > So the basic idea here is that the default can be specified by a > configuration file and thus we don't need any configure-time variable for it? > But then why do we need other co

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

tra added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:121 +# Tests should not rely on a certain cuda device being available on the machine, +# or a certain version of it The comment is incorrect. These flags have

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 459883. python3kgae marked an inline comment as done. python3kgae added a comment. Cleanup per comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files:

[PATCH] D133586: [clang] do not hash undefined qualifiers for FunctionNoProtoType

rmaz updated this revision to Diff 459884. rmaz added a comment. zero out qual types in constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133586/new/ https://reviews.llvm.org/D133586 Files: clang/include/clang/AST/Type.h Index: clang/i

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rmaz added a comment. In D133586#3781536 , @rtrieu wrote: > In D133586#3781468 , @rmaz wrote: > >> In D133586#3781381 , @rtrieu wrote: >> >>> Do you have a test case for t

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

efriedma added a comment. Oh, so you mean we need to consider whether we need to avoid emitting an error message when we're dealing with C++ code targeting i686-pc-win32, given we implement the alignment quirk. I think I'd like to try printing an error message, given it's reasonably likely you

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

akyrtzi updated this revision to Diff 459888. akyrtzi added a comment. Add comment to clarify why we skip if `tok::hashhash` is encountered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133674/new/ https://reviews.llvm.org/D133674 Files: clang/

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

akyrtzi added a comment. In D133674#3784710 , @akyrtzi wrote: > In D133674#3784602 , @jansvoboda11 > wrote: > >> Could you explain why this is necessary and even correct? I'd expect Clang >> to give an error whe

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

probinson added a comment. > we don't use addLTOOptions() for either PS4 or PS5, so this patch doesn't > affect (or help) them. I'm okay with saying we'll need to deal with that case > separately. FTR, I've raised an internal ticket about this, and someone from Sony will handle it. Repositor

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 459893. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contra

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1453-1455 + Note: ``DenormalFPMath`` and ``DenormalFP32Math`` are set by default to IEEE + (no flush) for ``-fno-fast-math``, ``-fno-unsafe-math-optimizations``, and + any setting of ``fp-model``. Clang

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133674/new/ https://reviews.llvm.org/D133674 ___

[clang] 6bf6730 - [clang] fix generation of .debug_aranges with LTO

Author: Azat Khuzhin Date: 2022-09-13T22:33:56Z New Revision: 6bf6730ac55e064edf46915ebba02e9c716f48e8 URL: https://github.com/llvm/llvm-project/commit/6bf6730ac55e064edf46915ebba02e9c716f48e8 DIFF: https://github.com/llvm/llvm-project/commit/6bf6730ac55e064edf46915ebba02e9c716f48e8.diff LOG:

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf6730ac55e: [clang] fix generation of .debug_aranges with LTO (authored by azat, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1330

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

dblaikie added a comment. In D133092#3787379 , @azat wrote: >> the usual flow would be once you have approval to go ahead and submit the >> patch yourself - I take it you don't have commit access? > > Yeah, I don't > I though that only trusted/experience

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

yaxunl added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:719 virtual llvm::SmallVector - getHIPDeviceLibs(const llvm::opt::ArgList &Args) const; + getAMDGPUDeviceLibs(const llvm::opt::ArgList &Args) const; well, HIPSPV toolchain is

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

ahatanak added a comment. No, I was thinking perhaps clang has to round up the size to the alignment when the target is 32-bit MSVC too. The code in https://godbolt.org/z/c1EzdYqPc is perfectly valid so I don't think we want to reject it, but we don't want to keep emitting buggy code either. I

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

vitalybuka added a comment. It breaks the bot https://lab.llvm.org/buildbot/#/builders/5/builds/27410 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132997/new/ https://reviews.llvm.org/D132997 ___ cfe-co

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:719 virtual llvm::SmallVector - getHIPDeviceLibs(const llvm::opt::ArgList &Args) const; + getAMDGPUDeviceLibs(const llvm::opt::ArgList &Args) const; yaxunl wrote: > well, HIP

[PATCH] D133674: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

This revision was automatically updated to reflect the committed changes. Closed by commit rGb340c5ae4221: [Lex/DependencyDirectivesScanner] Handle the case where the source line starts… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] b340c5a - [Lex/DependencyDirectivesScanner] Handle the case where the source line starts with a `tok::hashhash`

Author: Argyrios Kyrtzidis Date: 2022-09-13T15:48:50-07:00 New Revision: b340c5ae4221a9752712621cd1df06cbc6dfd50b URL: https://github.com/llvm/llvm-project/commit/b340c5ae4221a9752712621cd1df06cbc6dfd50b DIFF: https://github.com/llvm/llvm-project/commit/b340c5ae4221a9752712621cd1df06cbc6dfd50b.

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

yaxunl added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:719 virtual llvm::SmallVector - getHIPDeviceLibs(const llvm::opt::ArgList &Args) const; + getAMDGPUDeviceLibs(const llvm::opt::ArgList &Args) const; jhuber6 wrote: > yaxunl wr

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

jhuber6 updated this revision to Diff 459911. jhuber6 added a comment. Changing to `getDeviceLibs`. I suppose in the future we could make this work for CUDA, but for now it won't be defined for that toolchain so it's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

efriedma added a comment. Messing with the layout is risky. If we give an error, the user will notice something is wrong, and can adapt their code (e.g. explicitly enforcing alignment using alignas). If we silently use a different layout, and the class is used across compilers, the user ends

[clang] b6965f7 - [IR] Add alignment for llvm.threadlocal.address

Author: Alexander Shaposhnikov Date: 2022-09-13T23:10:55Z New Revision: b6965f7246bba1b399755f56d8ae34893e815198 URL: https://github.com/llvm/llvm-project/commit/b6965f7246bba1b399755f56d8ae34893e815198 DIFF: https://github.com/llvm/llvm-project/commit/b6965f7246bba1b399755f56d8ae34893e815198.d

[PATCH] D133741: [IR] Add alignment for llvm.threadlocal.address

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6965f7246bb: [IR] Add alignment for llvm.threadlocal.address (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133741/new/

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

kcc added inline comments. Comment at: clang/docs/SanitizerCoverage.rst:382 + void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, +const uintptr_t *cfs_end) { +// [cfs_beg,cfs_end) is the array of ptr-sized integers representing --

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5459 + if (AtTopLevel && !isa(JA) && !isa(JA) && + !(IsDXCMode() && C.getArgs().hasArg(options::OPT__SLASH_P))) { if (Arg *FinalOutput = C.getArgs()

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

dblaikie created this revision. dblaikie added reviewers: ayzhao, hansw. Herald added subscribers: mstorsjo, kristof.beyls. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Details posted here: https://r

[PATCH] D133807: Update Unicode to 15.0

shafik added a comment. Thank you for doing this work. Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713 + // 8 characters + if (C <= 0xa7c2) return C | 1; Maybe I am misunderstanding the comments but should this be `0xa7be`? Commen

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

aaronpuchert added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + mizvekov wrote: > davrec wrote: > > mizv

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5195-5196 +for (int i = 0, e = std::min(NumParams1, NumParams2); i < e; ++i) { + QualType T1 = FD1->getParamDecl(i)->getType().getDesugaredType(Context); + QualType T2 = FD2->getPar

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

kcc added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:1 +// Tests -fsanitize-coverage=control-flow. + I suggest to make this test smaller: * foo() can by empty (but avoid inlining) * main() can hav

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. @mizvekov Thanks for taking a look. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5195-5196 +for (int i = 0, e = std::min(NumParams1, NumParams2); i < e; ++i) { + QualType T1 = FD1->getParamDecl(i)->getType().getDesugaredType(Context); +

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:181 +if (DAL->hasArg(options::OPT__SLASH_P)) + getDriver().Diag(diag::warn_drv_dxc_ignore_output_for_preprocess) << "Fo"; + python3kgae wrote: > beanz wrote: > > This warning

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + aaronpuchert wrote: > mizvekov wrote: > > da

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 459941. cor3ntin added a comment. Use the name "Unicode 15.0" consistently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. Thanks for the review Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713 + // 8 characters + if (C <= 0xa7c2) return C | 1; shafik wrote: > Maybe I am misunderstanding the comments but should this be `0xa7be`? Quirk of the scr

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459944. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D133622: [clang][test] Disallow using the default module cache path in lit tests

bruno added a comment. > I'm not sure how to deal with missing `env -u`. > > - We could do `env CLANG_MODULE_CACHE_PATH=` and change the compiler's > interpretation of empty string for this variable. I'm not sure if the current > behaviour (there will be no module cache in the cc1 at all) is int

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459946. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. @vhscampos that issue should be fixed now as well, thanks for the report! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 ___ cfe-comm

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4442 +bool IsClangCL) { + unsigned RTOptionID = 0; // MT=0, MTd=1, MD=2, MDd=3 + bool HasLDdFlag = IsClangCL && Args.hasArg(options::OPT__SLASH_LDd); --

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ychen added a comment. It surprises me that Option 2 does not change https://eel.is/c++draft/dcl.fct.def.coroutine#10. For consistency, I think it should. And according to your test case, it deals with alignment as expected. Probably we should change the P2014R0 wording accordingly. Before that

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ychen added inline comments. Comment at: clang/test/SemaCXX/coroutine-alloc-4.cpp:49 +void return_value(int) {} +void *operator new(std::size_t, std::align_val_t) noexcept; +void *operator new(std::size_t) noexcept; Like this test case, please add add

[PATCH] D127800: [llvm-driver] Generate symlinks instead of executables for tools

Amir added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1283 macro(add_llvm_tool name) + cmake_parse_arguments(ARG "DEPENDS;GENERATE_DRIVER" "" "" ${ARGN}) if( NOT LLVM_BUILD_TOOLS ) Sorry for a late question but I don't see any use of ARG_D

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 459959. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D127800: [llvm-driver] Generate symlinks instead of executables for tools

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1283 macro(add_llvm_tool name) + cmake_parse_arguments(ARG "DEPENDS;GENERATE_DRIVER" "" "" ${ARGN}) if( NOT LLVM_BUILD_TOOLS ) Amir wrote:

<    1   2   3   >