josemonsalve2 added a comment.
This is a good idea. Thanks Joseph.
Other than the two comments I made, I think this should be accepted.
Jose
================
Comment at: clang/include/clang/Driver/Options.td:2565-2566
Flags<[NoArgumentUnused, HelpHidden]>;
-def fopenmp_cuda_force_full_runtime : Flag<["-"],
"fopenmp-cuda-force-full-runtime">, Group<f_Group>,
- Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
-def fno_openmp_cuda_force_full_runtime : Flag<["-"],
"fno-openmp-cuda-force-full-runtime">, Group<f_Group>,
- Flags<[NoArgumentUnused, HelpHidden]>;
+def fopenmp_cuda_force_full_runtime : Flag<["-"],
"fopenmp-cuda-force-full-runtime">, Flags<[HelpHidden]>;
+def fno_openmp_cuda_force_full_runtime : Flag<["-"],
"fno-openmp-cuda-force-full-runtime">, Flags<[HelpHidden]>;
def fopenmp_cuda_number_of_sm_EQ : Joined<["-"],
"fopenmp-cuda-number-of-sm=">, Group<f_Group>,
----------------
Why not remove these? Are they used somewhere else?
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:80-90
ExecutionRuntimeModesRAII(CGOpenMPRuntimeGPU::ExecutionMode &ExecMode)
: ExecMode(ExecMode) {
SavedExecMode = ExecMode;
ExecMode = CGOpenMPRuntimeGPU::EM_NonSPMD;
}
/// Constructor for SPMD mode.
+ ExecutionRuntimeModesRAII(CGOpenMPRuntimeGPU::ExecutionMode &ExecMode, bool)
----------------
What if we combine these two and just leave one that receives two modes. I am
really confused by this code. Is there something I am missing here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133802/new/
https://reviews.llvm.org/D133802
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
