josemonsalve2 added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:2565-2566
   Flags<[NoArgumentUnused, HelpHidden]>;
-def fopenmp_cuda_force_full_runtime : Flag<["-"], 
"fopenmp-cuda-force-full-runtime">, Group<f_Group>,
-  Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
-def fno_openmp_cuda_force_full_runtime : Flag<["-"], 
"fno-openmp-cuda-force-full-runtime">, Group<f_Group>,
-  Flags<[NoArgumentUnused, HelpHidden]>;
+def fopenmp_cuda_force_full_runtime : Flag<["-"], 
"fopenmp-cuda-force-full-runtime">, Flags<[HelpHidden]>;
+def fno_openmp_cuda_force_full_runtime : Flag<["-"], 
"fno-openmp-cuda-force-full-runtime">, Flags<[HelpHidden]>;
 def fopenmp_cuda_number_of_sm_EQ : Joined<["-"], 
"fopenmp-cuda-number-of-sm=">, Group<f_Group>,
----------------
jhuber6 wrote:
> josemonsalve2 wrote:
> > Why not remove these? Are they used somewhere else? 
> We usually don't remove driver arguments between releases as this could cause 
> existing applications to stop compiling. Leaving them here will cause Clang 
> to continue compiling but emit an unused flag warning.
Will that generate a warning saying this flag has no use? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133802/new/

https://reviews.llvm.org/D133802

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D133802:... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D13... Joseph Huber via Phabricator via cfe-commits
    • [PATCH] D13... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D13... Jose Manuel Monsalve Diaz via Phabricator via cfe-commits
    • [PATCH] D13... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D13... Joseph Huber via Phabricator via cfe-commits
    • [PATCH] D13... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D13... Joseph Huber via Phabricator via cfe-commits

Reply via email to