abrachet marked an inline comment as done.
abrachet added inline comments.
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1283
macro(add_llvm_tool name)
+ cmake_parse_arguments(ARG "DEPENDS;GENERATE_DRIVER" "" "" ${ARGN})
if( NOT LLVM_BUILD_TOOLS )
----------------
Amir wrote:
> Sorry for a late question but I don't see any use of ARG_DEPENDS - is it
> intentional or there's an omission somewhere?
It looks like this was superfluous and likely copied from a place where DEPENDS
is used. It's not necessary for depends to be used here, as it wasn't being
used before for `add_llvm_tool`. I'll remove this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127800/new/
https://reviews.llvm.org/D127800
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
