jhuber6 added inline comments.
================ Comment at: clang/include/clang/Driver/ToolChain.h:719 virtual llvm::SmallVector<BitCodeLibraryInfo, 12> - getHIPDeviceLibs(const llvm::opt::ArgList &Args) const; + getAMDGPUDeviceLibs(const llvm::opt::ArgList &Args) const; ---------------- yaxunl wrote: > well, HIPSPV toolchain is not for AMDGPU. My thinking is that this API is to > get device libraries for the toolchain, not for a specific target or platform. I guess the problem is that this option can't be totally generic since it's in the top-level `Toolchain` namespace. Otherwise it would get confused with CUDA's device library. What's a good common name to use for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ https://reviews.llvm.org/D133726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
