kcc added inline comments.
================ Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:1 +// Tests -fsanitize-coverage=control-flow. + ---------------- I suggest to make this test smaller: * foo() can by empty (but avoid inlining) * main() can have a single conditional call to foo * main should also have a single conditional indirect call to test the -1 indir call marker. * __sanitizer_cov_cfs_init should capture its arguments and return * main should insepct the arguments captured in __sanitizer_cov_cfs_init and verify that it sees main() and foo(), and that main contains calls to foo() and indir function, outside of the entry BB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
