Maetveis added a comment. In D133662#3787250 <https://reviews.llvm.org/D133662#3787250>, @jamieschmeiser wrote:
> I'm a little confused as to what is being proposed here. Is this building on > D131469 <https://reviews.llvm.org/D131469> or is it an alternative? It seems > that there are portions of the code from D131469 > <https://reviews.llvm.org/D131469> included in these changes, which implies > that you are building on it. I think this patch is premature in that the > other patch has not yet landed (@MaskRay has asked for revisions that > @dongjunduo has made but is waiting for review). When that patch has landed, > this could be reposted based on those changes. Yes, there is some code taken from D131469 <https://reviews.llvm.org/D131469>, mainly removing the -ftime-trace file logic from cc1. The way the paths on where to store the traces are different both in implementation and in behaviour. D131469 <https://reviews.llvm.org/D131469> is rewriting the arguements for already created jobs and infers the path based on a link job. This patch sets up the time trace path for each job that supports it, so it can be read during assembling of the commands. The location is based on the final output (-o <out>) and the file names are based on the inputs instead of the output names (similar to -save-temps). I felt that this is a different approach, that might not be taken once D131469 <https://reviews.llvm.org/D131469> is accepted. If it's better to leave these points as suggestions on D131469 <https://reviews.llvm.org/D131469>, than I can summarize them over there. Waiting for it to land is also fine for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133662/new/ https://reviews.llvm.org/D133662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
