Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

ariccio updated this revision to Diff 50241. ariccio added a comment. For some reason, this smaller diff was harder to upload than the first diff. http://reviews.llvm.org/D17983 Files: llvm/lib/Analysis/DependenceAnalysis.cpp llvm/lib/Analysis/InstructionSimplify.cpp llvm/lib/AsmParser/LL

Re: [PATCH] D5896: Emit minnum / maxnum for __builtin_fmin/fmax

arsenm added a comment. ping since there seems to be a consensus now that intrinsics should be preferred http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D4507: R600: Define device name macros.

arsenm abandoned this revision. arsenm added a comment. Going to redo this with simplified names http://reviews.llvm.org/D4507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263093 - ARM: fix arm_neon_intrinsics.c and re-enable.

Author: tnorthover Date: Wed Mar 9 22:39:45 2016 New Revision: 263093 URL: http://llvm.org/viewvc/llvm-project?rev=263093&view=rev Log: ARM: fix arm_neon_intrinsics.c and re-enable. It turns out I'd never actually tested my recent change because it was gated on long-tests. Failure ensued. Modif

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r263091 - Disable failing test and fix RUN line.

Author: rtrieu Date: Wed Mar 9 22:04:12 2016 New Revision: 263091 URL: http://llvm.org/viewvc/llvm-project?rev=263091&view=rev Log: Disable failing test and fix RUN line. See https://llvm.org/bugs/show_bug.cgi?id=26894 for details. This change fixes the incorrect flags to Clang and the piping i

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

pxli168 added a comment. The logic is still to complex and I hope it can be optimized. Comment at: lib/Sema/SemaExpr.cpp:6222-6227 @@ -6188,1 +6221,8 @@ +auto ResultAddrSpace = ResultTy.getQualifiers().getAddressSpace(); +LHSCastKind = lhQual.getAddressSpace() == ResultA

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

arpith-jacob marked an inline comment as done. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentNa

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli added a comment. Support for global variables in a target region requires the global to be placed in a pragma declare target region. Pragma declare target region is not currently available in Clang (no parsing, sema, or codegen). I will add a check for this in the regression test

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentName,

Re: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

I resubmitted the patch as http://reviews.llvm.org/D18025 and included the mailing list as a subscriber, so that the replies are not getting lost. Sorry for the inconvenience. -Roman > On Mar 8, 2016, at 5:44 PM, Roman Levenstein via cfe-commits > wrote: > >

[PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

swiftix created this revision. swiftix added reviewers: ributzka, aaron.ballman. swiftix added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Till now, preserve_mostcc/preserve_allcc calling convention attributes were only available at the LLVM IR level. This patch adds attribute

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

ABataev added a comment. Add tests with captured globals to check that this problem is resolved Repository: rL LLVM http://reviews.llvm.org/D17963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

joker.eph created this revision. joker.eph added a reviewer: chandlerc. joker.eph added a subscriber: cfe-commits. Following r263086, we are now relying on a flag on the Context to discard Value names in release builds. http://reviews.llvm.org/D18024 Files: lib/CodeGen/CGBuilder.h lib/CodeGe

r263087 - Fix false positives for for-loop-analysis warning

Author: steven_wu Date: Wed Mar 9 20:02:48 2016 New Revision: 263087 URL: http://llvm.org/viewvc/llvm-project?rev=263087&view=rev Log: Fix false positives for for-loop-analysis warning Summary: For PseudoObjectExpr, the DeclMatcher need to search only all the semantics but also need to search pa

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

This revision was automatically updated to reflect the committed changes. steven_wu marked 2 inline comments as done. Closed by commit rL263087: Fix false positives for for-loop-analysis warning (authored by steven_wu). Changed prior to commit: http://reviews.llvm.org/D17627?vs=50212&id=50221#t

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

rjmccall added a comment. Thanks, LGTM. http://reviews.llvm.org/D17627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17999: Rewrite ARM & AArch64 tests to check LLVM IR rather than assembly

rengolin added a comment. Great work, Tim! Thank you! http://reviews.llvm.org/D17999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

hfinkel added a comment. In http://reviews.llvm.org/D17993#371459, @chandlerc wrote: > In http://reviews.llvm.org/D17993#371454, @hfinkel wrote: > > > In http://reviews.llvm.org/D17993#370793, @chandlerc wrote: > > > > > If we're not going to fully implement "fdelete-null-pointer-checks" we > >

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

hfinkel added a comment. In http://reviews.llvm.org/D17993#370790, @rjmccall wrote: > Hal, I think you're talking about a slightly different thing. This patch is > adding an assumption that C++ this pointers are non-null, but only when > -fno-delete-null-pointer-checks is not passed. The flag

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

chandlerc added a comment. In http://reviews.llvm.org/D17993#371454, @hfinkel wrote: > In http://reviews.llvm.org/D17993#370793, @chandlerc wrote: > > > If we're not going to fully implement "fdelete-null-pointer-checks" we > > shouldn't claim to... I'm really worried about us accepting that fla

Re: r262851 - Module Debugging: Fix a crash when emitting debug info for nested tag types

Is this bug only reachable with modules debug info? Could you describe the nature of the fix (not quite clear to me just by looking at it) On Mon, Mar 7, 2016 at 12:58 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Mon Mar 7 14:58:52 2016 > New Re

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

hfinkel added a comment. In http://reviews.llvm.org/D17993#370793, @chandlerc wrote: > If we're not going to fully implement "fdelete-null-pointer-checks" we > shouldn't claim to... I'm really worried about us accepting that flag and not > actually honoring it. > > However, I *do* think this sh

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Wed, Mar 9, 2016 at 11:58 AM, Alexander Riccio via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ariccio added a comment. > > In http://reviews.llvm.org/D17983#370717, @dblaikie wrote: > > > Initializations we never expect to use (eg because we have a covered > switch > > that initializes

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Wed, Mar 9, 2016 at 12:06 PM, Alexander Riccio via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ariccio added a comment. > > Oh, and by the way, what's the policy on using `enum class`es instead of C > style enums? I bet the compiler would have fewer false positives with > strongly typed

Re: [PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address;Undefined" on OSX

Thanks, that's a lot cleaner indeed. I'll update. -- Mehdi > On Mar 9, 2016, at 4:02 PM, Chris Bieneman wrote: > > beanz added inline comments. > > > Comment at: lib/CMakeLists.txt:51 > @@ -50,2 +50,3 @@ > if (APPLE AND LLVM_USE_SANITIZER) > - if ("${LLVM_USE_SANITIZER}" ST

Re: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

> On Mar 8, 2016, at 5:44 PM, Roman Levenstein via cfe-commits > wrote: > > Forgot to add the mailing list when I created a patch. You don’t have cfe-commits in phabricator subscribers, so you probably won’t get notifications when someone replies there. It might make sense to resubmit the pat

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith added a comment. `-f(no-)strict-nonnull-this` maybe? http://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263081 - EmitCXXStructorCall -> EmitCXXDestructorCall. NFC.

Author: samsonov Date: Wed Mar 9 18:20:37 2016 New Revision: 263081 URL: http://llvm.org/viewvc/llvm-project?rev=263081&view=rev Log: EmitCXXStructorCall -> EmitCXXDestructorCall. NFC. This function is only used in Microsoft ABI and only to emit destructors. Rename/simplify it accordingly. Modi

r263080 - Remove unused function arguments. NFC.

Author: samsonov Date: Wed Mar 9 18:20:33 2016 New Revision: 263080 URL: http://llvm.org/viewvc/llvm-project?rev=263080&view=rev Log: Remove unused function arguments. NFC. Modified: cfe/trunk/lib/CodeGen/CGExprCXX.cpp Modified: cfe/trunk/lib/CodeGen/CGExprCXX.cpp URL: http://llvm.org/view

Re: [PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address; Undefined" on OSX

beanz added inline comments. Comment at: lib/CMakeLists.txt:51 @@ -50,2 +50,3 @@ if (APPLE AND LLVM_USE_SANITIZER) - if ("${LLVM_USE_SANITIZER}" STREQUAL "Address") + if ("${LLVM_USE_SANITIZER}" STREQUAL "Address" OR + "${LLVM_USE_SANITIZER}" STREQUAL "Address;Undefined" O

Re: [PATCH] D15314: Fix a bug in unavailable checking

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

steven_wu updated this revision to Diff 50212. steven_wu updated the summary for this revision. steven_wu added a comment. Update according to feedback. I agree that OVE should never be null as semantics of PseudoObjectExpr. http://reviews.llvm.org/D17627 Files: lib/Sema/SemaStmt.cpp test/S

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

On Tue, Mar 8, 2016 at 12:18 PM, Nico Weber wrote: > On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith > wrote: > >> On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: >> > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith >> wrote: >> >> >> >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber >> wrote: >>

Re: [PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

silvas added a comment. Isn't there a `read` call or something that fails down the road? How can it be silent? http://reviews.llvm.org/D18011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r263076 - [Modules] Add stdatomic to the list of builtin headers

Author: benlangmuir Date: Wed Mar 9 17:31:34 2016 New Revision: 263076 URL: http://llvm.org/viewvc/llvm-project?rev=263076&view=rev Log: [Modules] Add stdatomic to the list of builtin headers Since it's provided by the compiler. This allows a system module map file to declare a module for it. N

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

rjmccall added inline comments. Comment at: lib/Sema/SemaStmt.cpp:1448 @@ +1447,3 @@ +if (auto *OVE = dyn_cast(S)) { + // Look pass OVE for Decl. + if (Expr *E = OVE->getSourceExpr()) "Look past the OVE into the expression it binds." ===

[PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address; Undefined" on OSX

joker.eph created this revision. joker.eph added a reviewer: beanz. joker.eph added a subscriber: cfe-commits. joker.eph set the repository for this revision to rL LLVM. It seems some cases were missing to the configuration. Repository: rL LLVM http://reviews.llvm.org/D18014 Files: lib/CMak

Re: r263051 - [PPC] FE support for generating VSX [negated] absolute value instructions

On Wed, Mar 9, 2016 at 11:33 AM Kit Barton via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kbarton > Date: Wed Mar 9 13:28:31 2016 > New Revision: 263051 > > URL: http://llvm.org/viewvc/llvm-project?rev=263051&view=rev > Log: > [PPC] FE support for generating VSX [negated] absolute

Re: r263048 - ARM & AArch64: convert asm tests to LLVM IR and restrict optimizations.

On Wed, Mar 9, 2016 at 1:32 PM Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 9 March 2016 at 13:20, David Blaikie via cfe-commits > wrote: > > If we are touching these tests at all, as a cleanup, why aren't we > adjusting > > them to not pass through the llvm optimizers/

Re: r263048 - ARM & AArch64: convert asm tests to LLVM IR and restrict optimizations.

On 9 March 2016 at 13:20, David Blaikie via cfe-commits wrote: > If we are touching these tests at all, as a cleanup, why aren't we adjusting > them to not pass through the llvm optimizers/code generators at all? > Generally we are pretty clear that any test in Clang looking at llvms > generated a

r263060 - [modules] Simplify code logic. NFC.

Author: davide Date: Wed Mar 9 15:09:51 2016 New Revision: 263060 URL: http://llvm.org/viewvc/llvm-project?rev=263060&view=rev Log: [modules] Simplify code logic. NFC. Modified: cfe/trunk/lib/Basic/Module.cpp Modified: cfe/trunk/lib/Basic/Module.cpp URL: http://llvm.org/viewvc/llvm-project

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli updated this revision to Diff 50187. carlo.bertolli added a comment. [OPENMP] This new version of the patch uses the inlining machinery of CGOpenMPRuntime.cpp instead of just dumping the teams body statement using EmitStmt. Repository: rL LLVM http://reviews.llvm.org/D17963

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Addressed comment in new version of diff. Repository: rL LLVM http://reviews.llvm.org/D17963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

steven_wu updated this revision to Diff 50186. steven_wu added a comment. Update the patch to address John's feedback. We shouldn't even checking ObjCSubscript but looking at the Semantics for PseudoObjectExpr only. http://reviews.llvm.org/D17627 Files: lib/Sema/SemaStmt.cpp test/SemaObjC/w

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

bob.wilson added a comment. > I do like the explicit nature of this approach, but I'm worried about it > being too novel. For instance, would this compel GCC to implement a similar > parsing feature since they also support the deprecated attribute, that sort > of thing. Also, it feels like a bi

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

Alexander_Droste added a comment. Thanks for pointing this out. What's actually the best way to test the function? If I test this function with an integration test, I need to rely on a checker which uses the function to output diagnostics. Is it possible to test this with a unit test? My assump

Re: [PATCH] D17999: Rewrite ARM & AArch64 tests to check LLVM IR rather than assembly

On 9 March 2016 at 11:12, Sanjay Patel wrote: > Nothing to do with the patch itself (although it looks great and thanks!) - > is the CHECK line generator script available somewhere? I'd love to be able > to use that. It's horribly hacky and fragile, but what I've got should be attached here. Pa

Re: [PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

davide updated this revision to Diff 50181. davide added a comment. Typo. http://reviews.llvm.org/D18011 Files: include/clang/Basic/DiagnosticFrontendKinds.td lib/Frontend/FrontendActions.cpp test/Modules/Inputs/insufficient-privileges.modulemap Index: lib/Frontend/FrontendActions.cpp ==

[PATCH] D18011: [modules] Diagnose insufficient privileges when trying to load the modulemap

davide created this revision. davide added reviewers: rsmith, silvas, doug.gregor. davide added a subscriber: cfe-commits. I stumbled upon this yesterday. Without this patch in palce, the module map load is silently ignored, and this might cause subtle breakages. http://reviews.llvm.org/D18011

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

ariccio added a comment. Oh, and by the way, what's the policy on using `enum class`es instead of C style enums? I bet the compiler would have fewer false positives with strongly typed enums? http://reviews.llvm.org/D17983 ___ cfe-commits mailing

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

ariccio added a comment. In http://reviews.llvm.org/D17983#370717, @dblaikie wrote: > Initializations we never expect to use (eg because we have a covered switch > that initializes in all cases, or some slightly complex control flow the > compiler can't see through) hinder our ability to find u

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

aaron.ballman added a comment. In http://reviews.llvm.org/D17865#370912, @manmanren wrote: > Hi Aaron, > > Thanks for the review! > > > I like the idea of a potential fixit being provided by the attribute, but I > > do not agree with the way the feature is surfaced in this patch. > > > > > > Fo

r263052 - NFC fix documentation build by rL263015

Author: dpolukhin Date: Wed Mar 9 13:39:16 2016 New Revision: 263052 URL: http://llvm.org/viewvc/llvm-project?rev=263052&view=rev Log: NFC fix documentation build by rL263015 This time I hope it will fix the build for real. Modified: cfe/trunk/docs/ItaniumMangleAbiTags.rst cfe/trunk/doc

Re: [PATCH] D17816: [PPC] FE support for generating VSX [negated] absolute value instructions

kbarton closed this revision. kbarton added a comment. Committed r263051 http://reviews.llvm.org/D17816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263051 - [PPC] FE support for generating VSX [negated] absolute value instructions

Author: kbarton Date: Wed Mar 9 13:28:31 2016 New Revision: 263051 URL: http://llvm.org/viewvc/llvm-project?rev=263051&view=rev Log: [PPC] FE support for generating VSX [negated] absolute value instructions Includes new built-in, conversion of built-in to target-independent intrinsic and update

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

rjmccall added a comment. The right fix is probably at the PseudoObjectExpr level; you should probably be looking at the semantic expressions instead of the syntactic. http://reviews.llvm.org/D17627 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rjmccall added a comment. Well, no, we can do it under a different flag and just ensure that -fno-delete-null-pointer-checks *also* has the effect of disabling the optimization. But you are not inspiring to disagree with Chandler about whether this optimization should be enabled by default.

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rjmccall added a comment. Er, sorry. You are not inspiring *me* to disagree with Chandler. http://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17999: Rewrite ARM & AArch64 tests to check LLVM IR rather than assembly

spatel added a subscriber: spatel. spatel added a comment. Nothing to do with the patch itself (although it looks great and thanks!) - is the CHECK line generator script available somewhere? I'd love to be able to use that. http://reviews.llvm.org/D17999

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

manmanren added a comment. Hi Aaron, Thanks for the review! > I like the idea of a potential fixit being provided by the attribute, but I > do not agree with the way the feature is surfaced in this patch. > > For the GNU-style attribute, the named argument functionality is sufficiently > no

Re: [PATCH] D17999: Rewrite ARM & AArch64 tests to check LLVM IR rather than assembly

t.p.northover closed this revision. t.p.northover added a comment. Thanks Eric. Committed as r263048. http://reviews.llvm.org/D17999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263048 - ARM & AArch64: convert asm tests to LLVM IR and restrict optimizations.

Modified: cfe/trunk/test/CodeGen/builtins-arm-exclusive.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins-arm-exclusive.c?rev=263048&r1=263047&r2=263048&view=diff == --- cfe/trunk/test/CodeGen/buil

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; yaxunl wrote: > aaron.ballman wrote: > > Since the attribute is ignored by clang, you should inherit

Re: [PATCH] D17999: Rewrite ARM & AArch64 tests to check LLVM IR rather than assembly

echristo added a subscriber: echristo. echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. This is a compromise I can live with :) Thanks for doing this Tim. -eric http://reviews.llvm.org/D17999 ___

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

bkramer added a comment. GCC 6 is already doing this and people are already annotating their builds with -fno-delete-null-pointer-checks. Putting it under a different flag will break compatibility there :( http://reviews.llvm.org/D17993 ___ cfe-co

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

yaxunl marked 7 inline comments as done. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; aaron.ballman wrote: > Since the attribute is ignored by clang, you should inherit from IgnoredA

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; Since the attribute is ignored by clang,

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

sfantao added a comment. Hi Kelvin, Thanks for working on this! I have some minor comments inlined. Comment at: lib/Sema/SemaOpenMP.cpp:9392 @@ +9391,3 @@ + SemaRef.Diag(ELoc, diag::err_omp_map_shared_storage) << ERange; +else + SemaRef.Dia

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

Anastasia added inline comments. Comment at: test/SemaOpenCL/nosvm.cl:9 @@ +8,3 @@ +#else +void f(__attribute__((nosvm)) int* a); // expected-warning {{'nosvm' attribute ignored}} +#endif yaxunl wrote: > Anastasia wrote: > > yaxunl wrote: > > > yaxunl wrote: > >

[libcxx] r263043 - Update status to mark 2579 complete

Author: marshall Date: Wed Mar 9 12:09:07 2016 New Revision: 263043 URL: http://llvm.org/viewvc/llvm-project?rev=263043&view=rev Log: Update status to mark 2579 complete Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/ll

[libcxx] r263042 - Implement LWG#2579: Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign

Author: marshall Date: Wed Mar 9 12:08:29 2016 New Revision: 263042 URL: http://llvm.org/viewvc/llvm-project?rev=263042&view=rev Log: Implement LWG#2579: Inconsistency wrt Allocators in basic_string assignment vs. basic_string::assign Modified: libcxx/trunk/include/string libcxx/trunk/

r263041 - Use an explicit instantiation to work around delayed template parsing for MSVC-built bots.

Author: aaronballman Date: Wed Mar 9 12:07:17 2016 New Revision: 263041 URL: http://llvm.org/viewvc/llvm-project?rev=263041&view=rev Log: Use an explicit instantiation to work around delayed template parsing for MSVC-built bots. Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp

r263038 - AArch64: remove a couple more tests already covered elsewhere.

Author: tnorthover Date: Wed Mar 9 12:00:06 2016 New Revision: 263038 URL: http://llvm.org/viewvc/llvm-project?rev=263038&view=rev Log: AArch64: remove a couple more tests already covered elsewhere. Removed: cfe/trunk/test/CodeGen/arm64-scalar-test.c cfe/trunk/test/CodeGen/arm64-vrsqrt.c

Re: [PATCH] D17627: Fix false positives for for-loop-analysis warning

steven_wu added a comment. ping http://reviews.llvm.org/D17627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. ping http://reviews.llvm.org/D17392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r263036 - Implement LWG#2583: There is no way to supply an allocator for basic_string(str, pos)

Author: marshall Date: Wed Mar 9 11:51:43 2016 New Revision: 263036 URL: http://llvm.org/viewvc/llvm-project?rev=263036&view=rev Log: Implement LWG#2583: There is no way to supply an allocator for basic_string(str, pos) Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strings

r263034 - Speculative fix for this test case (the test doesn't run on my typical build environment).

Author: aaronballman Date: Wed Mar 9 11:34:16 2016 New Revision: 263034 URL: http://llvm.org/viewvc/llvm-project?rev=263034&view=rev Log: Speculative fix for this test case (the test doesn't run on my typical build environment). Modified: cfe/trunk/test/Misc/ast-dump-color.cpp Modified: cf

r263031 - ReleaseNotes: update 'you may prefer' link to 3.8

Author: hans Date: Wed Mar 9 11:26:46 2016 New Revision: 263031 URL: http://llvm.org/viewvc/llvm-project?rev=263031&view=rev Log: ReleaseNotes: update 'you may prefer' link to 3.8 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewv

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

chandlerc added a subscriber: chandlerc. chandlerc added a comment. If we're not going to fully implement "fdelete-null-pointer-checks" we shouldn't claim to... I'm really worried about us accepting that flag and not actually honoring it. However, I *do* think this should be guarded by a flag,

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rjmccall added a comment. Hal, I think you're talking about a slightly different thing. This patch is adding an assumption that C++ this pointers are non-null, but only when -fno-delete-null-pointer-checks is not passed. The flag is therefore at least somewhat functional. (I would argue that

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

zaks.anna added a comment. I thunk the closest we have is region-store* tests, which is not quite the same. Feel free to add a new test. http://reviews.llvm.org/D16044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[libcxx] r263029 - Add some more tests for the containers type requirements

Author: marshall Date: Wed Mar 9 11:19:07 2016 New Revision: 263029 URL: http://llvm.org/viewvc/llvm-project?rev=263029&view=rev Log: Add some more tests for the containers type requirements Modified: libcxx/trunk/test/std/containers/sequences/array/types.pass.cpp libcxx/trunk/test/std/c

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r263027. http://reviews.llvm.org/D17446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263027 - Adding new AST matchers for: addrLabelExpr, atomicExpr, binaryConditionalOperator, designatedInitExpr, designatorCountIs, hasSyntacticForm, implicitValueInitExpr, labelDecl, opaqueValueExpr,

Author: aaronballman Date: Wed Mar 9 11:11:51 2016 New Revision: 263027 URL: http://llvm.org/viewvc/llvm-project?rev=263027&view=rev Log: Adding new AST matchers for: addrLabelExpr, atomicExpr, binaryConditionalOperator, designatedInitExpr, designatorCountIs, hasSyntacticForm, implicitValueInit

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I like the idea of a potential fixit being provided by the attribute, but I do not agree with the way the feature is surfaced in this patch. For the GNU-style attribute,

r263025 - Implement support for [[maybe_unused]] in C++1z that is based off existing support for unused, and treat it as an extension pre-C++1z. This also means extending the existing unused attribute

Author: aaronballman Date: Wed Mar 9 10:48:08 2016 New Revision: 263025 URL: http://llvm.org/viewvc/llvm-project?rev=263025&view=rev Log: Implement support for [[maybe_unused]] in C++1z that is based off existing support for unused, and treat it as an extension pre-C++1z. This also means extend

Re: [PATCH] D17453: [Driver] Enable --rtlib option for MSVC target

rengolin added a comment. Hi, The error is very sensible, but I'm not sure why you're adding compiler-rt in the second change. Why is that necessary, and where are the tests for it. Thanks! --renato http://reviews.llvm.org/D17453 ___ cfe-commits

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Wed, Mar 9, 2016 at 8:23 AM, David Blaikie wrote: > > On Mar 9, 2016 8:18 AM, "Teresa Johnson" wrote: > > > > > > > > On Wed, Mar 9, 2016 at 8:13 AM, David Blaikie > wrote: > >> > >> > >> On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" < > llvm-comm...@lists.llvm.org> wrote: > >> >

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Mar 9, 2016 8:18 AM, "Teresa Johnson" wrote: > > > > On Wed, Mar 9, 2016 at 8:13 AM, David Blaikie wrote: >> >> >> On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" < llvm-comm...@lists.llvm.org> wrote: >> > >> > tejohnson added a subscriber: tejohnson. >> > tejohnson added a comment.

r263023 - NFC fix documentation build by rL263015

Author: dpolukhin Date: Wed Mar 9 10:19:04 2016 New Revision: 263023 URL: http://llvm.org/viewvc/llvm-project?rev=263023&view=rev Log: NFC fix documentation build by rL263015 Modified: cfe/trunk/docs/ItaniumMangleAbiTags.rst Modified: cfe/trunk/docs/ItaniumMangleAbiTags.rst URL: http://llv

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Wed, Mar 9, 2016 at 8:13 AM, David Blaikie wrote: > > On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" < > llvm-comm...@lists.llvm.org> wrote: > > > > tejohnson added a subscriber: tejohnson. > > tejohnson added a comment. > > > > Thanks for doing this! > > > > I will fix these 3, whi

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" < llvm-comm...@lists.llvm.org> wrote: > > tejohnson added a subscriber: tejohnson. > tejohnson added a comment. > > Thanks for doing this! > > I will fix these 3, which one of my changes would have provoked. It is a benign case since we do h

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

manmanren added a comment. Ping http://reviews.llvm.org/D17865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

tejohnson added a subscriber: tejohnson. tejohnson added a comment. Thanks for doing this! I will fix these 3, which one of my changes would have provoked. It is a benign case since we do have an assert at the use site checking the same condition that the inits are guarded with, but there is no

Re: [PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

hfinkel added a subscriber: hfinkel. hfinkel added a comment. I'm *really* nervous about doing anything with -f(no-)delete-null-pointer-checks that makes it look like we support this feature without actually supporting it in the backend. In computePointerICmp in InstructionSimplify.cpp, we hav

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin removed rL LLVM as the repository for this revision. a.sidorin updated this revision to Diff 50140. a.sidorin added a comment. Stylish fixes. Serge: ASTMatcher review is complete so there should be no more build problems. Could you try again? Also, I'd prefer to add your changes in the

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

arpith-jacob marked 9 inline comments as done. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective &D, +StringRef ParentNa

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

arpith-jacob updated this revision to Diff 50143. arpith-jacob marked 2 inline comments as done. arpith-jacob added a comment. Stylistic changes to address feedback. http://reviews.llvm.org/D17877 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGOpenMPRun

  1   2   >