On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" < llvm-comm...@lists.llvm.org> wrote: > > tejohnson added a subscriber: tejohnson. > tejohnson added a comment. > > Thanks for doing this! > > I will fix these 3, which one of my changes would have provoked. It is a benign case since we do have an assert at the use site checking the same condition that the inits are guarded with, but there is no reason not to 0 init these to avoid the bogus warning.
The reason not to is that it would silence msan catching the unintentional codepath (eg: if you didn't have the assert there, and they init and use conditions didn't match, msan would tell us - if we add what we believe to be a dead init, then msan no longer helps us here) > > Warning C4701 potentially uninitialized local variable 'FnEntry8BitAbbrev' used LLVMBitWriter c:\llvm\llvm\lib\bitcode\writer\bitcodewriter.cpp 2353 > Warning C4701 potentially uninitialized local variable 'FnEntry7BitAbbrev' used LLVMBitWriter c:\llvm\llvm\lib\bitcode\writer\bitcodewriter.cpp 2357 > Warning C4701 potentially uninitialized local variable 'FnEntry6BitAbbrev' used LLVMBitWriter c:\llvm\llvm\lib\bitcode\writer\bitcodewriter.cpp 2355 > > > http://reviews.llvm.org/D17983 > > > > _______________________________________________ > llvm-commits mailing list > llvm-comm...@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
