Re: Review Request: Make dbus, knotify and phonon optional

2012-02-19 Thread C. Boemann
g the patch at all. I think we should just use the qt and kde vars. I can't see any reason why we would disable those things if they are supported by upstream. - C. Boemann On Feb. 19, 2012, 4:18 a.m., Sebastian Sauer wrote: > >

Re: Review Request: Add UI to change list level.

2012-02-19 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104022/#review10745 --- Ship it! Ship It! - C. Boemann On Feb. 19, 2012, 12:21 p.m

Re: Some (most?) properties in Style Manager won't take effect until style is re-applied

2012-02-19 Thread C. Boemann
On Sunday 19 February 2012 20:20:03 Elvis Stansvik wrote: > I did some testing of the Style Manager: > > 1) Blank document template > 2) Enter text "This is a paragraph" with paragraph style "Standard" > (the default) > 3) "Format" -> "Style Manager". > 4) Select the "Standard" style and change an

Re: Review Request: Add support for footnote's continuation

2012-02-23 Thread C. Boemann
tArea.cpp <http://git.reviewboard.kde.org/r/104043/#comment8770> i'm not sure the layout logic is strong enough here. plugins/textshape/ReferencesTool.cpp <http://git.reviewboard.kde.org/r/104043/#comment8769> - C. Boemann On Feb. 22, 2012

release plan and request for merge

2012-02-23 Thread C. Boemann
ing a review request, can be done but since we have like moved everything it doesn't make much sense. Best regards C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: release plan and request for merge

2012-02-23 Thread C. Boemann
ble method. It wouldn't compile. > > Pierre > > On Thu, Feb 23, 2012 at 10:27 AM, C. Boemann wrote: > > Hi all > > > > So the minisprint on undo in Words is over and we had success. I'm > > requesting > > merge of our branch but more on that below. >

Review Request: Undo redo framework for text refactored

2012-02-23 Thread C. Boemann
other than that we will just have to wait for a qt fix Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Karbon or Karbon14?

2012-02-23 Thread C. Boemann
On Thursday 23 February 2012 15:40:04 Boudewijn Rempt wrote: > On Thu, 23 Feb 2012, Friedrich W. H. Kossebau wrote: > > Hi, > > > > IIRC the official name of Karbon14 is now (Calligra) Karbon. But in the > > sources (including the .desktop files) the name is still Karbon14. > > Something inside me

Re: Karbon or Karbon14?

2012-02-23 Thread C. Boemann
On Thursday 23 February 2012 15:55:46 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 23. Februar 2012, 15:44:08 schrieb C. Boemann: > > On Thursday 23 February 2012 15:40:04 Boudewijn Rempt wrote: > > > On Thu, 23 Feb 2012, Friedrich W. H. Kossebau wrote: > > > >

Re: Review Request: Undo redo framework for text refactored

2012-02-24 Thread C. Boemann
n. But sure. - C. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104047/#review10863 --- On Feb. 23, 2012, 12:10 p.m., C. Boemann wrote: > >

Re: release plan and request for merge

2012-02-24 Thread C. Boemann
On Thursday 23 February 2012 11:57:56 Elvis Stansvik wrote: > 2012/2/23 C. Boemann : > > Hi all > > > > So the minisprint on undo in Words is over and we had success. I'm > > requesting merge of our branch but more on that below. > > > > Assuming we me

Re: Review Request: Undo redo framework for text refactored

2012-02-24 Thread C. Boemann
last workaround in our minds, but other than that we will just have to wait for a qt fix Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Update block formats on paragraph style change

2012-02-24 Thread C. Boemann
t and needs the style below to work correctly in all cases. The direct formatting on top however we assume is more simple libs/kotext/styles/ChangeFollower.cpp <http://git.reviewboard.kde.org/r/104032/#comment8808> same here - C. Boemann On Feb. 20, 2012, 4:27 p.m., Elv

Re: Review Request: Update block formats on paragraph style change

2012-02-24 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104032/#review10871 --- Ship it! Ship It! - C. Boemann On Feb. 24, 2012, 2:22 p.m

Re: release plan and request for merge

2012-02-24 Thread C. Boemann
On Friday 24 February 2012 18:08:37 Cyrille Berger Skott wrote: > Here is my suggestion: > > * merge the branch ASAP, like this week-end > * tag RC/branch on Friday 2nd > > That way it give use a small week to fully tests the changes before the RC. It has my support __

Re: Review Request: load and save draw:id and text:id also as xml:id

2012-02-25 Thread C. Boemann
/KoElementReference.h <http://git.reviewboard.kde.org/r/104074/#comment8813> probably 2012 as well libs/odf/KoElementReference.cpp <http://git.reviewboard.kde.org/r/104074/#comment8814> no destructor? and refcount? - C. Boemann On Feb. 25, 2012, 9:51 a.m., Boudewijn

Re: Review Request: load and save draw:id and text:id also as xml:id

2012-02-25 Thread C. Boemann
everything is working - C. Boemann On Feb. 25, 2012, 3:12 p.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Undo redo framework for text refactored

2012-02-25 Thread C. Boemann
much pierrest's work as my own. And since I have not found any problems with it please object if you think you would have more insight and be able to do a quality review - C. Boemann On Feb. 24, 2012, 12:32 p.m., C. Boemann wrote: > >

Re: Review Request: load and save draw:id and text:id also as xml:id

2012-02-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/#review10897 --- loading an odp with animation is broken in this branch :( - C

Re: overflow-behavior with text boxes: clip does not clip?

2012-02-26 Thread C. Boemann
On Saturday 25 February 2012 13:34:07 Friedrich W. H. Kossebau wrote: > Hi, > > I expected "style:overflow-behavior" set to "clip" with no minimum size set > to result in text which does not fit in a draw:text-box to be clipped, > i.e. not shown. But instead text is also rendered outside of the te

Re: Information about GSOC 2012

2012-02-26 Thread C. Boemann
On Sunday 26 February 2012 18:35:15 shailesh borkar wrote: > Sir, I want to work for your project ideas as a student of GSOC 2012. > I have seached project ideas and selected some ones which i have > interest to work on. but i dont know how to contact the mentors of > project. > ___

Re: Review Request: Maintain text selection through undo/redo

2012-02-27 Thread C. Boemann
lly correct in your code but hardly intentional) - C. Boemann On Feb. 27, 2012, 5:03 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.r

Re: Review Request: load and save draw:id and text:id also as xml:id

2012-02-29 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/#review11005 --- Partial ship-it from my side, up to you zagge? - C. Boemann

Re: Review Request: BUG 295148: Fix increase indentation

2012-03-03 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104144/#review11108 --- Ship it! Ship It! - C. Boemann On March 3, 2012, 12:09 p.m

Re: Typo in calligra/TextShape.po

2012-03-05 Thread C. Boemann
On Monday 05 March 2012 17:05:46 Yuri Chornoivan wrote: > написане Mon, 05 Mar 2012 15:57:02 +0200, Kristóf Kiszel > > : > > Hello, > > > > I found a typo in the mention file. > > > > „Configure bibiliography” > > (dialogs/SimpleCitationBibliographyWidget.ui:55) > > > > Best regards, > > Kristó

Re: Chaining textboxes, enhancing OpenDocument formats...

2012-03-05 Thread C. Boemann
On Monday 05 March 2012 18:46:34 Thorsten Zachmann wrote: > On Monday, March 05, 2012 10:05:22 Friedrich W. H. Kossebau wrote: > > Am Montag, 5. März 2012, 04:58:57 schrieb Thorsten Zachmann: > > > Hello Friedrich, > > > > > > > is there really no support for chaining textboxes in OpenDocument, so

Re: Review Request: custom bibliography and bibliography configurations

2012-03-05 Thread C. Boemann
liographyDialog.cpp <http://git.reviewboard.kde.org/r/104164/#comment8982> no spaces please plugins/textshape/dialogs/InsertBibliographyDialog.cpp <http://git.reviewboard.kde.org/r/104164/#comment8983> ' ' is proba

Re: Calligra sprint in May?

2012-03-07 Thread C. Boemann
On Wednesday 07 March 2012 08:24:19 Inge Wallin wrote: > The e.V board has a new policy for sprints that means that you have to > apply for a budget the quarter before you plan to give a sprint. This > means that if we want to have a sprint in Q2, we need to apply for it > before end of March. > >

Re: Using the Tables brand/trade name for a spreadsheet application

2012-03-07 Thread C. Boemann
On Thursday 08 March 2012 07:38:39 Mani N C wrote: > On Thu, Mar 8, 2012 at 10:29 AM, Thorsten Zachmann wrote: > > On Thursday, March 08, 2012 05:16:11 Marijn Kruisselbrink wrote: > > > On Thursday, March 08, 2012 04:36:25 AM Sebastian Sauer wrote: > > > > On 03/07/2012 06:10 PM, Algot Runeman wro

Re: RC2

2012-03-08 Thread C. Boemann
On Thursday 08 March 2012 19:15:03 Marijn Kruisselbrink wrote: > So I have to finish renaming calligra tables to calligra sheets before > sunday then? > > Marijn > > On Thursday, March 08, 2012 09:33:31 AM Cyrille Berger wrote: > > Hi, > > > > since there was some data loss spotted by Thorsten,

release issue

2012-03-09 Thread C. Boemann
Hi There is a bug in qt4.8 that makes textediting crash. And it's not really practical to workaround it in Calligra. More specifically qt4.8 crashes whenever you eg cursor->setPosition or editing that moves the cursor position. Unless you wrap those call inside begin/endEditBlock pairs. I've d

Fwd: [calligra] /: Make paragraph and character dialogs actually work, and use the new visitor

2012-03-09 Thread C. Boemann
Could someone please review and take it for a spin so i can backport it -- Forwarded Message -- Subject: [calligra] /: Make paragraph and character dialogs actually work, and use the new visitor Date: Friday 09 March 2012 From: "C. Boemann" To: kde-comm...@kd

Re: release issue

2012-03-09 Thread C. Boemann
On Friday 09 March 2012 23:25:10 Jaroslaw Staniek wrote: > On 9 March 2012 16:48, C. Boemann wrote: > > Hi > > > > There is a bug in qt4.8 that makes textediting crash. And it's not really > > practical to workaround it in Calligra. > > > > More speci

Re: Review Request: Reduce code duplication in KoTextDocumentLayout::doLayout() a bit

2012-03-10 Thread C. Boemann
/textlayout/KoTextDocumentLayout.cpp <http://git.reviewboard.kde.org/r/104218/#comment9032> look closely and you will see you have introduced a bug here :) - C. Boemann On March 11, 2012, 1:19 a.m., Elvis Stansvik wrote: > > -

Re: [calligra] /: Make paragraph and character dialogs actually work, and use the new visitor

2012-03-11 Thread C. Boemann
On Sunday 11 March 2012 17:02:22 Elvis Stansvik wrote: > 2012/3/11 Inge Wallin : > > On Saturday, March 10, 2012 10:52:04 Elvis Stansvik wrote: > >> 2012/3/9 C. Boemann : > >> > Could someone please review and take it for a spin so i can backport > >> >

Re: Project Proposal for Calligra

2012-03-15 Thread C. Boemann
On Wednesday 14 March 2012 12:53:16 jigar raisinghani wrote: > Hi >Here is a project proposal which i would like to implement > in Calligra Tables and Calligra Words. > http://dl.dropbox.com/u/49042576/Project%20Proposal_JIGAR.pdf > > Cheers, > Jigar Raisinghani Hi Other developer

Re: Review Request: KoXmlWriter - don't add control codes not accepted in XML 1.0 documents.

2012-03-15 Thread C. Boemann
gt; > (Updated March 15, 2012, 3:11 p.m.) > > > Review request for Calligra, Thorsten Zachmann and C. Boemann. > > > Description > --- > > We already skip those codes in the addTextSpan function but not in the > escapeForXML function called by addTextNo

Re: Autocorrection files

2012-03-16 Thread C. Boemann
On Friday 16 March 2012 17:52:45 Yuri Chornoivan wrote: > Hi! > > I was running in some troubles trying to prepare Ukrainian autocorrection > file for Calligra. > > 1. Do these files still used by Words? > > 2. CMakeLists.txt (e.g. for German [1]) install autocorrection files into > koffice/auto

Re: z-index absolute or relative to containing group?

2012-03-16 Thread C. Boemann
On Friday 16 March 2012 23:19:53 Friedrich W. H. Kossebau wrote: > Hi, > > see $subject, is the z-index of items absolute or relative to the > containing group? > > I could not find anything relevant on the webs. Has this been discussed > before? If not, were could this be discussed? > > All I f

Re: Autocorrection files

2012-03-18 Thread C. Boemann
On Sunday 18 March 2012 13:08:35 Yuri Chornoivan wrote: > > On Friday 16 March 2012 17:52:45 Yuri Chornoivan wrote: > > > Hi! > > > > > > I was running in some troubles trying to prepare Ukrainian > > > autocorrection file for Calligra. > > > > > > 1. Do these files still used by Words? > > > >

Re: Review Request: Improve the layout of KoPageLayoutWidget and KWDocumentColumns, also add margins to print option pages

2012-03-22 Thread C. Boemann
backport too - C. Boemann On March 22, 2012, 11:42 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: [calligra] libs/kotext/opendocument: Save autostyle in the correct file.

2012-03-24 Thread C. Boemann
looks fine to me On Saturday 24 March 2012 07:12:09 Thorsten Zachmann wrote: > Git commit c26b92c959324c9b5703255a5ee65b99bf2a82f4 by Thorsten Zachmann. > Committed on 24/03/2012 at 06:32. > Pushed by zachmann into branch 'master'. > > Save autostyle in the correct file. > > When KoShapeSavingCo

Re: [calligra] libs/kotext/styles: Correctly roundtrip use-window-color.

2012-03-24 Thread C. Boemann
ok to backport On Saturday 24 March 2012 07:12:09 Thorsten Zachmann wrote: > Git commit 10128edd6776b25e493ccd919792b6877cdca52d by Thorsten Zachmann. > Committed on 24/03/2012 at 06:51. > Pushed by zachmann into branch 'master'. > > Correctly roundtrip use-window-color. > > Before the patch whe

Re: [calligra] libs/kotext/styles: Don't remove to much on removeDuplicates.

2012-03-24 Thread C. Boemann
Although i think odf is stupid to require this, I do agree that this is the way to implement it, so okay to backport On Saturday 24 March 2012 07:12:09 Thorsten Zachmann wrote: > Git commit a5ee384ae82995461d89fe623c714405f8948e00 by Thorsten Zachmann. > Committed on 24/03/2012 at 07:01. > Pushed

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11847 --- Ship it! Ship It! - C. Boemann On March 25, 2012, 11:16

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11848 --- porting too - C. Boemann On March 25, 2012, 11:16 p.m

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread C. Boemann
may be ok, but i'll have to test it first - C. Boemann On March 25, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread C. Boemann
line. - C. Boemann On March 25, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: have KoConnectionShapeConfigWidget use QFormLayout instead of QGridLayout

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104410/#review11852 --- Ship it! ok to port - C. Boemann On March 25, 2012, 11:32

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104409/#review11857 --- i don't care shadow+shape or style just choose one

Re: [calligra] libs/kopageapp: Don't show pageX as nam of the page

2012-03-25 Thread C. Boemann
Hmm isn't loading the wrong time to fix this. Shouldn't it be done on save or LO and friends will show it wrong to? On Sunday 25 March 2012 07:32:14 Thorsten Zachmann wrote: > Git commit 4deb1cab33459e7353abb68ccb01dd0b56f4754c by Thorsten Zachmann. > Committed on 25/03/2012 at 07:29. > Pushed by

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-26 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11872 --- Ship it! - C. Boemann On March 25, 2012, 11:16 p.m

Re: Review Request: right-align all labels in the document info dialog

2012-03-26 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104416/#review11887 --- Ship it! ok to port too - C. Boemann On March 26, 2012, 5

Re: Words filter compiler error with GCC 4.7

2012-03-26 Thread C. Boemann
Well i'm not going to maintain the filter so dropping is fine with me On Monday 26 March 2012 13:23:43 Boudewijn Rempt wrote: > On Mon, 26 Mar 2012, Yue Liu wrote: > > Hancom Office now supports odf. > > http://www.hancom.com/en/product/product2010.jsp > > Maybe we can drop this filter then? It's

Re: [calligra] libs/kopageapp: Don't show pageX as nam of the page

2012-03-26 Thread C. Boemann
On Monday 26 March 2012 05:53:59 Thorsten Zachmann wrote: > Hello, > > On Sunday, March 25, 2012 22:01:16 C. Boemann wrote: > > Hmm isn't loading the wrong time to fix this. Shouldn't it be done on > > save or LO and friends will show it wrong to? > > The p

Re: BoF at Akademy 2012?

2012-03-27 Thread C. Boemann
On Tuesday 27 March 2012 11:34:47 Boudewijn Rempt wrote: > On Tue, 27 Mar 2012, Thomas Pfeiffer wrote: > > Hi all, > > since I'll be at Akademy the whole week, I was wondering if you are > > planning to do a Calligra BoF there. Or if not, who will be there (since > > the Calligra team tends a bit t

Re: [calligra] /: Move insert pagebreak handling from Words to texttool

2012-03-27 Thread C. Boemann
Okay to backport to 2.4 ? On Tuesday 27 March 2012 20:00:37 C. Boemann wrote: > Git commit 4e778319817bec12a4b53877f5a2b42ed0448131 by C. Boemann. > Committed on 27/03/2012 at 19:36. > Pushed by boemann into branch 'master'. > > Move insert pagebreak handling from Wor

Re: Review Request: Rename class KoLineBorder -> KoShapeStroke

2012-03-27 Thread C. Boemann
de.org/r/104421/#comment9444> i would have taken the oppotunity to follow the hacking style here.. - C. Boemann On March 27, 2012, 12:53 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-ma

Re: [calligra] /: Move insert pagebreak handling from Words to texttool

2012-03-28 Thread C. Boemann
On Wednesday 28 March 2012 06:14:11 Thorsten Zachmann wrote: > Hello, > > On Tuesday, March 27, 2012 20:04:06 C. Boemann wrote: > > Okay to backport to 2.4 ? > > > > On Tuesday 27 March 2012 20:00:37 C. Boemann wrote: > > > Git commit 4e778319817bec12a4

Re: is calligra 2.4 good to go ?

2012-04-05 Thread C. Boemann
On Thursday 05 April 2012 18:34:55 Cyrille Berger Skott wrote: > Hi, > > Does anyone has any objection to the tagging of 2.4.0 tomorrow ? Well, No but I'll commit some fixes tonight ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.

Re: is calligra 2.4 good to go ?

2012-04-05 Thread C. Boemann
On Thursday 05 April 2012 19:20:05 Cyrille Berger Skott wrote: > On Thursday 05 Apr 2012, C. Boemann wrote: > > On Thursday 05 April 2012 18:34:55 Cyrille Berger Skott wrote: > > > Hi, > > > > > > Does anyone has any objection to the tagging of 2.4.0 tomorrow

commits to master

2012-04-05 Thread C. Boemann
Hi In Berlin last year we agreed that we would move to a 4 month release cycle and in order to do that we promised ourselves we would keep master in a releasable state only merging things when it was ready to be released. I don't think we have taken that to heart yet. Master is currently broken

Re: commits to master

2012-04-07 Thread C. Boemann
On Saturday 07 April 2012 10:54:05 Boudewijn Rempt wrote: > On Friday 06 April 2012 Apr, C. Boemann wrote: > > Hi > > > > In Berlin last year we agreed that we would move to a 4 month release > > cycle and in order to do that we promised ourselves we would keep maste

Re: How does the SpecialSpacer system work?

2012-04-07 Thread C. Boemann
On Saturday 07 April 2012 15:28:20 Friedrich W. H. Kossebau wrote: > Am Samstag, 7. April 2012, 15:10:02 schrieben Sie: > > On Saturday 07 April 2012 14:56:01 you wrote: > > > Hi, > > > > > > I fear some of my UI-related commits have ignored the concept of the > > > SpecialSpacer system, as I simp

Re: Proposal for new system (was: Re: How does the SpecialSpacer system work?)

2012-04-07 Thread C. Boemann
On Saturday 07 April 2012 16:00:01 Friedrich W. H. Kossebau wrote: > So currently all optionwidgets need to add a SpecialSpacer to signal that > there is no UI gain in letting them stretch if put together with others. > > I wonder if this system could perhaps be reversed. > E.g. by that all those

Re: Proposal for new system (was: Re: How does the SpecialSpacer system work?)

2012-04-07 Thread C. Boemann
On Saturday 07 April 2012 16:00:01 Friedrich W. H. Kossebau wrote: > So currently all optionwidgets need to add a SpecialSpacer to signal that > there is no UI gain in letting them stretch if put together with others. > > I wonder if this system could perhaps be reversed. > E.g. by that all those

calligra mentors irc meeting in 23 hours

2012-04-07 Thread C. Boemann
Hi Google wants us to do some initial project counting, so we need to meet up on irc tomorrow sunday at 20:00 cet summertime I hope all potential mentors will make it then query me on irc just before to get the name of the irc channel ___ calligra-de

Re: removing the minimize option for dockers

2012-04-08 Thread C. Boemann
On Sunday 08 April 2012 15:28:26 Boudewijn Rempt wrote: > Hi, > > I'm wondering whether we shouldn't just remove the minimimze option in the > titlebar of our dockers. I've never seen a user actually use it, and > there are weird bugs like > > https://bugs.kde.org/show_bug.cgi?id=297327&list_id=4

Re: Review Request: No longer hijack the escape key to switch to the interaction tool

2012-04-09 Thread C. Boemann
the canvas looses focus), and to me it sounds more like you don't accept the keypress event when you consume it That said I wouldn't mind removing this shortcut - C. Boemann On April 9, 2012, 1:31 p.m., Boudewijn R

calligracommon online coding sprint

2012-04-12 Thread C. Boemann
Hi I was thinking that since calligracommon bugs normally fall outside the itches each of us like to scratch the number of bugs in that component will just continue to grow I suggest we organize an online coding sprint where each of us fixes two bugs from that component. If we are 20 hackers

Re: commits to master

2012-04-13 Thread C. Boemann
On Saturday 14 April 2012 08:37:25 Cyrille Berger Skott wrote: > On Thursday 12 Apr 2012, Jaroslaw Staniek wrote: > > Isn't that used as: FEATURE: ? > > I had forgotten about that. What about either: > > FEATURE/BUG: > DESCRIPTION: optional description that overide the title from bug (usefull >

Moving the website to kde infrastructure?

2012-04-14 Thread C. Boemann
Hi Since our website freezes so often Ben Cooksley suggested on irc that we should move our website to KDE infrastructure and that it would only take Cyrille to make a request on b.k.o. So I would suggest we do so and ask Cyrille to make it happen. _

Re: Moving the website to kde infrastructure?

2012-04-14 Thread C. Boemann
On Saturday 14 April 2012 14:13:56 Boudewijn Rempt wrote: > On Saturday 14 April 2012 Apr, Jaroslaw Staniek wrote: > > On 14 April 2012 13:29, C. Boemann wrote: > > > Since our website freezes so often Ben Cooksley suggested on irc that > > > we should move our websit

Re: Review Request: give the measurement numbers in the rulers a 1 pixel margin

2012-04-14 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104602/#review12449 --- Ship it! Looks good! only master though - C. Boemann On

Re: Review Request: give the measurement numbers in the rulers a 1 pixel margin

2012-04-14 Thread C. Boemann
> FYI, in general, after this fix I would like to try another look, partially > inspired by other rulers out there ;) Also that for updates (like on mouse > move) the whole ruler is repainted makes me cry :) Please describe it first before coding ___ cal

Re: calligracommon online coding sprint

2012-04-14 Thread C. Boemann
On Friday 13 April 2012 07:08:03 C. Boemann wrote: > Hi > > I was thinking that since calligracommon bugs normally fall outside the > itches each of us like to scratch the number of bugs in that component > will just continue to grow > > I suggest we organize an online cod

Re: Review Request: double check the mimetype of images

2012-04-15 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104520/#review12466 --- Ship it! Ship It! - C. Boemann On April 9, 2012, 11:20 a.m

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread C. Boemann
problem today? libs/main/KoView.cpp <http://git.reviewboard.kde.org/r/104607/#comment9795> i think this todo should be fixed before pushing - C. Boemann On April 15, 2012, 5 p.m., Friedrich W. H. Kossebau wrote: > > ---

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread C. Boemann
> On April 15, 2012, 5:06 p.m., C. Boemann wrote: > > libs/main/KoView.cpp, line 565 > > <http://git.reviewboard.kde.org/r/104607/diff/1/?file=56699#file56699line565> > > > > i think this todo should be fixed before pushing > > Friedrich W. H. Kosse

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104607/#review12485 --- well i must admit i wasn't think about BIC - C. Boemann

Re: Review Request: Fixed: update the changeUnitActions on a change of the document's unit property

2012-04-15 Thread C. Boemann
> On April 15, 2012, 5:51 p.m., C. Boemann wrote: > > well i must admit i wasn't think about BIC but yes and then we don't need the other list function anymore - C. --- This is an automatically generated e-mail. To

Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
/ Testing --- Tried shadows in all directions with and without blur. in Words (both anchored and non anchored), and in Stage It appears to just work. Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Re: Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
. Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
----------- On April 16, 2012, 2:03 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104615/ > -

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-16 Thread C. Boemann
e.org/r/104626/#comment9835> in the future when editing a line with wrong hacking style please take the oppotunity to fix that too sheets/part/dialogs/PreferenceDialog.cpp <http://git.reviewboard.kde.org/r/104626/#comment9836> Hmmm do we really want pixel listed in Sheets?

Re: Review Request: Fix drawing of shadows for shapes

2012-04-16 Thread C. Boemann
thod KoShape::boundingRect() > > whose documentation says: "This includes the line width and the shadow of > > the shape". Perhaps you are not using that or there is a bug in the > > implementation of it? > > > > C. Boemann wrote: > I think you are talking

Re: Improvement of the styles handling in Calligra

2012-04-16 Thread C. Boemann
On Tuesday 17 April 2012 03:27:39 Inge Wallin wrote: > > If a inherited style overwrites one property of a style e.g. the color a > > new KoShapeBackground would be set in the inherited style. > > That could work, yes. It will be somewhat complex to create the style again > on saving. Here is a p

Re: Review Request: Fix drawing of shadows for shapes

2012-04-17 Thread C. Boemann
thod KoShape::boundingRect() > > whose documentation says: "This includes the line width and the shadow of > > the shape". Perhaps you are not using that or there is a bug in the > > implementation of it? > > > > C. Boemann wrote: > I think you are talking

Re: Improvement of the styles handling in Calligra

2012-04-17 Thread C. Boemann
On Tuesday 17 April 2012 09:05:39 Inge Wallin wrote: > On Tuesday, April 17, 2012 07:09:51 C. Boemann wrote: > > On Tuesday 17 April 2012 03:27:39 Inge Wallin wrote: > > > > If a inherited style overwrites one property of a style e.g. the > > > > color a new KoSh

Re: Review Request: Fix drawing of shadows for shapes

2012-04-17 Thread C. Boemann
/KoShapeShadow.cpp 431ee78 Diff: http://git.reviewboard.kde.org/r/104615/diff/ Testing --- Tried shadows in all directions with and without blur. in Words (both anchored and non anchored), and in Stage It appears to just work. Thanks, C. Boemann

Re: obsolete stuff

2012-04-17 Thread C. Boemann
On Tuesday 17 April 2012 16:57:42 Boudewijn Rempt wrote: > Here's a quick list of stuff in calligra that I am fairly sure is > unmaintained and won't be maintained any time soon. I would propose > to remove all of this and create a wiki page that lists what was > removed in which commit, so people

please in the future push as one commit

2012-04-17 Thread C. Boemann
Please make sure that commits that don't work on their own is _never_ commited on their own If someone checks out in between your commits now Calligra will not build. Which ruins any chance of using bisect. :( ___ calligra-devel mailing list calligra

Re: please in the future push as one commit

2012-04-17 Thread C. Boemann
On Tuesday 17 April 2012 17:42:45 Friedrich W. H. Kossebau wrote: > Am Dienstag, 17. April 2012, 17:34:00 schrieb C. Boemann: > > Please make sure that commits that don't work on their own is _never_ > > commited on their own > > > > If someone checks out in betwee

Re: Please give branch "tuneKoUnitAPI" a quick test with your fav. program

2012-04-17 Thread C. Boemann
On Tuesday 17 April 2012 17:38:14 Friedrich W. H. Kossebau wrote: > Hi, > > my patch to improve the KoUnit API a little and ensure consistent display > of th unit types all over Calligra (see > http://git.reviewboard.kde.org/r/104626/) is a little bit larger and > touches a lot of files all over t

Re: Calligra 2.4 Maintenance schedule

2012-04-19 Thread C. Boemann
On Thursday 19 April 2012 11:26:02 Cyrille Berger wrote: > Hi, > > Based on a once every months (can be adjusted in function of needs or lack > of needs), until the 2.5 > release which should happen in July (schedule to be established soon): > > http://community.kde.org/Calligra/Schedules/2.4/Rel

Re: Please give branch "tuneKoUnitAPI" a quick test with your fav. program

2012-04-19 Thread C. Boemann
On Thursday 19 April 2012 12:13:22 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 19. April 2012, 11:47:55 schrieb Cyrille Berger: > > Compilations errors are rather big issues, don't you think ;) > > Oh, I think those are just overrated ;) > > > By looking > > at > > the code, I would guess so

[calligra/tuneKoUnitAPI] /: Make calligra compile with clang

2012-04-21 Thread C . Boemann
Git commit 2390846d8f0d8d9fd272634602e8e522dc844b91 by C. Boemann, on behalf of Boudewijn Rempt. Committed on 20/04/2012 at 16:35. Pushed by boemann into branch 'tuneKoUnitAPI'. Make calligra compile with clang Clang has some additional restriction. if (foo = bar) becomes if (

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-21 Thread C. Boemann
that it's read - great work ! btw we even got a bug for this behaviour in the mean time - C. Boemann On April 16, 2012, 9:27 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: tune KoUnit API (and have pagelayout dialog and Words' horizontal ruler context menu update to changes of the document's unit type)

2012-04-21 Thread C. Boemann
://bugs.kde.org/show_bug.cgi?id=298510 - C. Boemann On April 16, 2012, 9:27 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

2012-04-21 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104666/#review12753 --- Ship it! I like it. and yes please backport - C. Boemann

<    1   2   3   4   5   6   7   8   9   10   >