> On April 16, 2012, 11:45 p.m., Inge Wallin wrote: > > I may not understand the problem fully, but it seems that not only does it > > paint the shadow too big but it also doesn't take the shadow into account > > when laying out out the text. There is a method KoShape::boundingRect() > > whose documentation says: "This includes the line width and the shadow of > > the shape". Perhaps you are not using that or there is a bug in the > > implementation of it? > > > > C. Boemann wrote: > I think you are talking about something completely different. This is not > about the stext flowing around it. (The text takes the line width and shadow > into account too, however it doesn't use boundingRect as that is not rotated > - anyway i'm drifting off topic here) > > This request was about shadows being drawn completely wrong (clipped) > before and i fixed that. It may very well be that the shadows are too big > still but that is unrelated to what i fixed > > C. Boemann wrote: > Ahh now I understand your comment. You were talking about the screenshots > in the bug. Well yes that used to be a problem which I've corrected quite a > long time ago. The thing I'm fixing here is a newer phenomenon, that you can > see if you load the test document using master. > > Inge Wallin wrote: > Aha, reuse of bug. :) Then I understand.
Don't blame me - the previous testing team was quite fond of not closing bugs before the entire document looked flawless .. - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104615/#review12546 ----------------------------------------------------------- On April 16, 2012, 2:03 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104615/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 2:03 p.m.) > > > Review request for Calligra, Yue Liu, Jan Hambrecht, and Thorsten Zachmann. > > > Description > ------- > > There were a number of problems in the previous code that made shapes be cut > off as can be seen in https://bugs.kde.org/show_bug.cgi?id=273500 > > This fixes that > > > Diffs > ----- > > libs/flake/KoShapeShadow.cpp 431ee78 > > Diff: http://git.reviewboard.kde.org/r/104615/diff/ > > > Testing > ------- > > Tried shadows in all directions with and without blur. in Words (both > anchored and non anchored), and in Stage > > It appears to just work. > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
