Well i'm not going to maintain the filter so dropping is fine with me
On Monday 26 March 2012 13:23:43 Boudewijn Rempt wrote: > On Mon, 26 Mar 2012, Yue Liu wrote: > > Hancom Office now supports odf. > > http://www.hancom.com/en/product/product2010.jsp > > Maybe we can drop this filter then? It's not useful except as a reference > for writing a new filter anyway, since it converts to kwd, not odt. > > > 2012/3/26 Matus Uzak <matus.u...@ixonos.com>: > >> Hi, > >> > >> I recommend to use filters/libmso/pole.cpp in the starwriter and the > >> hancomword filter. I can take care of the starwriter filter. > >> > >> On Sat, Mar 24, 2012 at 3:30 AM, Yue Liu <yue....@mail.com> wrote: > >>> looks like it's okay to rename r with other name. > >>> > >>> 2012/3/24 Christoph Feck <christ...@maxiom.de>: > >>> > Hi, > >>> > > >>> > The calligra master builds fails with GCC 4.7 due to an error in the > >>> > "hancomwords" import filter. > >>> > > >>> > The loop in filters/words/hancomword/pole.cpp:869 reads: > >>> > > >>> > for (unsigned r = 0; r < header->num_mbat; r++) { > >>> > unsigned long r = loadBigBlock(mblock, buffer2, bbat- > >>> > > >>> >>blockSize); > >>> >> > >>> > if (r != bbat->blockSize) { > >>> > delete[] buffer2; > >>> > return; > >>> > } > >>> > for (unsigned s = 0; s < bbat->blockSize - 4; s += 4) { > >>> > if (k >= header->num_bat) break; > >>> > else blocks[k++] = readU32(buffer2 + s); > >>> > } > >>> > mblock = readU32(buffer2 + bbat->blockSize - 4); > >>> > } > >>> > > >>> > The error is that the variable "r" is used as the loop counter, as > >>> > well recomputed inside the loop. This clearly is a bug, but I do not > >>> > know the code to fix it. > >>> > > >>> > Christoph Feck (kdepepo) > >>> > KDE Quality Team > >>> > _______________________________________________ > >>> > calligra-devel mailing list > >>> > calligra-devel@kde.org > >>> > https://mail.kde.org/mailman/listinfo/calligra-devel > >>> > >>> -- > >>> Best Regards, > >>> Yue Liu > >>> _______________________________________________ > >>> calligra-devel mailing list > >>> calligra-devel@kde.org > >>> https://mail.kde.org/mailman/listinfo/calligra-devel > >> > >> -- > >> Matus Uzak > >> Software Designer > >> Ixonos Slovakia s.r.o. > >> Sturova 27, 040 01 Kosice, Slovakia > >> mobile 0421 918 718 958 > >> email: matus.u...@ixonos.com > >> http://www.ixonos.com > >> > >> _______________________________________________ > >> calligra-devel mailing list > >> calligra-devel@kde.org > >> https://mail.kde.org/mailman/listinfo/calligra-devel _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
