----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104602/#review12449 -----------------------------------------------------------
Ship it! Looks good! only master though - C. Boemann On April 15, 2012, 2:52 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104602/ > ----------------------------------------------------------- > > (Updated April 15, 2012, 2:52 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Another thing that always sticked into my eyes with Calligra was that the > numbers in the rulers did not have a margin around or are even painted over > the rectangle of the horizontal ruler for me. Attached patch fixes that for > me, cmp. also the screenshots. > > It adds a 1 pixel margin around the numbers to both the outside border and > the mark's line. > Also makes the rectangle of the horizontal ruler use the full height. Having > this smaller just for the tabs & line starts/ends can be questioned, as in > Krita and other non-mainly text-oriented UIs there is no need for that, so > just a useless mismatch between horizontal and vertical ruler. And the > smaller rectangle did not really seem to improve usability with text layout > control for me. > > Also improves the centering of the number in the horizontal ruler (using /2.0 > instead of /2). > (vertical ruler has an offset due to an error in Qt? the coords are okay, as > proved by drawing test lines, just the text has a +1 pixel offset) > > Code adds the assumption that digits for the number only use glyphs which do > not go below the baseline. Does this hold? > > Ideally the color of the markers are not also in the text color, but some > widget color. I tried the Inactive text color for now. Any better idea, which > works with both the normal background and the active rectangle? (too bad > there is no QWidget standard element for rulers) > > FYI, in general, after this fix I would like to try another look, partially > inspired by other rulers out there ;) Also that for updates (like on mouse > move) the whole ruler is repainted makes me cry :) > > There also seems to be an error with the "new tab element" being shown inside > the ruler in Krita and others? To be corrected in another patch first. > > > Diffs > ----- > > libs/main/KoRuler.cpp b511000 > > Diff: http://git.reviewboard.kde.org/r/104602/diff/ > > > Testing > ------- > > Changed the zoom and also edited tabulators. > > > Screenshots > ----------- > > Before > http://git.reviewboard.kde.org/r/104602/s/529/ > After > http://git.reviewboard.kde.org/r/104602/s/530/ > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
