----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104164/#review11148 -----------------------------------------------------------
Ship it! I'm not going to pretend I understand what you do in details, but it does look like you use sound coding principles, and obviously I understand the big picture. Could you please fix my small comments and then very importantly: Create a diff and commit that to master. Do NOT just merge to master. I'd like this to be a single commit in master. and please try and write a 10-20 lines long commit messsage. Great work! libs/kotext/KoInlineCite.h <http://git.reviewboard.kde.org/r/104164/#comment8976> no spaces please plugins/textshape/dialogs/BibliographyConfigureDialog.cpp <http://git.reviewboard.kde.org/r/104164/#comment8977> Shouldn't these be i18n? plugins/textshape/dialogs/BibliographyTemplate.cpp <http://git.reviewboard.kde.org/r/104164/#comment8978> i18n ? plugins/textshape/dialogs/BibliographyTemplate.cpp <http://git.reviewboard.kde.org/r/104164/#comment8979> i18n ? plugins/textshape/dialogs/CitationInsertionDialog.cpp <http://git.reviewboard.kde.org/r/104164/#comment8980> i18n plugins/textshape/dialogs/CitationInsertionDialog.cpp <http://git.reviewboard.kde.org/r/104164/#comment8981> i18n plugins/textshape/dialogs/InsertBibliographyDialog.cpp <http://git.reviewboard.kde.org/r/104164/#comment8982> no spaces please plugins/textshape/dialogs/InsertBibliographyDialog.cpp <http://git.reviewboard.kde.org/r/104164/#comment8983> ' ' is probably faster - C. Boemann On March 5, 2012, 7:49 p.m., Smit Patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104164/ > ----------------------------------------------------------- > > (Updated March 5, 2012, 7:49 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Patch adds support for > bibliography configurations (sort/prefix/suffix/numbered entries/sort by > position). > insert custom bibliography (add/remove bibliography fields/span entries) > > > Diffs > ----- > > libs/kotext/BibliographyGenerator.h f30938c > libs/kotext/BibliographyGenerator.cpp a56244a > libs/kotext/KoBibliographyInfo.h 85bafd4 > libs/kotext/KoBibliographyInfo.cpp d4dc845 > libs/kotext/KoInlineBibliography.h b94324d > libs/kotext/KoInlineBibliography.cpp 55c8648 > libs/kotext/KoInlineCite.h f325031 > libs/kotext/KoInlineCite.cpp da4d987 > libs/kotext/KoInlineTextObjectManager.h c36c5c3 > libs/kotext/KoInlineTextObjectManager.cpp 5465148 > libs/kotext/KoTextEditor.h fdc4404 > libs/kotext/KoTextEditor.cpp afaebcc > libs/kotext/ToCBibGeneratorInfo.h 3836889 > libs/kotext/styles/KoStyleManager.h 387e7fb > libs/kotext/styles/KoStyleManager.cpp c75c768 > libs/odf/KoOdfBibliographyConfiguration.h 6af8a99 > libs/odf/KoOdfBibliographyConfiguration.cpp 4e62bf7 > plugins/textshape/CMakeLists.txt ed6154d > plugins/textshape/ReferencesTool.h 8e84371 > plugins/textshape/ReferencesTool.cpp 025b650 > plugins/textshape/dialogs/BibliographyConfigureDialog.h 94544bc > plugins/textshape/dialogs/BibliographyConfigureDialog.cpp a353830 > plugins/textshape/dialogs/BibliographyConfigureDialog.ui 2a54699 > plugins/textshape/dialogs/BibliographyPreview.h PRE-CREATION > plugins/textshape/dialogs/BibliographyPreview.cpp PRE-CREATION > plugins/textshape/dialogs/BibliographyTemplate.h PRE-CREATION > plugins/textshape/dialogs/BibliographyTemplate.cpp PRE-CREATION > plugins/textshape/dialogs/CitationInsertionDialog.cpp a6ff22a > plugins/textshape/dialogs/InsertBibliographyDialog.h 9b16835 > plugins/textshape/dialogs/InsertBibliographyDialog.cpp a8ee85b > plugins/textshape/dialogs/InsertBibliographyDialog.ui 262671b > plugins/textshape/dialogs/SimpleCitationBibliographyWidget.h d43bf68 > plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp 4bbd96d > plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui d447d8d > > Diff: http://git.reviewboard.kde.org/r/104164/diff/ > > > Testing > ------- > > Citations can be shown as numbered entries with custom prefix/suffix. > Changes in sort/sort by position reflects in generated bibliography as they > should be. > Inserting bibliography works with custom bibliography fields/span entries. > > > Thanks, > > Smit Patel > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
