-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104524/#review12270
-----------------------------------------------------------


i can not reproduce the behaviour you describe in Words (but the canvas looses 
focus), and to me it sounds more like you don't accept the keypress event when 
you consume it

That said I wouldn't mind removing this shortcut

- C. Boemann


On April 9, 2012, 1:31 p.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104524/
> -----------------------------------------------------------
> 
> (Updated April 9, 2012, 1:31 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The escape key sees a lot of use. It closes the find toolbar, it closes paths 
> in path tools and so on. But no matter what reason the user presses Escape 
> for, it will also enable the Interaction Tool. That means that in words, if 
> you search for a word and press escape to close the find bar, the text tool 
> is disabled. In krita, if you deselect a path, the path tool is deselected.
> 
> I propose to remove this switch, as shown in the patch.
> 
> 
> This addresses bug 297599.
>     http://bugs.kde.org/show_bug.cgi?id=297599
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoToolManager.cpp c121d0f 
> 
> Diff: http://git.reviewboard.kde.org/r/104524/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to