> On March 15, 2012, 3:22 p.m., Thorsten Zachmann wrote: > > libs/odf/KoXmlWriter.cpp, lines 353-357 > > <http://git.reviewboard.kde.org/r/104288/diff/2/?file=53358#file53358line353> > > > > I think it should not break on a control character but just skip it and > > continue with the next character.
yes agree - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104288/#review11436 ----------------------------------------------------------- On March 15, 2012, 3:11 p.m., Matus Uzak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104288/ > ----------------------------------------------------------- > > (Updated March 15, 2012, 3:11 p.m.) > > > Review request for Calligra, Thorsten Zachmann and C. Boemann. > > > Description > ------- > > We already skip those codes in the addTextSpan function but not in the > escapeForXML function called by addTextNode. Especially binary data > (doc/ppt/xls) can contain those, most often the NAK control code. > > > Diffs > ----- > > libs/odf/KoXmlWriter.cpp d51c61f > > Diff: http://git.reviewboard.kde.org/r/104288/diff/ > > > Testing > ------- > > Usual round with cstrunner on binary file formats. > > A test file which contains a NAK: > http://neuron.tuke.sk/~uzak/calligra/test-flipr-ses-2-5072.doc > > > Thanks, > > Matus Uzak > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
