Re: Rewriting Flow & formulashape for 3.0? (Re: Qt5 Port Status)

2015-04-08 Thread Inge Wallin
On Wednesday, April 08, 2015 22:07:46 Friedrich W. H. Kossebau wrote: > Hi Yue, > > good to see that you among other things have already turned Karbon back to > life in the Qt5/KF5 spheres :) Rock on! > > Now, the plan for Calligra 3.0 was to focus on porting all code to Qt5 and > KF5. > > No re

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-05 Thread Inge Wallin
On Sunday, April 05, 2015 18:01:02 Robert Mathias Marmorstein wrote: > > On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote: > > > The patch looks good to me. > > > > Robert Mathias Marmorstein wrote: > > I downloaded the tests from calligratests, but haven't been able to > > get the QP

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-05 Thread Inge Wallin
On Sunday, April 05, 2015 12:00:35 PM Boudewijn Rempt wrote: > > On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote: > > > The patch looks good to me. > > > > Robert Mathias Marmorstein wrote: > > I downloaded the tests from calligratests, but haven't been able to > > get the QPro plugi

Re: Review Request 123195: fix various bugs related to footnotes

2015-03-31 Thread Inge Wallin
lt styles for footnotes etc? And regarding the anchors, shouldn't they be superscript by default? - Inge Wallin On March 31, 2015, 1:25 p.m., Camilla Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 123165: Compile error fix for libmsooxml

2015-03-28 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123165/#review78155 --- Ship it! Looks ok to me. - Inge Wallin On March 28, 2015

Re: Review Request 122546: Core changes to implement outliner for Author

2015-03-24 Thread Inge Wallin
Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122546/ > --- > > (Updated March 24, 2015, 5:53 p.m.) > > > Review request for Calligra, Camill

Re: Review Request 123039: Porting of KReport to Qt5/KF5

2015-03-18 Thread Inge Wallin
diff into the review request like is normally done? - Inge Wallin On March 18, 2015, 7:34 p.m., Adam Pigg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: GSoC participating with Calligra

2015-03-14 Thread Inge Wallin
On Saturday, March 14, 2015 11:28:06 Станислав Долганов wrote: > Hello, > > I'm student of Moscow State University, Faculty of Computation Mathematics > and Cybernetics. > > I want to participate in Summer of Code with Calligra. There is only one > Calligra's project idea on the KDE ideas page an

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-03-02 Thread Inge Wallin
e3 filters/sheets/xlsx/XlsxXmlDrawingReader.h 69c75ac filters/sheets/xlsx/XlsxXmlDrawingReader.cpp def1ff6 Diff: https://git.reviewboard.kde.org/r/122045/diff/ Testing --- There is no new code at all, only rearrangement. But all the filters work as expected.

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-03-02 Thread Inge Wallin
eader/OdtReaderBackend.h ae321ab filters/libodfreader/OdtReaderBackend.cpp cdc59f1 Diff: https://git.reviewboard.kde.org/r/122035/diff/ Testing --- Tested with extensive traces and existing filters that use the library. Thanks, Inge W

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Inge Wallin
> On Feb. 24, 2015, 8:40 p.m., Inge Wallin wrote: > > libs/rdf/KoDocumentRdf.cpp, line 57 > > <https://git.reviewboard.kde.org/r/122546/diff/1/?file=348543#file348543line57> > > > > Probably so that the #define can be commented out quickly when you want

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Inge Wallin
is Author only so far, right? Can we leave it as it is for now and then discuss how we want to proceed with this during the porting effort? - Inge Wallin On Feb. 12, 2015, 9:22 p.m., Denis Kuplyakov wrote: > > --- > This is an aut

Re: Review Request 122584: Use shared pointers for markers.

2015-02-16 Thread Inge Wallin
> On Feb. 16, 2015, 11:11 a.m., Inge Wallin wrote: > > Wouldn't a much better solution be to make the Private class of the > > KoMarker shared? If so, we could have the collection store KoMarkers > > instead of a collection of KoMarker*s. Making KoMarker itself a Q

Re: Review Request 122584: Use shared pointers for markers.

2015-02-16 Thread Inge Wallin
> On Feb. 16, 2015, 11:11 a.m., Inge Wallin wrote: > > Wouldn't a much better solution be to make the Private class of the > > KoMarker shared? If so, we could have the collection store KoMarkers > > instead of a collection of KoMarker*s. Making KoMarker itself a Q

Re: Review Request 122584: Use shared pointers for markers.

2015-02-16 Thread Inge Wallin
class of the KoMarker shared? If so, we could have the collection store KoMarkers instead of a collection of KoMarker*s. Making KoMarker itself a QSharedData feels very strange and is different than anything else in Calligra. - Inge Wallin On Feb. 16, 2015, 2:26 a.m., Sven Langkamp

Re: Flake event handling changes - draft proposal

2015-02-02 Thread Inge Wallin
Hi Tomas, It is obvious that you have really thought this through. But although your technical solution seems solid, I think you are missing one aspect: how the user interaction should work. The problem, as you say, right now is that the user can edit shapes but then has no easy way to get ba

Re: Review Request 122306: Fix bug 260088 - assert when ungrouping group

2015-01-29 Thread Inge Wallin
Testing --- manual testing according to the bug report. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 122306: Fix bug 260088 - assert when ungrouping group

2015-01-29 Thread Inge Wallin
ix first, though and then estan can fix the strange behaviour since it's in his new code. Diffs - words/part/KWView.cpp f20199a Diff: https://git.reviewboard.kde.org/r/122306/diff/ Testing --- manual testing according to the bug repor

Re: Review Request 122278: Additional changes in section handling

2015-01-29 Thread Inge Wallin
On Thursday, January 29, 2015 14:11:39 Inge Wallin wrote: > On Thursday, January 29, 2015 12:57:35 Denis Kuplyakov wrote: > > > On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > > > libs/kotext/KoSectionManager.cpp, line 120 > > > > <https://git.re

Re: Review Request 122278: Additional changes in section handling

2015-01-29 Thread Inge Wallin
has many things like own > style, name and so on (and I can't say that delimiter could have style). > And KoSectionEnd is a simple helper class that links to corresponding > KoSection. > > > - Denis > > > ------

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Inge Wallin
x27;m satisfied. - Inge Wallin On Jan. 27, 2015, 10:48 a.m., Camilla Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-26 Thread Inge Wallin
I think instead that all layout should be in shape coordinates, i.e. from (0, 0) to (sizeX, sizeY). This handling of world coordinates inside a shape is an abomination to all that is good in linear algebra. But I understand that this is perhaps not the time and place to change tha

Re: Merge window before the port starts

2015-01-25 Thread Inge Wallin
res that are ready to merge to master right now or within the next few days. > On 25 January 2015 at 17:42, C. Boemann wrote: > > On Sunday 25 January 2015 14:26:01 Inge Wallin wrote: > >> So let's have a short window before the porting starts then. > > > > Could

Re: Merge window before the port starts

2015-01-25 Thread Inge Wallin
On Sunday, January 25, 2015 13:59:57 Boudewijn Rempt wrote: > On Sun, 25 Jan 2015, Inge Wallin wrote: > > I, myself, see no reason why we cannot open master for patches of this > > type > > already now, but I will let you decide whether opening master now or wait > >

Merge window before the port starts

2015-01-25 Thread Inge Wallin
Hi, As you have probably seen I have two patches that I deem mature on the review board right now. These are branches that have been Ok'ed and are ready to merge. And I know that there are others with similar branches laying around. It would be a pity to let them bitrot more than necessary. I

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-25 Thread Inge Wallin
d. Update: I learned later that there is macro that takes care of this, so maybe just document that a bit and it's fine. - Inge Wallin On Jan. 25, 2015, 1:40 a.m., Camilla Boemann wrote: > > --- > This

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-24 Thread Inge Wallin
explanation what this struct is good for? libs/kotext/commands/ChangeStylesMacroCommand.cpp <https://git.reviewboard.kde.org/r/122238/#comment51762> This should be commented out - Inge Wallin On Jan. 24, 2015, 8:27 p.m., Camilla Boemann wrote: > > --

Re: Merging all fixes for 2.9

2015-01-23 Thread Inge Wallin
d or discussed. Frankly it sounds strange to me. If nothing else comes up, I will do a normal merge tonight around 9pm. -Inge > On Thursday, 22 January 2015, Inge Wallin wrote: > > On Thursday, January 22, 2015 14:34:07 Jaroslaw Staniek wrote:

Re: Merging all fixes for 2.9

2015-01-22 Thread Inge Wallin
why don't you revert it in 2.9 already? -Inge > On Thursday, 22 January 2015, Inge Wallin wrote: > > On Thursday, January 22, 2015 12:02:47 Cyrille Berger wrote: > >> On 2015-01-19 22:35, Inge Wallin wrote: > >> > On Monday, January 19, 2015 17:25:33 Inge

Re: Merging all fixes for 2.9

2015-01-22 Thread Inge Wallin
On Thursday, January 22, 2015 12:02:47 Cyrille Berger wrote: > On 2015-01-19 22:35, Inge Wallin wrote: > > On Monday, January 19, 2015 17:25:33 Inge Wallin wrote: > >> On Monday, January 19, 2015 17:26:45 Boudewijn Rempt wrote: > >> > If you do, I think it should be a

Re: Merging all fixes for 2.9

2015-01-19 Thread Inge Wallin
On Monday, January 19, 2015 17:25:33 Inge Wallin wrote: > On Monday, January 19, 2015 17:26:45 Boudewijn Rempt wrote: > > If you do, I think it should be an ordinary merge, not a squash. > > yes, agree. Done. It went totally without problems. I think we should do this every 3-

Re: Merging all fixes for 2.9

2015-01-19 Thread Inge Wallin
On Monday, January 19, 2015 17:26:45 Boudewijn Rempt wrote: > If you do, I think it should be an ordinary merge, not a squash. yes, agree. > On Mon, 19 Jan 2015, Inge Wallin wrote: > > I talked with Boud today about various things and one thing that came up > > were all

Merging all fixes for 2.9

2015-01-19 Thread Inge Wallin
I talked with Boud today about various things and one thing that came up were all the fixes for 2.9. There are a lot of them and almost all of them are only on the 2.9 branch right now. This situation is potentially dangerous and will become worse as time goes by. I volunteered to merge 2.9 in

Qt5/KF5 porting plan

2015-01-18 Thread Inge Wallin
I have probably missed something important but the fact is that I am unable to find any written plan for our porting effort anywhere on community.kde.org. Can somebody point me to where the plan is? Stranger is that I have also failed to find anything definite in the calligra- devel archives goi

Re: I'm back

2015-01-18 Thread Inge Wallin
On Friday, January 16, 2015 22:23:42 Cyrille Berger wrote: > On Tuesday 13 January 2015 21:43:35 Boudewijn Rempt wrote: > > That's a good question, and it depends on what is in them. They probably > > should not go in the 2.9 release, which is what is pre-occupying my mind > > right now, but if you

Re: Review Request 122115: [OS X] source code adaptations to OS X

2015-01-18 Thread Inge Wallin
On Sunday, January 18, 2015 09:57:30 René J.V. Bertin wrote: > > On Jan. 18, 2015, 4:01 a.m., Inge Wallin wrote: > > > karbon/ui/KarbonView.cpp, line 1214 > > > <https://git.reviewboard.kde.org/r/122115/diff/1/?file=342472#file342472 > > > line1214>> >

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
rs work as expected. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
rts from anywhere. Note that the parsing code from various formats are in the filters, and not in libodf2. - Inge --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#revi

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
7;s generic chart stuff. The same class could be used for, say, Lotus 1-2-3 import, but then a specific reader for that format has to be written. See above for why it belongs in libodf2. - Inge Wallin On Jan. 13, 2015, 10:18 p.m., Inge Wallin wrote: > > ---

Re: Review Request 122115: [OS X] source code adaptations to OS X

2015-01-17 Thread Inge Wallin
<https://git.reviewboard.kde.org/r/122115/#comment51536> But this define is for both plugins and actual libraries, isn't it? Is this safe? dded - Inge Wallin On Jan. 17, 2015, 11:17 p.m., René J.V. Bertin wrote: > > --- >

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-17 Thread Inge Wallin
> On Jan. 17, 2015, 10:42 p.m., René J.V. Bertin wrote: > > Applies without issues on OS X; any suggestions how to check/test the new > > functionality? > > Inge Wallin wrote: > This are two parts to the patch: > 1. Less code using smart macros to do the sam

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-17 Thread Inge Wallin
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122035/#review74201 --- On Jan. 13, 2015, 3:30 p.m., Inge Wallin wrote: > > ---

Re: Two repos prepared for porting to Qt 5

2015-01-16 Thread Inge Wallin
o one after the other is finished. > Rejecting this workflow is another topic. There are just two workflows > the above being for special (short) time. > > On 16 January 2015 at 09:26, Inge Wallin wrote: > > On Friday, January 16, 2015 09:26:37 Jaroslaw Staniek wrote: > >>

Re: Two repos prepared for porting to Qt 5

2015-01-16 Thread Inge Wallin
On Friday, January 16, 2015 09:26:37 Jaroslaw Staniek wrote: > On 16 January 2015 at 09:14, Inge Wallin wrote: > > On Friday, January 16, 2015 01:26:20 Jaroslaw Staniek wrote: > >> Hi, > >> For those willing to work on porting, two repos have been created: > >>

Re: Two repos prepared for porting to Qt 5

2015-01-16 Thread Inge Wallin
On Friday, January 16, 2015 01:26:20 Jaroslaw Staniek wrote: > Hi, > For those willing to work on porting, two repos have been created: > > git clone kde:scratch/staniek/kproperty > git clone kde:scratch/staniek/kreport > > These are files cut off from calligra/2.9, with history. > It's best if y

Re: Review Request 110928: Always save the position of a shape

2015-01-14 Thread Inge Wallin
states what default values are, and we try not to write out > > default values in other cases. > > Inge Wallin wrote: > 1. I don't remember anymore how relevant this was to the bug mentioned in > the description, but I will look at it again and come back. > 2.

Re: I'm back

2015-01-13 Thread Inge Wallin
On Tuesday, January 13, 2015 21:58:49 René J.V. Bertin wrote: > Inge: did you post a link to a review request or something? If you did I > can't find it anymore. And if you didn't ... maybe you should! ;) https://git.reviewboard.kde.org/r/122035/ https://git.reviewboard.kde.org/r/122045/ > Oh, an

Re: I'm back

2015-01-13 Thread Inge Wallin
On Tuesday, January 13, 2015 21:54:40 René J.V. Bertin wrote: > On Tuesday January 13 2015 21:43:35 Boudewijn Rempt wrote: > > That's a good question, and it depends on what is in them. They probably > > should not go in the 2.9 release, which is what is pre-occupying my mind > > I haven't yet loo

Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-13 Thread Inge Wallin
s.txt 1f992dd Diff: https://git.reviewboard.kde.org/r/122045/diff/ Testing --- There is no new code at all, only rearrangement. But all the filters work as expected. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org

Re: I'm back

2015-01-13 Thread Inge Wallin
#x27;t work too hard if you are recovering! > > > > Adam > > > > On Tue Jan 13 2015 at 18:44:17 Inge Wallin wrote: > >> [resent, since the ML apparently ate the first version. Apologies if this > >> somehow turns up twice.] > >> > >> Hi ever

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-13 Thread Inge Wallin
eader/OdtReaderBackend.cpp cdc59f1 Diff: https://git.reviewboard.kde.org/r/122035/diff/ Testing --- Tested with extensive traces and existing filters that use the library. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org

Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-13 Thread Inge Wallin
https://git.reviewboard.kde.org/r/122035/diff/ Testing --- Tested with extensive traces and existing filters that use the library. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

I'm back

2015-01-13 Thread Inge Wallin
[resent, since the ML apparently ate the first version. Apologies if this somehow turns up twice.] Hi everybody, Some of you know already that I have been very sick but perhaps not everybody. However, I am much better now and recovery has gone so far that I feel that I can come back into the K

I'm back

2015-01-13 Thread Inge Wallin
Hi everybody, Some of you know already that I have been very sick but perhaps not everybody. However, I am much better now and recovery has gone so far that I feel that I can come back into the KDE and Calligra families again and be active. The most lasting difference between now and before is

Re: Review Request 120116: Simplify (and avoid warning) KoOdfListStyle::readProperties

2014-09-09 Thread Inge Wallin
ment46146> I prefer FIXME before TODO since that is what I grep for. (As a side note I think we should unify the use of FIXME, TODO and @todo in Calligra.) - Inge Wallin On Sept. 9, 2014, 2:07 p.m., Friedrich W. H. Kossebau wrote: > > ---

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-11 Thread Inge Wallin
iff: https://git.reviewboard.kde.org/r/118643/diff/ Testing --- Lots of manual testing during development Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Inge Wallin
wboard.kde.org/r/118643/#review64181 --- On Aug. 10, 2014, 4:02 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118643/ > --

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Inge Wallin
/WikiExport.cpp PRE-CREATION filters/words/wiki/export/words_wiki_export.desktop PRE-CREATION filters/words/wiki/wiki-format.xml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118643/diff/ Testing --- Lots of manual testing during development Thank

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

2014-08-10 Thread Inge Wallin
is correct (according to the comment, didn't read the spec), wouldn't it be clearer to use == instead of != ? - Inge Wallin On Aug. 3, 2014, 10:34 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically gen

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Inge Wallin
> On July 6, 2014, 2:10 p.m., Friedrich W. H. Kossebau wrote: > > Was this ever committed? > > Camilla Boemann wrote: > Don't think so but I also don't think it belongs to calligra anymore. > Laurent, what do you think? Hmm, why not? What would be a better place? I agree that if all word p

Re: Review Request 110928: Always save the position of a shape

2014-07-06 Thread Inge Wallin
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110928/#review61727 --- On June 10, 2013, 7:18 p.m., Inge Wallin wrote: > > --- > Thi

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-07-06 Thread Inge Wallin
What is this variable for? I can understand the rest of the members without a comment but not this one. - Inge Wallin On July 4, 2014, 2:32 p.m., Denis Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

2014-06-29 Thread Inge Wallin
> On June 29, 2014, 4:45 a.m., Inge Wallin wrote: > > In general looks good. But shouldn't the same idea be used in the other > > apps too? > > Boudewijn Rempt wrote: > It's something that is going away in the mvc branch in any case. Ok. I would love to

Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

2014-06-28 Thread Inge Wallin
18984/#comment42595> Not strictly necessary since DocBase::DocBase already has the same Q_ASSERT. If you want to keep it, I'm fine with that too. - Inge Wallin On June 27, 2014, 10:25 p.m., Jarosław Staniek wrote: > > -

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-26 Thread Inge Wallin
days now and we have already gotten into the nitpick stage of the review, I will take the liberty to say "good job!" and "ship it!". I am sure that any remaining problems can be fixed post merge. Denis: don't forget to use --squash when you merge the branch. - Inge Wal

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-22 Thread Inge Wallin
32/#comment42332> same here words/part/dockers/KWDebugWidget.cpp <https://git.reviewboard.kde.org/r/118532/#comment42333> EBN will complain that you're using a string for one character. :) - Inge Wallin On June 22, 2014, 8 p.m., Denis Kuplyakov wrote: > > -

Re: Review Request 111787: Page Layout improvements for Words

2014-06-22 Thread Inge Wallin
> On June 22, 2014, 8:13 p.m., Denis Kuplyakov wrote: > > test > > Denis Kuplyakov wrote: > Sorry, for this. Ignore it. Aw... I was hoping... :) - Inge --- This is an automatically generated e-mail. To reply, visit: https://git.rev

Re: Review Request 118643: Create an export filter for Wiki pages

2014-06-10 Thread Inge Wallin
xt 2bf1b0b Diff: https://git.reviewboard.kde.org/r/118643/diff/ Testing --- Lots of manual testing during development Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 118643: Create an export filter for Wiki pages

2014-06-10 Thread Inge Wallin
Testing --- Lots of manual testing during development Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Static code analysis

2014-06-05 Thread Inge Wallin
On Thursday, June 05, 2014 22:02:43 Jaroslaw Staniek wrote: > Dear All, > Just added a list of tools known as useful in C/C++ static code > analysis. Some are already used in our development, some need > volunteers. This is rather very interesting area - let's make Calligra > more bug-free, and it'

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-05 Thread Inge Wallin
> In general I prefer capital letter in front and a period after a sentence. This goes for many places in this patch. - Inge Wallin On June 5, 2014, 12:41 p.m., Denis Kuplyakov wrote: > > --- > This is an

Re: Review Request 118510: small rework of product sets: products, features and product sets

2014-06-04 Thread Inge Wallin
g/r/118510/#comment41244> OPD?? - Inge Wallin On June 4, 2014, 1:04 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-04 Thread Inge Wallin
#comment41234> spelling libs/kotext/opendocument/KoTextWriter_p.cpp <https://git.reviewboard.kde.org/r/118532/#comment41235> I don't understand this comment. libs/kotext/opendocument/KoTextWriter_p.cpp <https://git.reviewboard.kde.org/r/118532/#comment41236> same h

Re: Style objects for applications and filters

2014-05-03 Thread Inge Wallin
On Sunday, May 04, 2014 06:18:45 Thorsten Zachmann wrote: > On Monday, April 28, 2014 10:31:45 PM Inge Wallin wrote: > > * Represent styles as text attributes wherever possible so that they can > > be > > > > complete, i.e. not throw away style data. > > I&#

Re: Style objects for applications and filters

2014-04-28 Thread Inge Wallin
On Sunday, April 27, 2014 06:21:55 Thorsten Zachmann wrote: > On Friday, April 25, 2014 12:50:15 PM Inge Wallin wrote: > > I would like to have the opinion of the community for a certain issue. The > > first version of the docx export filter is now merged and it's time to &

Re: Style objects for applications and filters

2014-04-26 Thread Inge Wallin
On Friday, April 25, 2014 12:50:15 Inge Wallin wrote: > So here is the question: When we move forward with the docx filter, should > we either: > > - add stream reading capabilities and maybe storage of properties > represented as text to the objects in libs/odf > > o

Style objects for applications and filters

2014-04-25 Thread Inge Wallin
I would like to have the opinion of the community for a certain issue. The first version of the docx export filter is now merged and it's time to take the next step. But this next step involves a decision which needs the input from the rest of the Calligra community. The docx filter uses stream

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-22 Thread Inge Wallin
board.kde.org/r/117626/diff/ Testing --- Testing with a number of odt files. Lassi did all the testing involving MS Office since I don't have that. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-21 Thread Inge Wallin
/KoZipStore.cpp 4235134 Diff: https://git.reviewboard.kde.org/r/117626/diff/ Testing --- Testing with a number of odt files. Lassi did all the testing involving MS Office since I don't have that. Thanks, Inge Wallin ___ calligra-devel m

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-21 Thread Inge Wallin
91#file266891line152> > > > > BTW, return false on failure as we do everywhere Agree but out of scope for this patch. That should be done in master and separately. - Inge --- This is an automatically generated e-

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-21 Thread Inge Wallin
is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117626/#review56104 --- On April 20, 2014, 8:11 a.m., Inge Wallin wrote: > > -

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-20 Thread Inge Wallin
29f34 libs/odf/KoZipStore.h 90ffcb0 libs/odf/KoZipStore.cpp 4235134 Diff: https://git.reviewboard.kde.org/r/117626/diff/ Testing --- Testing with a number of odt files. Lassi did all the testing involving MS Office since I don't have that. Thanks, Inge Wallin

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-20 Thread Inge Wallin
4 Diff: https://git.reviewboard.kde.org/r/117626/diff/ Testing --- Testing with a number of odt files. Lassi did all the testing involving MS Office since I don't have that. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-19 Thread Inge Wallin
tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117626/#review56039 ------- On April 18, 2014, 9:38 a.m., Inge Wallin wrote: > > --- > This is an

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-19 Thread Inge Wallin
tors. > > > > I propose to commit this fix independently to master and 2.8. > > Committed to master. - Inge --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-19 Thread Inge Wallin
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117626/#review56039 --- On April 18, 2014, 9:38 a.m., Inge Wallin wrote: > > ---

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-19 Thread Inge Wallin
it: https://git.reviewboard.kde.org/r/117626/#review56043 --- On April 18, 2014, 9:38 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-19 Thread Inge Wallin
> On April 19, 2014, 10:14 a.m., Inge Wallin wrote: > > filters/words/docx/export/FileCollector.cpp, line 46 > > <https://git.reviewboard.kde.org/r/117626/diff/1/?file=266871#file266871line46> > > > > I don't understand. What is d

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-19 Thread Inge Wallin
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117626/#review56043 ------- On April 18, 2014, 9:38 a.m., Inge Wallin wrote: > >

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-19 Thread Inge Wallin
tps://git.reviewboard.kde.org/r/117626/#comment39114> I don't understand. What is duplicated? - Inge Wallin On April 18, 2014, 9:38 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-18 Thread Inge Wallin
.kde.org/r/117626/#comment39103> Why only 2007? It's not clear which version of ooxml we are targetting. I suggest not changing this until we have decided. - Inge Wallin On April 18, 2014, 9:38 a.m., Inge Wallin wrote: > >

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-18 Thread Inge Wallin
s. Lassi did all the testing involving MS Office since I don't have that. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 117626: Implement the first version of a DOCX export filter

2014-04-18 Thread Inge Wallin
ng involving MS Office since I don't have that. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 116533: Bug 142563

2014-04-10 Thread Inge Wallin
ice that you shouldn't omit the "the"). But actually I think "smallest integer" is better so I like the original text. - Inge Wallin On March 2, 2014, 3:12 p.m., Swarn Kumar wrote: > > --- &g

Re: Review Request 116835: Implementing "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page(issues resolved).

2014-03-17 Thread Inge Wallin
> On March 16, 2014, 9:34 p.m., Jarosław Staniek wrote: > > Hi, please use "Update -> Update Diff" command on you previous review - > > https://git.reviewboard.kde.org/r/116746/ - instead of opening a new one. > > Thanks. > > Jarosław Staniek wrote: > Also, the rule of interaction in revi

Re: Review Request 116662: Navigator docker for Words

2014-03-17 Thread Inge Wallin
, I'm fine with merging this branc. Nice work! - Inge Wallin On March 11, 2014, 12:06 p.m., Denis Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 114243: Don't print annotations

2014-03-15 Thread Inge Wallin
/textshape/AnnotationTextShape.cpp 311d6bf Diff: https://git.reviewboard.kde.org/r/114243/diff/ Testing --- Testing with my standard text documents with annotations. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://ma

Re: Start Developing

2014-03-09 Thread Inge Wallin
th : Could you help me for starting?! > > Before i send this mail to list i contact Inge Wallin and Jaroslaw Staniek > in IRC. > I want to create a plugins for Author (Section Separator). > > If anyone work on Author and it's Plugins please guidance! > > Thanks I have m

Re: Review Request 116662: Navigator docker for Words

2014-03-08 Thread Inge Wallin
/KWNavigationWidget.cpp <https://git.reviewboard.kde.org/r/116662/#comment37091> Btw, I think I missed this in my last review. Normally we use this layout in calligra: Foo::Foo() : FooBase , m_member1(0) , m_member2(xyz) { ... } - Inge Walli

Re: Review Request 116662: Navigator docker for Words

2014-03-08 Thread Inge Wallin
e training spaces if I remember correctly. - Inge Wallin On March 8, 2014, 6:18 p.m., Denis Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To reply

  1   2   3   4   5   6   7   >