----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119579/#review64146 -----------------------------------------------------------
Ship it! Looks good. I commented on a trivial readability issue but that's really minor. If this works for your test documents, then feel free to merge. And now also implement the same in the export filter. :) filters/words/docx/import/DocxXmlDocumentReader.cpp <https://git.reviewboard.kde.org/r/119579/#comment44796> While this is correct (according to the comment, didn't read the spec), wouldn't it be clearer to use == instead of != ? - Inge Wallin On Aug. 3, 2014, 10:34 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119579/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2014, 10:34 p.m.) > > > Review request for Calligra, Inge Wallin and Lassi Nieminen. > > > Repository: calligra > > > Description > ------- > > Works for my testing docs, and now also done with the spec read. > > > Diffs > ----- > > filters/words/docx/import/DocxXmlDocumentReader.h a61fe56 > filters/words/docx/import/DocxXmlDocumentReader.cpp dccda61 > > Diff: https://git.reviewboard.kde.org/r/119579/diff/ > > > Testing > ------- > > Compared ToC structure for my testing docx samples as seen by LO and Calligra > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
