----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120116/#review66130 -----------------------------------------------------------
Ship it! Looks good. Just a couple of minor things, but no need to resubmit for a new review. filters/libodf2/KoOdfListStyle.cpp <https://git.reviewboard.kde.org/r/120116/#comment46145> This kDebug is not needed right now so you could comment it out. filters/libodf2/KoOdfListStyle.cpp <https://git.reviewboard.kde.org/r/120116/#comment46146> I prefer FIXME before TODO since that is what I grep for. (As a side note I think we should unify the use of FIXME, TODO and @todo in Calligra.) - Inge Wallin On Sept. 9, 2014, 2:07 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120116/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 2:07 p.m.) > > > Review request for Calligra and Inge Wallin. > > > Repository: calligra > > > Description > ------- > > Currently in KoOdfListStyle::readProperties the propertiesType is checked two > times, while one could be enough. This also removes a (wrong) warning by the > compiler. > > > Diffs > ----- > > filters/libodf2/KoOdfListStyle.cpp 85938a8 > > Diff: https://git.reviewboard.kde.org/r/120116/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
